davidedmundson added a comment.

  In general +1.
  A comment at the top of Loader making it clear it's not a loader for the 
applet would help.

INLINE COMMENTS

> main.qml:292
> +            active: applet && applet.busy
> +            sourceComponent: PlasmaComponents.BusyIndicator {}
> +

In the old code this was the size of the applet
Now it's the implicit size of busy indicator.

Might be a problem for tiny panels

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9152

To: hein, #plasma, mart
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to