Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/ --- (Updated June 24, 2014, 12:18 a.m.) Status -- This change has been m

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/#review60873 --- This review has been submitted with commit 5819be48aafef34654

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Christoph Feck
> On June 23, 2014, 10:41 p.m., Christoph Feck wrote: > > Not sure why you added Marcel to the list of reviewers... > > > > Anyway, if the current patch is all that is needed to restore sanity as in > > KDE 3, the I am all for getting it fixed. (And if the same issue was the cause for the KRan

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60866 --- Not sure why you added Marcel to the list of reviewers... Any

Re: Review Request 118804: Register ksmserver as logind session leader

2014-06-23 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118804/ --- (Updated June 23, 2014, 8:26 p.m.) Status -- This change has been di

Re: Review Request 118804: Register ksmserver as logind session leader

2014-06-23 Thread Elias Probst
> On June 22, 2014, 2:54 p.m., Àlex Fiestas wrote: > > According to Lennart we should not call TakeControl, so I guess that while > > we wait for kdbus we should discard this review? > > Martin Gräßlin wrote: > why? And what does that have to do with kdbus? And how long should we > wait fo

Re: Review Request 118908: Adjust taskmanager tooltip size to window thumbnail

2014-06-23 Thread Marco Martin
> On June 23, 2014, 7:16 p.m., Eike Hein wrote: > > This causes the tooltips to no longer be uniform in size, which causes > > extra visual busyness when moving between tasks. Tooltip resize performance > > also isn't stellar right now, and size changes are especially deadly for > > right-alig

Re: Review Request 118908: Adjust taskmanager tooltip size to window thumbnail

2014-06-23 Thread Kai Uwe Broulik
> On June 23, 2014, 7:16 p.m., Eike Hein wrote: > > This causes the tooltips to no longer be uniform in size, which causes > > extra visual busyness when moving between tasks. Tooltip resize performance > > also isn't stellar right now, and size changes are especially deadly for > > right-alig

Re: Review Request 118908: Adjust taskmanager tooltip size to window thumbnail

2014-06-23 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118908/#review60837 --- This causes the tooltips to no longer be uniform in size, whic

Re: Re: Re: which product to use for bugreport?

2014-06-23 Thread Martin Gräßlin
Martin GräßlinOn Friday 20 June 2014 10:17:50 wrote: > On Friday 20 June 2014 11:17:41 Damian Ivanov wrote: > > >Given the high regression potential (windows which used to be included > > >aren't shown any more - yes the one user's bug is the other user's > > >feature) I would highly recommend to

Review Request 118908: Adjust taskmanager tooltip size to window thumbnail

2014-06-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118908/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Des

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Luca Beltrame
In data lunedì 23 giugno 2014 18:29:21, Marco Martin ha scritto: > It's a bit different, we want distros to package it, but not them to make it > the default desktop, at least for a while (and that was the main problem of > 4.0) Speaking for openSUSE: P5 will not be default for the next upcoming

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Marco Martin
> On June 23, 2014, 6:09 p.m., Eike Hein wrote: > > Thanks for addressing those issues. I'd say let's commit it now. I'm still > > not sure that it might not be too heavy visually, but to find out we need > > broader feedback I think. So let's put it in and monitor responses :). I think visual

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/#review60832 --- Ship it! Thanks for addressing those issues. I'd say let's co

Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/#review60829 --- This review has been submitted with commit 347e073df39429bf1b

Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

2014-06-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/ --- (Updated June 23, 2014, 5:59 p.m.) Status -- This change has been ma

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: > > kcmkgamma/init_kgamma.cpp, line 39 > > > > > > why delete config? I would just use a KSharedConfig::openConfig > > Wolfgang Bauer wrote: > I just copy/

Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

2014-06-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/#review60827 --- Ship it! Ship It! - David Edmundson On June 23, 2014, 5:39

Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

2014-06-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/ --- (Updated June 23, 2014, 5:39 p.m.) Review request for Plasma and Martin G

Review Request 118906: Fix dialog's check for isTooltip

2014-06-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Martin Gräßlin
> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: > > kcmkgamma/init_kgamma.cpp, line 39 > > > > > > why delete config? I would just use a KSharedConfig::openConfig > > Wolfgang Bauer wrote: > I just copy/

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: > > kcmkgamma/init_kgamma.cpp, lines 1-8 > > > > > > please use a copyright header as in > > http://techbase.kde.org/Policies/Licensing_Policy#GPL_Header I jus

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 3:21 p.m., Sebastian Kügler wrote: > > I think there's a couple of problems with this approach: > > > > - This slows down startup for everybody, not just those who changed the > > setting. I'm not super-familiar with this, but isn't kcminit for this > > use-case? > > - Chan

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/ --- (Updated June 23, 2014, 7:01 p.m.) Review request for kde-workspace, Plas

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Ivan Čukić
Aleix Pol wrote: > reports open that will render your life miserable. And this is the sentence for which I think we need the message. "We have no bugs that will make your life miserable". :) > We want distros to package it, we just don't want people using 5.0 when 5.1 > is released, it's not ver

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Marco Martin
On Monday 23 June 2014, Aleix Pol wrote: > I don't really think the problem is the distributions there. Actually if > 5.1 is going to be any stabler, it will be because of the testing we get by > the users. If you look at the bug tracker, there's not that much bug > reports open that will render

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Aleix Pol
On Mon, Jun 23, 2014 at 6:13 PM, Ivan Čukić wrote: > David Edmundson wrote: > > If we did that if someone had a fatal crash they wouldn't be able to > > contribute to testing for 3 months, which would be a shame. > > Good point. Though, those do not need to be bugfix-only releases then. But > ok.

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread David Edmundson
> Well, it might be my pessimism, but I don't want us to repeat the history with > this one. Is Plasma 5 really ready for a day-to-day replacement of 4.x for an > average user? Are the distributions up to the task this time? > > " trust our release" is what we did before, and it backfired. Hugely.

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Ivan Čukić
David Edmundson wrote: > If we did that if someone had a fatal crash they wouldn't be able to > contribute to testing for 3 months, which would be a shame. Good point. Though, those do not need to be bugfix-only releases then. But ok. Aleix Pol wrote: > I thought we agreed that this message doesn

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread David Edmundson
> I thought we agreed that this message doesn't work and we want people to > trust our release as much as possible. > One thing that is very important is to warn users that newer Qt versions > might fix their workflows. and newer mesa versions. > > Aleix > > ___

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Marco Martin
On Monday 23 June 2014, Aleix Pol wrote: > > > > Cheerio, > > Ivan > > I thought we agreed that this message doesn't work and we want people to > trust our release as much as possible. > One thing that is very important is to warn users that newer Qt versions > might fix their workflows. I still

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Aleix Pol
On Mon, Jun 23, 2014 at 5:54 PM, Ivan Čukić wrote: > > > I assumed there would have been monthly bugfix releases as in 4.x? > > > > frameworks (so plasma-framework as well) would have if i understood > > correctly montly releases (with minimal feature additions and bugfixes) > > > > the workspace

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread David Edmundson
> > As for 5.0, I'd really love to see no bug-fix releases, with the message being > 'this is not for general population, not for production systems'. If we did that if someone had a fatal crash they wouldn't be able to contribute to testing for 3 months, which would be a shame. __

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Ivan Čukić
> I assumed there would have been monthly bugfix releases as in 4.x? > > frameworks (so plasma-framework as well) would have if i understood > correctly montly releases (with minimal feature additions and bugfixes) > > the workspace part I think could have a multiple of that? There are two ques

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Sebastian Kügler
On Monday, June 23, 2014 17:27:50 Martin Graesslin wrote: > On Monday 23 June 2014 16:56:55 Marco Martin wrote: > > On Monday 23 June 2014, Rohan Garg wrote: > > > Hi everyone > > > I was wondering, has there been any discussions on whether or not bug > > > fix releases for Plasma 5 will be provide

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Martin Graesslin
On Monday 23 June 2014 16:56:55 Marco Martin wrote: > On Monday 23 June 2014, Rohan Garg wrote: > > Hi everyone > > I was wondering, has there been any discussions on whether or not bug > > fix releases for Plasma 5 will be provided after the 5.0 release? Or > > will users simply have to wait for t

Re: Review Request 118900: Improve dependencies.

2014-06-23 Thread Michael Palimaka
> On June 23, 2014, 3:10 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 28 > > > > > > If you want these to be optional, you can pass them in > > OPTIONAL_COMPONENTS, from the top find_package. It look

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Rohan Garg
> I think that plasma releases can follow KF5, we could get at least 5.0.1 in > August 15th and 5.0.2 in September 15th. As downstream, I would very much appreciate monthly bug fix releases :) Cheers Rohan Garg ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60809 --- kcmkgamma/init_kgamma.cpp

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread David Edmundson
> I think that plasma releases can follow KF5, we could get at least 5.0.1 in > August 15th and 5.0.2 in September 15th. > > About Plasma 5.1, did we agree on a 3-month schedule? > +1 to that. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mai

Re: Review Request 118900: Improve dependencies.

2014-06-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118900/#review60808 --- CMakeLists.txt

Review Request 118900: Improve dependencies.

2014-06-23 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118900/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Aleix Pol
On Mon, Jun 23, 2014 at 4:56 PM, Marco Martin wrote: > On Monday 23 June 2014, Rohan Garg wrote: > > Hi everyone > > I was wondering, has there been any discussions on whether or not bug > > fix releases for Plasma 5 will be provided after the 5.0 release? Or > > will users simply have to wait fo

Jenkins build is back to stable : plasma-workspace_master_qt5 #529

2014-06-23 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5: Roadmap post 5.0

2014-06-23 Thread Marco Martin
On Monday 23 June 2014, Rohan Garg wrote: > Hi everyone > I was wondering, has there been any discussions on whether or not bug > fix releases for Plasma 5 will be provided after the 5.0 release? Or > will users simply have to wait for the next 5.1 release to get bug > fixes? > > There also doesn'

Plasma 5: Roadmap post 5.0

2014-06-23 Thread Rohan Garg
Hi everyone I was wondering, has there been any discussions on whether or not bug fix releases for Plasma 5 will be provided after the 5.0 release? Or will users simply have to wait for the next 5.1 release to get bug fixes? There also doesn't seem to be any indication of what the time frame will

Review Request 118899: Remove unused dependencies.

2014-06-23 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118899/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 3:21 p.m., Sebastian Kügler wrote: > > I think there's a couple of problems with this approach: > > > > - This slows down startup for everybody, not just those who changed the > > setting. I'm not super-familiar with this, but isn't kcminit for this > > use-case? > > - Chan

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 3:21 p.m., Sebastian Kügler wrote: > > I think there's a couple of problems with this approach: > > > > - This slows down startup for everybody, not just those who changed the > > setting. I'm not super-familiar with this, but isn't kcminit for this > > use-case? > > - Chan

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/ --- (Updated June 23, 2014, 2:19 p.m.) Review request for Plasma. Changes -

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 23, 2014, 1:45 p.m.) Review request for Plasma and Andriy R

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60795 --- I think there's a couple of problems with this approach: - Th

Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/ --- Review request for kde-workspace, Plasma and Marcel Wiesweg. Bugs: 218668

Jenkins build became unstable: plasma-workspace_master_qt5 #528

2014-06-23 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Marco Martin
> On June 23, 2014, 10:34 a.m., Aleix Pol Gonzalez wrote: > > What about bringing this to VdG? They can come up with a more integrated > > new design for the about dialog. > > > > For the moment, I'm good with just changing the picture, but I wouldn't > > like to leave it there. > > Marco Mar

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/ --- (Updated June 23, 2014, 11:33 a.m.) Status -- This change has been m

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60786 --- This review has been submitted with commit 09fc14eda3fa7f378f

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60784 --- Ship it! Ship It! - Sebastian Kügler On June 22, 2014, 8:1

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60783 --- Sorry for hijacking this review, but I think we need the plush

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60781 --- This review has been submitted with commit fec57bdaa2622efbab

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60780 --- This review has been submitted with commit ac5d3d2f916c0a4611

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/ --- (Updated June 23, 2014, 11:03 a.m.) Status -- This change has been m

Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.

2014-06-23 Thread Sebastian Kügler
> On June 22, 2014, 6:58 p.m., Martin Gräßlin wrote: > > I think the suggestion to port ksystemtraycmd to SNI is wrong: we don't > > want applications in the system tray. Removing X11 support from system tray > > is one part of the story for that. We do want to allow apps in the systemtray in

Re: Minutes Monday Plasma hangout

2014-06-23 Thread Aleix Pol
On Mon, Jun 23, 2014 at 12:41 PM, Sebastian Kügler wrote: > Here are the minutes of the mondaily hangout meeting from 23rd of June, > 2014 > > Present: David, Ivan, Jonathan, Marco, Martin G., Sebastian > > > > David: > - General bugfixing > - Plans more general bugfixing > > Ivan > - activity sw

Re: Minutes Monday Plasma hangout

2014-06-23 Thread Bhushan Shah
On Mon, Jun 23, 2014 at 4:11 PM, Sebastian Kügler wrote: > Present: David, Ivan, Jonathan, Marco, Martin G., Sebastian Bhushan - Want review on https://git.reviewboard.kde.org/r/118876/ - Bux fixing and triage -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60778 --- Ship it! Ship It! - David Edmundson On June 23, 2014, 10:4

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60777 --- Ship it! Ship It! - Marco Martin On June 23, 2014, 10:47 a

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/ --- (Updated June 23, 2014, 10:47 a.m.) Review request for Plasma and Aaron J

Minutes Monday Plasma hangout

2014-06-23 Thread Sebastian Kügler
Here are the minutes of the mondaily hangout meeting from 23rd of June, 2014 Present: David, Ivan, Jonathan, Marco, Martin G., Sebastian David: - General bugfixing - Plans more general bugfixing Ivan - activity switcher is faster now - locks up when it's not preloaded (bug!) - focused / curren

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Jonathan Riddell
> On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote: > > Hmm, now we seem to have a strange situation between KDE4 and KF5/PN. > > > > The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) > > with libkonq.so.5 pointing to it. > > > > With this change libkonq has a lower

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Marco Martin
> On June 23, 2014, 10:34 a.m., Aleix Pol Gonzalez wrote: > > What about bringing this to VdG? They can come up with a more integrated > > new design for the about dialog. > > > > For the moment, I'm good with just changing the picture, but I wouldn't > > like to leave it there. > > Marco Mar

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Marco Martin
> On June 23, 2014, 10:34 a.m., Aleix Pol Gonzalez wrote: > > What about bringing this to VdG? They can come up with a more integrated > > new design for the about dialog. > > > > For the moment, I'm good with just changing the picture, but I wouldn't > > like to leave it there. this comes *f

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60772 --- What about bringing this to VdG? They can come up with a more

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60771 --- Ship it! Ship It! - David Edmundson On June 22, 2014, 8:13

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Christoph Feck
> On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote: > > Hmm, now we seem to have a strange situation between KDE4 and KF5/PN. > > > > The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) > > with libkonq.so.5 pointing to it. > > > > With this change libkonq has a lower

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Marco Martin
> On June 23, 2014, 9:59 a.m., David Edmundson wrote: > > plasma/private/dataengine_p.h, line 110 > > > > > > rename this variable; it's not a timestamp (adding since i did already shipit'd it) Good point, updat

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60768 --- plasma/private/dataengine_p.h

Re: Background for login, splash, and lockscreen

2014-06-23 Thread Aleix Pol
On Mon, Jun 23, 2014 at 11:13 AM, Jens wrote: > Martin G: > Who has an image of their naked better half as wallpaper? :) (this is so > going > into my usability report btw "Now you can have a photo of your naked > partner > as wallpaper without it showing in the login!" ;) ) > > But yeah point ta

Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist

2014-06-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118865/#review60767 --- In Plasma Next we're following XDG standard, therefore KDEHOME

Re: Review Request 118896: Fix 2 data races in runnercontext, mention another one.

2014-06-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118896/#review60766 --- Ship it! Ship It! - Marco Martin On June 23, 2014, 7:45 a.

Re: Review Request 118869: Use QElapsedTimer for data engines

2014-06-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60764 --- Ship it! Code-wise the patch makes sense to me. I'm also run

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Sebastian Kügler
> On June 23, 2014, 9 a.m., Eike Hein wrote: > > containments/folder/package/contents/ui/ItemDelegate.qml, line 121 > > > > > > Are you sure you wanted to hard-code pixel values here instead of using > > hidpi s

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Sebastian Kügler
> On June 22, 2014, 11:29 p.m., Mark Gaiser wrote: > > Not a +1 or -1. Just my preference for this. > > - No background (aka, fully transparent) when nothing is selected. > > - Selected items should show the background as in your screenshot. > > > > Just my preference though :) > > Andrew Lake

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Eike Hein
> On June 22, 2014, 11:29 p.m., Mark Gaiser wrote: > > Not a +1 or -1. Just my preference for this. > > - No background (aka, fully transparent) when nothing is selected. > > - Selected items should show the background as in your screenshot. > > > > Just my preference though :) > > Andrew Lake

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Mark Gaiser
> On June 22, 2014, 11:29 p.m., Mark Gaiser wrote: > > Not a +1 or -1. Just my preference for this. > > - No background (aka, fully transparent) when nothing is selected. > > - Selected items should show the background as in your screenshot. > > > > Just my preference though :) > > Andrew Lake

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60757 --- Hmm, now we seem to have a strange situation between KDE4 and

Re: Background for login, splash, and lockscreen

2014-06-23 Thread Jens
Martin G: Who has an image of their naked better half as wallpaper? :) (this is so going into my usability report btw "Now you can have a photo of your naked partner as wallpaper without it showing in the login!" ;) ) But yeah point taken :D On Monday 23 June 2014 11.09.19 Marco Martin wrote: >

Re: Background for login, splash, and lockscreen

2014-06-23 Thread Marco Martin
On Monday 23 June 2014, Martin Gräßlin wrote: > On Monday 23 June 2014 10:55:07 Jens wrote: > > Well the user selected? Oh wouldn't that be cool!? > > no it wouldn't because of privacy and security. A wallpaper can both expose > very private information one wouldn't want on the login screen (t

Re: Re: Background for login, splash, and lockscreen

2014-06-23 Thread Martin Gräßlin
On Monday 23 June 2014 10:55:07 Jens wrote: > Well the user selected? Oh wouldn't that be cool!? no it wouldn't because of privacy and security. A wallpaper can both expose very private information one wouldn't want on the login screen (think of picture of naked girlfriend category) and is a

Re: Review Request 118891: Folder view icon text background

2014-06-23 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/#review60755 --- I'm basically willing to follow the VDG's lead here in the end

Re: Background for login, splash, and lockscreen

2014-06-23 Thread Jens
Well the user selected? Oh wouldn't that be cool!? Ok so say me and Andrew and you (Marco) share a computer (against all geographical difficulties) when I select my user the wallpaper I picked would be displayed with my photo. When we select YOUR user your wallpaper get displayed as backgro

Re: Background for login, splash, and lockscreen

2014-06-23 Thread Marco Martin
On Monday 23 June 2014, Ivan Čukić wrote: > > > blurred wallpaper can even be smaller in resolution (to save on space I > > > guess) since, using gaussian blur removes all detail anyway and the > > > resolution becomes almost meaningless. > > > > Yes that would work and would be a good solution. T

Re: Background for login, splash, and lockscreen

2014-06-23 Thread Jens
Right... Ok so if I pick a wallpaper for my "start activity" that wallpaper should be the wallpaper used. If a user on the other hand have created several activities with different set-ups and deleted the first activity then the last wallpaper edited should be the wallpaper used and the user can

Re: Re: Background for login, splash, and lockscreen

2014-06-23 Thread Martin Gräßlin
On Monday 23 June 2014 10:26:26 Thomas Pfeiffer wrote: > On 23.06.2014 10:16, Ivan Čukić wrote: > >>> blurred wallpaper can even be smaller in resolution (to save on space I > >>> guess) since, using gaussian blur removes all detail anyway and the > >>> resolution becomes almost meaningless. > >>

Re: Background for login, splash, and lockscreen

2014-06-23 Thread Thomas Pfeiffer
On 23.06.2014 10:16, Ivan Čukić wrote: blurred wallpaper can even be smaller in resolution (to save on space I guess) since, using gaussian blur removes all detail anyway and the resolution becomes almost meaningless. Yes that would work and would be a good solution. There The question is *

Re: Background for login, splash, and lockscreen

2014-06-23 Thread Ivan Čukić
> > blurred wallpaper can even be smaller in resolution (to save on space I > > guess) since, using gaussian blur removes all detail anyway and the > > resolution becomes almost meaningless. > > Yes that would work and would be a good solution. There The question is *which* wallpaper. From whic

[kdeplasma-addons/KDE/4.13] applets/fuzzy-clock: initialize m_configUpdated

2014-06-23 Thread Andre Woebbeking
Git commit 6b1736447555e3242b97aca2e7d6ab542a482ea8 by Andre Woebbeking. Committed on 22/06/2014 at 12:58. Pushed by woebbe into branch 'KDE/4.13'. initialize m_configUpdated CCMAIL:plasma-devel@kde.org Could anyone please merge this in master or frameworks? M +1-0applets/fuzzy-clock/f

Review Request 118896: Fix 2 data races in runnercontext, mention another one.

2014-06-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118896/ --- Review request for Plasma and Aaron J. Seigo. Repository: kdelibs Descr

Re: Re: Background for login, splash, and lockscreen

2014-06-23 Thread Martin Gräßlin
On Monday 23 June 2014 08:49:21 Jens Reuterberg wrote: > (Im really really tired - please let me rephrase) > > Ok so you have the default blurred wallpaper for the login, based on the > default wallpaper. > But then you pick a new wallpaper, and instead of having it get blurred > during login (whi