> On June 22, 2014, 11:29 p.m., Mark Gaiser wrote: > > Not a +1 or -1. Just my preference for this. > > - No background (aka, fully transparent) when nothing is selected. > > - Selected items should show the background as in your screenshot. > > > > Just my preference though :) > > Andrew Lake wrote: > This change is for readability when nothing is selected. The normal icon > selection background is unaffected. > > Mark Gaiser wrote: > I know, that's why i said: > "- No background (aka, fully transparent) when nothing is selected." > > as my own preference. + it is consistent between other apps like dolphin > which also doesn't have a default background color for deselected items. > > Eike Hein wrote: > What Andrew was trying to say is that this change is specifically > designed to add a background that is guaranteed to contrast with the text, > behind the text. Not showing it when the item is not selected breaks this > guarantee and makes the change pointless. > > Cf. https://bugs.kde.org/show_bug.cgi?id=335070 for an extended > discussion of this.
Dolphin has a fixed color background, folderview on the desktop wallpaper doesn't. Therefore, you can't compare it to Dolphin. The patch is not about personal preference, but about a contrast problem. Please refer to the bugreport when judging whether or not a patch is useful, "I like it" doesn't really add a lot. IMO, this changes looks "reasonably nice", it's technically correct color use. I'll let Eike handle / decide further. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/#review60739 ----------------------------------------------------------- On June 23, 2014, 12:41 a.m., Andrew Lake wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118891/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 12:41 a.m.) > > > Review request for Plasma. > > > Bugs: 335070 > https://bugs.kde.org/show_bug.cgi?id=335070 > > > Repository: plasma-desktop > > > Description > ------- > > Addresses lack of contrast of folderview containment icon text on certain > backgrounds: Bug 335070 > > The color of the text background is just the complement of the icon label > text with a 0.6 opacity applied. > > > Diffs > ----- > > containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 > containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 > > Diff: https://git.reviewboard.kde.org/r/118891/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Icon text background > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png > > > Thanks, > > Andrew Lake > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
