> On June 23, 2014, 7:16 p.m., Eike Hein wrote: > > This causes the tooltips to no longer be uniform in size, which causes > > extra visual busyness when moving between tasks. Tooltip resize performance > > also isn't stellar right now, and size changes are especially deadly for > > right-aligned tooltips (i.e. vertical panel on the right screen edge), > > causing odd dancing. So conceptually it's a -1 for me. Additionally on the > > first screenshot the left/right margins also aren't uniform for icon and > > text label.
True, didn't test with vertical panel :/ What a pity. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118908/#review60837 ----------------------------------------------------------- On June 23, 2014, 6:39 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118908/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 6:39 p.m.) > > > Review request for Plasma and Eike Hein. > > > Repository: plasma-desktop > > > Description > ------- > > Now that we can know the exact geometry of the window thumbnail the tooltip > is adjusted to respect that. > > > Diffs > ----- > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml ca5f95b > > Diff: https://git.reviewboard.kde.org/r/118908/diff/ > > > Testing > ------- > > Tested with single window, grouped window as well as minimized window (icon). > Looks fine although there still is excess padding left and right of the > thumbnail I don't know where that comes. Needs a bit of spacing adjustments > as well. > > > File Attachments > ---------------- > > Narrow window > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/7773a10d-7ee9-4a06-b5b4-bd03b7ce8566__taskmanagertooltip.png > Wide window > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/8e29f459-af59-43c1-b171-8b7aacd237af__taskmanagertooltip1.png > Grouped > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/f1df0096-271c-4229-8466-8374ef56492a__taskmanagertooltip2.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
