----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/#review60832 -----------------------------------------------------------
Ship it! Thanks for addressing those issues. I'd say let's commit it now. I'm still not sure that it might not be too heavy visually, but to find out we need broader feedback I think. So let's put it in and monitor responses :). - Eike Hein On June 23, 2014, 2:19 p.m., Andrew Lake wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118891/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 2:19 p.m.) > > > Review request for Plasma. > > > Bugs: 335070 > https://bugs.kde.org/show_bug.cgi?id=335070 > > > Repository: plasma-desktop > > > Description > ------- > > Addresses lack of contrast of folderview containment icon text on certain > backgrounds: Bug 335070 > > The color of the text background is just the complement of the icon label > text with a 0.6 opacity applied. > > > Diffs > ----- > > containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 > containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 > > Diff: https://git.reviewboard.kde.org/r/118891/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > with latest changes showing it with selection background > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png > > > Thanks, > > Andrew Lake > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
