----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/#review60755 -----------------------------------------------------------
I'm basically willing to follow the VDG's lead here in the end, although I think this approach has some problems: - It's a fairly heavy deco for the containment case, which does make it feel a lot like a selection deco. This is reinforced by the fact that other file item delegates in the system (Dolphin, KFileDialog) behave similarly on selection. - I can't quite make my mind up on whether it's a good thing or a bad thing that the deco on narrow single-line text items extends over the entire line width instead of bounding to the text. It's different from Dolphin/KFileDialog behavior, though. containments/folder/package/contents/ui/ItemDelegate.qml <https://git.reviewboard.kde.org/r/118891/#comment42354> Are you sure you wanted to hard-code pixel values here instead of using hidpi scaling-aware margins? units.smallSpacing is effectively 2px right now at 'standard DPI'. containments/folder/package/contents/ui/ItemDelegate.qml <https://git.reviewboard.kde.org/r/118891/#comment42355> This causes a subtle brightly-colored rectangle in popups from the containment Folder View and in the widget case which I think looks fairly awkward to me. The dialog and widget backgrounds are designed to host theme.textColor already contrast-wise, so I think it'd be better to just not show this rectangle there. - Eike Hein On June 23, 2014, 12:41 a.m., Andrew Lake wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118891/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 12:41 a.m.) > > > Review request for Plasma. > > > Bugs: 335070 > https://bugs.kde.org/show_bug.cgi?id=335070 > > > Repository: plasma-desktop > > > Description > ------- > > Addresses lack of contrast of folderview containment icon text on certain > backgrounds: Bug 335070 > > The color of the text background is just the complement of the icon label > text with a 0.6 opacity applied. > > > Diffs > ----- > > containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 > containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 > > Diff: https://git.reviewboard.kde.org/r/118891/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Icon text background > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png > > > Thanks, > > Andrew Lake > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
