[GitHub] [logging-log4j-audit] rgoers commented on issue #18: LOG4J2-2578

2019-04-03 Thread GitBox
rgoers commented on issue #18: LOG4J2-2578 URL: https://github.com/apache/logging-log4j-audit/pull/18#issuecomment-479701143 This PR looks good to me. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [logging-log4j-audit] jvz edited a comment on issue #14: Missing curly brackets at value gitUserName annotation

2019-04-03 Thread GitBox
jvz edited a comment on issue #14: Missing curly brackets at value gitUserName annotation URL: https://github.com/apache/logging-log4j-audit/pull/14#issuecomment-463715146 Jira: https://issues.apache.org/jira/browse/LOG4J2. Use component Log4j-Audit Thanks! ---

[GitHub] [logging-log4j-audit] rgoers merged pull request #14: LOG4J2-2582 - Missing curly brackets at value gitUserName annotation

2019-04-03 Thread GitBox
rgoers merged pull request #14: LOG4J2-2582 - Missing curly brackets at value gitUserName annotation URL: https://github.com/apache/logging-log4j-audit/pull/14 This is an automated message from the Apache Git Service. To res

[GitHub] [logging-log4j-audit] rgoers merged pull request #17: LOG4J2-2580

2019-04-03 Thread GitBox
rgoers merged pull request #17: LOG4J2-2580 URL: https://github.com/apache/logging-log4j-audit/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [logging-log4j-audit] andrei-ivanov opened a new pull request #19: Fix build

2019-04-04 Thread GitBox
andrei-ivanov opened a new pull request #19: Fix build URL: https://github.com/apache/logging-log4j-audit/pull/19 Upgrading to parent 21 broke the build for me This is an automated message from the Apache Git Service. To respo

[GitHub] [logging-log4j2] fluffy88 opened a new pull request #266: LOG4J2-1103 remove used nodes when child is of list type

2019-04-04 Thread GitBox
fluffy88 opened a new pull request #266: LOG4J2-1103 remove used nodes when child is of list type URL: https://github.com/apache/logging-log4j2/pull/266 Fix a bug that caused "ERROR appender Failover has no parameter that matches element Failovers" to be printed when using a correctly conf

[GitHub] [logging-log4j2] abysas commented on issue #223: [LOG4J2-2476] missing classes for 1.2 compatibility

2019-04-11 Thread GitBox
abysas commented on issue #223: [LOG4J2-2476] missing classes for 1.2 compatibility URL: https://github.com/apache/logging-log4j2/pull/223#issuecomment-482317370 @rgoers, thank you for confirming about the compatibility mismatch. I was so happy seeing the v2.11.2 release notes about added

[GitHub] [logging-log4j2] abysas edited a comment on issue #223: [LOG4J2-2476] missing classes for 1.2 compatibility

2019-04-11 Thread GitBox
abysas edited a comment on issue #223: [LOG4J2-2476] missing classes for 1.2 compatibility URL: https://github.com/apache/logging-log4j2/pull/223#issuecomment-482317370 @rgoers, thank you for confirming about the compatibility mismatch. I was so happy seeing the v2.11.2 release notes about

[GitHub] [logging-log4j2] abysas edited a comment on issue #223: [LOG4J2-2476] missing classes for 1.2 compatibility

2019-04-11 Thread GitBox
abysas edited a comment on issue #223: [LOG4J2-2476] missing classes for 1.2 compatibility URL: https://github.com/apache/logging-log4j2/pull/223#issuecomment-482317370 @rgoers, thank you for confirming about the compatibility mismatch. I was so happy seeing the v2.11.2 release notes about

[GitHub] [logging-log4j2] abysas edited a comment on issue #223: [LOG4J2-2476] missing classes for 1.2 compatibility

2019-04-11 Thread GitBox
abysas edited a comment on issue #223: [LOG4J2-2476] missing classes for 1.2 compatibility URL: https://github.com/apache/logging-log4j2/pull/223#issuecomment-482317370 @rgoers, thank you for confirming about the compatibility mismatch. I was so happy seeing the v2.11.2 release notes about

[GitHub] [logging-log4j2] garydgregory commented on issue #264: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (2.x branch)

2019-04-16 Thread GitBox
garydgregory commented on issue #264: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (2.x branch) URL: https://github.com/apache/logging-log4j2/pull/264#issuecomment-483769713 May you please resolve conflicts with HEAD? --

[GitHub] [logging-log4j2] garydgregory merged pull request #265: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (master branch)

2019-04-16 Thread GitBox
garydgregory merged pull request #265: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (master branch) URL: https://github.com/apache/logging-log4j2/pull/265 This is an automated message from the Apache Git Service. T

[GitHub] [logging-log4j2] pferrot commented on issue #264: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (2.x branch)

2019-04-23 Thread GitBox
pferrot commented on issue #264: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (2.x branch) URL: https://github.com/apache/logging-log4j2/pull/264#issuecomment-485767708 > May you please resolve conflicts with HEAD? Done.

[GitHub] [logging-log4j2] garydgregory merged pull request #264: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (2.x branch)

2019-04-23 Thread GitBox
garydgregory merged pull request #264: [LOG4J2-2337] Allow custom end-of-line with JsonLayout (2.x branch) URL: https://github.com/apache/logging-log4j2/pull/264 This is an automated message from the Apache Git Service. To r

[GitHub] [logging-log4j-audit] andrei-ivanov commented on issue #19: Fix build

2019-04-29 Thread GitBox
andrei-ivanov commented on issue #19: Fix build URL: https://github.com/apache/logging-log4j-audit/pull/19#issuecomment-487562464 is this ok to merge? This is an automated message from the Apache Git Service. To respond to th

[GitHub] [logging-log4j-audit] rgoers commented on issue #19: Fix build

2019-04-29 Thread GitBox
rgoers commented on issue #19: Fix build URL: https://github.com/apache/logging-log4j-audit/pull/19#issuecomment-487632579 Andrei, in case you aren't aware the Logging Services projects practice CTR (commit then review). So you don't require our permission to commit. That said, if you wan

[GitHub] [logging-log4j2] carterkozak opened a new pull request #267: LOG4J2-2598: GzCompressAction supports configurable compression levels

2019-04-30 Thread GitBox
carterkozak opened a new pull request #267: LOG4J2-2598: GzCompressAction supports configurable compression levels URL: https://github.com/apache/logging-log4j2/pull/267 Updated the implementation to use the BUF_SIZE constant for the GZIPOutputStream output buffer as well. -

[GitHub] [logging-log4j2] carterkozak merged pull request #267: LOG4J2-2598: GzCompressAction supports configurable compression levels

2019-04-30 Thread GitBox
carterkozak merged pull request #267: LOG4J2-2598: GzCompressAction supports configurable compression levels URL: https://github.com/apache/logging-log4j2/pull/267 This is an automated message from the Apache Git Service. To

[GitHub] [logging-log4j2] remkop commented on issue #267: LOG4J2-2598: GzCompressAction supports configurable compression levels

2019-04-30 Thread GitBox
remkop commented on issue #267: LOG4J2-2598: GzCompressAction supports configurable compression levels URL: https://github.com/apache/logging-log4j2/pull/267#issuecomment-488151880 Nice! Thanks for carefully preserving backwards compatibility. --

[GitHub] [logging-log4j2] carterkozak commented on issue #267: LOG4J2-2598: GzCompressAction supports configurable compression levels

2019-04-30 Thread GitBox
carterkozak commented on issue #267: LOG4J2-2598: GzCompressAction supports configurable compression levels URL: https://github.com/apache/logging-log4j2/pull/267#issuecomment-488169903 Thanks for looking over this @remkop :-) ---

[GitHub] [logging-log4php] jvz merged pull request #16: Typo fix

2019-05-01 Thread GitBox
jvz merged pull request #16: Typo fix URL: https://github.com/apache/logging-log4php/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [logging-log4j-audit] andrei-ivanov commented on issue #19: Fix build

2019-05-02 Thread GitBox
andrei-ivanov commented on issue #19: Fix build URL: https://github.com/apache/logging-log4j-audit/pull/19#issuecomment-488820234 Hmm, I don't see a way to merge it here, maybe I'm missing some permissions? This is an automat

[GitHub] [logging-log4j-audit] jvz commented on issue #19: Fix build

2019-05-02 Thread GitBox
jvz commented on issue #19: Fix build URL: https://github.com/apache/logging-log4j-audit/pull/19#issuecomment-488822733 @andrei-ivanov see https://gitbox.apache.org/setup/ to ensure you're configured correctly This is an aut

[GitHub] [logging-log4j-audit] andrei-ivanov commented on issue #19: Fix build

2019-05-02 Thread GitBox
andrei-ivanov commented on issue #19: Fix build URL: https://github.com/apache/logging-log4j-audit/pull/19#issuecomment-488835581 I've just done the setup, but I still don't see a merge button here. Should I have? 🙂 This is

[GitHub] [logging-log4j-audit] rgoers commented on issue #19: Fix build

2019-05-02 Thread GitBox
rgoers commented on issue #19: Fix build URL: https://github.com/apache/logging-log4j-audit/pull/19#issuecomment-488845829 Does GitHub say you are a member? You can also connect and merge from gitbox but personally I prefer GitHub’s UI. Ralph > On May 2, 2019, at 2:17

[GitHub] [logging-log4j-audit] andrei-ivanov commented on issue #19: Fix build

2019-05-03 Thread GitBox
andrei-ivanov commented on issue #19: Fix build URL: https://github.com/apache/logging-log4j-audit/pull/19#issuecomment-48812 Ah, it seems that GitHub just needed some time to process the GitBox setup as I've received some mails half an hour later informing me of the

[GitHub] [logging-log4j-audit] andrei-ivanov merged pull request #19: Fix build

2019-05-03 Thread GitBox
andrei-ivanov merged pull request #19: Fix build URL: https://github.com/apache/logging-log4j-audit/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [logging-log4j2] hupfdule commented on issue #224: [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender

2019-05-07 Thread GitBox
hupfdule commented on issue #224: [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender URL: https://github.com/apache/logging-log4j2/pull/224#issuecomment-489990999 Why is there still no comment on this PR? It fixes the problem described in [LOG4J-2403](https://iss

[GitHub] [logging-log4j2] rgoers commented on issue #224: [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender

2019-05-07 Thread GitBox
rgoers commented on issue #224: [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender URL: https://github.com/apache/logging-log4j2/pull/224#issuecomment-490052193 Because we are all volunteers and do this in our spare time. It will get looked at. Ralph > O

[GitHub] [logging-log4j2] garydgregory commented on issue #224: [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender

2019-05-07 Thread GitBox
garydgregory commented on issue #224: [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender URL: https://github.com/apache/logging-log4j2/pull/224#issuecomment-490079287 I like the idea but I cannot take the time to review ATM. Thank you for your contribution :-)

[GitHub] [logging-log4net] Shazwazza commented on issue #40: This fixes the Mutex name in the RollingFileAppender

2019-05-07 Thread GitBox
Shazwazza commented on issue #40: This fixes the Mutex name in the RollingFileAppender URL: https://github.com/apache/logging-log4net/pull/40#issuecomment-490083293 Hi @dpsenner , I've pushed some updates * Rebased on the develop branch and it's up to date * Centralized mutex lock

[GitHub] [logging-log4j-audit] andrei-ivanov opened a new pull request #20: LOG4J2-2579

2019-05-10 Thread GitBox
andrei-ivanov opened a new pull request #20: LOG4J2-2579 URL: https://github.com/apache/logging-log4j-audit/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j-audit] andrei-ivanov commented on a change in pull request #20: LOG4J2-2579

2019-05-10 Thread GitBox
andrei-ivanov commented on a change in pull request #20: LOG4J2-2579 URL: https://github.com/apache/logging-log4j-audit/pull/20#discussion_r283069319 ## File path: log4j-audit/log4j-audit-api/src/test/java/org/apache/logging/log4j/audit/LogoutTest.java ## @@ -16,27 +16,27

[GitHub] [logging-log4j-audit] andrei-ivanov commented on a change in pull request #20: LOG4J2-2579

2019-05-10 Thread GitBox
andrei-ivanov commented on a change in pull request #20: LOG4J2-2579 URL: https://github.com/apache/logging-log4j-audit/pull/20#discussion_r283069319 ## File path: log4j-audit/log4j-audit-api/src/test/java/org/apache/logging/log4j/audit/LogoutTest.java ## @@ -16,27 +16,27

[GitHub] [logging-log4j-audit] andrei-ivanov commented on a change in pull request #20: LOG4J2-2579

2019-05-10 Thread GitBox
andrei-ivanov commented on a change in pull request #20: LOG4J2-2579 URL: https://github.com/apache/logging-log4j-audit/pull/20#discussion_r283069393 ## File path: log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/AbstractEventLogger.java ## @@ -91,1

[GitHub] [logging-log4j2] rgoers merged pull request #266: LOG4J2-1103 remove used nodes when child is of list type

2019-05-12 Thread GitBox
rgoers merged pull request #266: LOG4J2-1103 remove used nodes when child is of list type URL: https://github.com/apache/logging-log4j2/pull/266 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [logging-log4j2] rgoers closed pull request #252: Fixed message length with TLS and Syslog // fixes LOG4J2-2532

2019-05-12 Thread GitBox
rgoers closed pull request #252: Fixed message length with TLS and Syslog // fixes LOG4J2-2532 URL: https://github.com/apache/logging-log4j2/pull/252 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [logging-log4j2] rgoers commented on issue #252: Fixed message length with TLS and Syslog // fixes LOG4J2-2532

2019-05-12 Thread GitBox
rgoers commented on issue #252: Fixed message length with TLS and Syslog // fixes LOG4J2-2532 URL: https://github.com/apache/logging-log4j2/pull/252#issuecomment-491680441 Closing this PR since the TLS support for RFC 5424 Syslog records is covered in https://tools.ietf.org/html/rfc5425 wh

[GitHub] [logging-log4j2] rgoers merged pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up

2019-05-12 Thread GitBox
rgoers merged pull request #260: [LOG4J2-2561] JEP223 version detection fix for JDK 9 and up URL: https://github.com/apache/logging-log4j2/pull/260 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [logging-log4j2] carterkozak opened a new pull request #268: LOG4J2-2564: PatternParser chooses newInstance methods with known parameters

2019-05-13 Thread GitBox
carterkozak opened a new pull request #268: LOG4J2-2564: PatternParser chooses newInstance methods with known parameters URL: https://github.com/apache/logging-log4j2/pull/268 Fixes MapPatternConverter, which contains two newInstance methods where only one can be created using the Patter

[GitHub] [logging-log4j2] carterkozak closed pull request #268: LOG4J2-2564: PatternParser chooses newInstance methods with known parameters

2019-05-14 Thread GitBox
carterkozak closed pull request #268: LOG4J2-2564: PatternParser chooses newInstance methods with known parameters URL: https://github.com/apache/logging-log4j2/pull/268 This is an automated message from the Apache Git Servi

[GitHub] [logging-log4j2] carterkozak opened a new pull request #269: LOG4J2-2609: Implement "Synchronous" AsyncQueueFullPolicy

2019-05-20 Thread GitBox
carterkozak opened a new pull request #269: LOG4J2-2609: Implement "Synchronous" AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269 AsyncQueueFullPolicy short values are case insensitive This is an au

[GitHub] [logging-log4j2] garydgregory commented on issue #269: LOG4J2-2609: Implement "Synchronous" AsyncQueueFullPolicy

2019-05-20 Thread GitBox
garydgregory commented on issue #269: LOG4J2-2609: Implement "Synchronous" AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494044429 It key IMO to also have documentation that explains the new feature and how it compares to other polices. -

[GitHub] [logging-log4j2] carterkozak commented on issue #269: LOG4J2-2609: Implement "Synchronous" AsyncQueueFullPolicy

2019-05-20 Thread GitBox
carterkozak commented on issue #269: LOG4J2-2609: Implement "Synchronous" AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494053590 Ack, I will add docs to this PR later today This is

[GitHub] [logging-log4j2] carterkozak opened a new pull request #270: Log4j2-2609 to release-2.x

2019-05-20 Thread GitBox
carterkozak opened a new pull request #270: Log4j2-2609 to release-2.x URL: https://github.com/apache/logging-log4j2/pull/270 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [logging-log4j2] JCgH4164838Gh792C124B5 opened a new pull request #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-20 Thread GitBox
JCgH4164838Gh792C124B5 opened a new pull request #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271 Proposed fix for LOG4J2-2610 rollover issue: - Fix for Windows Filesystem Tunneling issue, rapid rollover issue. - Added FileUtils

[GitHub] [logging-log4j2] JCgH4164838Gh792C124B5 commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-20 Thread GitBox
JCgH4164838Gh792C124B5 commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-494133519 Hello Apache Log4j2 Team. Hopefully the code in this PR is formatted appropriately, but let me know if different

[GitHub] [logging-log4j2] JCgH4164838Gh792C124B5 edited a comment on issue #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-20 Thread GitBox
JCgH4164838Gh792C124B5 edited a comment on issue #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-494133519 Hello Apache Log4j2 Team. Hopefully the code in this PR is formatted appropriately, but let me know if di

[GitHub] [logging-log4j2] rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-20 Thread GitBox
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-494162191 No offense, but this PR is just another example of why I hate Windows.

[GitHub] [logging-log4j2] rgoers edited a comment on issue #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-20 Thread GitBox
rgoers edited a comment on issue #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-494162191 No offense, but this PR is just another example of why I hate Windows. These "problems" just don't exist on an OS with a real fi

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-20 Thread GitBox
garydgregory commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#discussion_r285790839 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManage

[GitHub] [logging-log4j2] carterkozak commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
carterkozak commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494204519 I may not end up committing the synchronous policy because it's not terribly helpful outside of testing. If we (careful

[GitHub] [logging-log4j2] remkop commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
remkop commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494206750 I agree that the SYNCHRONOUS policy won't be very useful in reality. (A few years ago when this was the default policy we re

[GitHub] [logging-log4j2] remkop edited a comment on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
remkop edited a comment on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494206750 I agree that the SYNCHRONOUS policy won't be very useful in reality. (A few years ago when this was the default polic

[GitHub] [logging-log4j2] remkop edited a comment on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
remkop edited a comment on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494206750 I agree that the SYNCHRONOUS policy won't be very useful in practice. (A few years ago when this was the default poli

[GitHub] [logging-log4j2] garydgregory commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
garydgregory commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494211926 Why not make it configurable so users and pick and configure each one? --

[GitHub] [logging-log4j2] remkop commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
remkop commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494212615 @garydgregory It already is configurable: https://github.com/apache/logging-log4j2/blob/master/log4j-core/src/main/java/org/

[GitHub] [logging-log4j2] remkop commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
remkop commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494212881 The question is: what is the default to use in Log4j that gives the best balance between performance and safety. --

[GitHub] [logging-log4j2] garydgregory commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
garydgregory commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494214751 I see, but does it make sense to add the missing ones? ---

[GitHub] [logging-log4j2] remkop commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
remkop commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494222808 Probably yes, but the [documentation|https://logging.apache.org/log4j/2.x/manual/async.html#SysPropsAllAsync] would need to

[GitHub] [logging-log4j2] remkop edited a comment on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
remkop edited a comment on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494222808 Probably yes, but the [documentation](https://logging.apache.org/log4j/2.x/manual/async.html#SysPropsAllAsync) would

[GitHub] [logging-log4j2] carterkozak commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-20 Thread GitBox
carterkozak commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494225317 @remkop I've tested with several `WaitStrategy` implementations and haven't observed a great deal of difference between

[GitHub] [logging-log4j2] carterkozak closed pull request #270: Log4j2-2609 to release-2.x

2019-05-21 Thread GitBox
carterkozak closed pull request #270: Log4j2-2609 to release-2.x URL: https://github.com/apache/logging-log4j2/pull/270 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [logging-log4j2] carterkozak opened a new pull request #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive

2019-05-21 Thread GitBox
carterkozak opened a new pull request #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive URL: https://github.com/apache/logging-log4j2/pull/272 This is an automated message from the Apach

[GitHub] [logging-log4j2] carterkozak opened a new pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-21 Thread GitBox
carterkozak opened a new pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273 This change applies synchronization to AsyncLoggerDisruptor blocking enqueue operations when the asynchronous l

[GitHub] [logging-log4j2] carterkozak closed pull request #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-21 Thread GitBox
carterkozak closed pull request #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [logging-log4j2] carterkozak commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy

2019-05-21 Thread GitBox
carterkozak commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494594391 Closing this PR as I've broken it into a few pieces: 1. Initial benchmarks have already merged: https://github.com/a

[GitHub] [logging-log4j2] carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-21 Thread GitBox
carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-494594969 @remkop I can't seem to tag you as a reviewer. I'd appreciate your feedback at your convenience :

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-21 Thread GitBox
carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286261767 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/as

[GitHub] [logging-log4j2] JCgH4164838Gh792C124B5 commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-21 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#discussion_r286277223 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/Rolling

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-21 Thread GitBox
carterkozak commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#discussion_r286278168 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManager

[GitHub] [logging-log4j2] JCgH4164838Gh792C124B5 commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-21 Thread GitBox
JCgH4164838Gh792C124B5 commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-494614475 Hello @rgoers. No offense taken. :smile: It was a bit surprising to encounter the "tunneling" filesystem

[GitHub] [logging-log4j2] remkop commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-21 Thread GitBox
remkop commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-494619470 I’ll take a look. This is an automate

[GitHub] [logging-log4j2] remkop commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive

2019-05-21 Thread GitBox
remkop commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive URL: https://github.com/apache/logging-log4j2/pull/272#issuecomment-494632334 I reviewed this PR to make configuration case-insensitive and improve the javadoc by adding a warn

[GitHub] [logging-log4j2] remkop commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-21 Thread GitBox
remkop commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-494636520 It still seems strange to me that the application (Log4j in this case) needs to do synchronization whe

[GitHub] [logging-log4j2] carterkozak commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive

2019-05-21 Thread GitBox
carterkozak commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive URL: https://github.com/apache/logging-log4j2/pull/272#issuecomment-494636943 Thanks Remko. I like the sound of `BYPASS_QUEUE` and agree that `SYNCHRONOUS` makes `ENQUEUE`

[GitHub] [logging-log4j2] carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-21 Thread GitBox
carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-494640721 > Can we experiment a bit before moving ahead? @carterkozak You reported this happened in your

[GitHub] [logging-log4j2] carterkozak merged pull request #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive

2019-05-21 Thread GitBox
carterkozak merged pull request #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive URL: https://github.com/apache/logging-log4j2/pull/272 This is an automated message from the Apache Git

[GitHub] [logging-log4j2] remkop commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive

2019-05-21 Thread GitBox
remkop commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive URL: https://github.com/apache/logging-log4j2/pull/272#issuecomment-494665627 Maybe this name change is something to do in log4j 3.0. -

[GitHub] [logging-log4j2] garydgregory commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive

2019-05-22 Thread GitBox
garydgregory commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive URL: https://github.com/apache/logging-log4j2/pull/272#issuecomment-494728510 You can add the new name and deprecate the old one, no?

[GitHub] [logging-log4j2] carterkozak commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive

2019-05-22 Thread GitBox
carterkozak commented on issue #272: LOG4J2-2611: AsyncQueueFullPolicy configuration short values are case insensitive URL: https://github.com/apache/logging-log4j2/pull/272#issuecomment-494750958 That is correct. This is an

[GitHub] [logging-log4j2] carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-494816763 The WaitStrategy appears to be designed to awaken all producer threads each time an event from th

[GitHub] [logging-log4net] mirec75 opened a new pull request #48: Fixes LOG4NET-587 Mutex ~ UnauthorizedAccessException Access to the path is denied

2019-05-22 Thread GitBox
mirec75 opened a new pull request #48: Fixes LOG4NET-587 Mutex ~ UnauthorizedAccessException Access to the path is denied URL: https://github.com/apache/logging-log4net/pull/48 This pull request fixes [LOG4NET-587](https://issues.apache.org/jira/browse/LOG4NET-587) issue: Mutex ~ Unauthor

[GitHub] [logging-log4j2] remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286747384 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/A

[GitHub] [logging-log4j2] remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286747742 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/A

[GitHub] [logging-log4j2] remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286747814 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/A

[GitHub] [logging-log4j2] remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286747891 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/A

[GitHub] [logging-log4j2] remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
remkop commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286750131 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/D

[GitHub] [logging-log4j2] remkop commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
remkop commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-495041705 I did an initial review, but I haven't looked at what the trade-offs are for the use of Semaphor versu

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286754343 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/as

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286754419 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/as

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r286754726 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/as

[GitHub] [logging-log4j2] carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load

2019-05-22 Thread GitBox
carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-495044519 Thank you for the review, no rush on the remaining pieces. I don't plan to merge any of this unti

[GitHub] [logging-log4j2] JCgH4164838Gh792C124B5 commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-22 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#discussion_r286757558 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/Rolling

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-22 Thread GitBox
carterkozak commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#discussion_r286761819 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManager

[GitHub] [logging-log4j2] JCgH4164838Gh792C124B5 commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-22 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#discussion_r286768619 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/Rolling

[GitHub] [logging-log4j-audit] rgoers commented on a change in pull request #20: LOG4J2-2579

2019-05-22 Thread GitBox
rgoers commented on a change in pull request #20: LOG4J2-2579 URL: https://github.com/apache/logging-log4j-audit/pull/20#discussion_r283151298 ## File path: log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/LogEventFactory.java ## @@ -28,12 +28,7 @@

[GitHub] [logging-log4j-audit] rgoers commented on a change in pull request #20: LOG4J2-2579

2019-05-22 Thread GitBox
rgoers commented on a change in pull request #20: LOG4J2-2579 URL: https://github.com/apache/logging-log4j-audit/pull/20#discussion_r283151380 ## File path: log4j-audit/log4j-audit-api/src/test/java/org/apache/logging/log4j/audit/AuditLoggerTest.java ## @@ -38,9 +38,7 @@

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue:

2019-05-23 Thread GitBox
carterkozak commented on a change in pull request #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#discussion_r286990538 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManager

[GitHub] [logging-log4net] mirec75 opened a new pull request #49: Fixes LOG4NET-630 Log4Net missing Timestamp etc. in internal LogLog

2019-05-23 Thread GitBox
mirec75 opened a new pull request #49: Fixes LOG4NET-630 Log4Net missing Timestamp etc. in internal LogLog URL: https://github.com/apache/logging-log4net/pull/49 The Issue [LOG4NET-630](https://issues.apache.org/jira/browse/LOG4NET-630) is fixed with this pull request. Now you can c

<    15   16   17   18   19   20   21   22   23   24   >