carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async 
logging performance under heavy load
URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-494816763
 
 
   The WaitStrategy appears to be designed to awaken all producer threads each 
time an event from the queue is consumed. With more blocked threads, there will 
be more wakeups and CPU churn.
   
   The more I think about this, the more I like the idea of a semaphore with 
configurable permits (default = 1 based on benchmarks) over my current mutex 
approach. That will allow us to optimize throughput in cases that I haven't 
fully considered while reducing the risk of N spinning threads. Otherwise 
there's not much reason to allow WaitStrategy to be configured at all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to