JCgH4164838Gh792C124B5 edited a comment on issue #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-494133519 Hello Apache Log4j2 Team. Hopefully the code in this PR is formatted appropriately, but let me know if different formatting would be preferred. The same goes for the code logic, as the committers may want an alternative solution to what been proposed. **Note**: The project Core module build succeeded ([INFO] Apache Log4j Core .................................. SUCCESS [ 41.587 s]) so the changes in this PR (only in Core) do appear to pass regression. The Travis CI job failed near the end ([INFO] Log4j Sample Configuration Service ................. FAILURE [ 7.522 s]). The first error in the CI job build log was: "[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project log4j-spring-cloud-config-sample-server: Fatal error compiling: invalid flag: -parameters -> [Help 1]". Maybe there's something breaking in the sample module pom or the CI build job somewhere ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
