carterkozak commented on issue #269: LOG4J2-2609: Implement Synchronous AsyncQueueFullPolicy URL: https://github.com/apache/logging-log4j2/pull/269#issuecomment-494204519 I may not end up committing the synchronous policy because it's not terribly helpful outside of testing. If we (carefully) synchronize around the enqueue operation we can get more throughput, avoid poorly ordered events, and avoid creating thread-local buffers outside of the background thread: ``` Benchmark (queueFullPolicy) Mode Cnt Score Error Units ConcurrentAsyncLoggerToFileBenchmark.concurrentLoggingThreads ENQUEUE thrpt 3 1302070.388 ± 713643.057 ops/s ConcurrentAsyncLoggerToFileBenchmark.concurrentLoggingThreads SYNCHRONOUS thrpt 3 1151360.276 ± 99047.131 ops/s ConcurrentAsyncLoggerToFileBenchmark.singleLoggingThread ENQUEUE thrpt 3 1330328.259 ± 749542.377 ops/s ConcurrentAsyncLoggerToFileBenchmark.singleLoggingThread SYNCHRONOUS thrpt 3 1381320.895 ± 507036.686 ops/s ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
