remkop commented on issue #273: LOG4J2-2606: Substantially improve async 
logging performance under heavy load
URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-494636520
 
 
   It still seems strange to me that the application (Log4j in this case) needs 
to do synchronization when using the Disruptor.
   
   I'm also surprised that all the WaitStrategies were reported to show the 
same behaviour when the ringbuffer is full and under load. The proposed change 
(synchronizing on a mutex object) seems to do the same as the 
[BlockingWaitStrategy](https://github.com/LMAX-Exchange/disruptor/blob/master/src/main/java/com/lmax/disruptor/BlockingWaitStrategy.java)
 provided by the Disruptor. So I would expect at least the BlockingWaitStrategy 
to show some improvement...
   
   Can we experiment a bit before moving ahead? 
   @carterkozak You reported this happened in your production environment. Can 
I ask how you've dealt with that? Is your organization waiting for a quick 
Log4j fix, or do you have some other interim solution?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to