Re: [PATCH net-next] mlx4: make sure to always set the port type

2020-09-06 Thread Leon Romanovsky
On Mon, Sep 07, 2020 at 08:21:35AM +0200, Jiri Pirko wrote: > Sun, Sep 06, 2020 at 06:33:05PM CEST, k...@kernel.org wrote: > >On Sun, 6 Sep 2020 10:27:59 +0300 Leon Romanovsky wrote: > >> On Fri, Sep 04, 2020 at 01:06:21PM -0700, Jakub Kicinski wrote: > >> > Even tho mlx4_core registers the devlink

[PATCH v2] net: wireless: wlcore: fix support for IGTK key

2020-09-06 Thread Mauro Carvalho Chehab
Changeset 2b7aadd3b9e1 ("wlcore: Adding suppoprt for IGTK key in wlcore driver") added support for AEC CMAC cipher suite. However, this only works with the very newest firmware version (8.9.0.0.83). Such firmware weren't even pushed to linux-firmware git tree yet: https://git.ti.com/cgit/

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-09-06 Thread Adrian Hunter
On 4/09/20 8:43 am, Ian Rogers wrote: > On Tue, Aug 4, 2020 at 8:50 AM Ian Rogers wrote: >> On Tue, Aug 4, 2020 at 7:49 AM Adrian Hunter wrote: >>> On 4/08/20 4:33 pm, Ian Rogers wrote: On Tue, Aug 4, 2020 at 3:08 AM Adrian Hunter wrote: > On 28/07/20 11:57 am, Ian Rogers wrote: >

[PATCH net] can: j1939: j1939_sk_bind(): return failure if netdev is down

2020-09-06 Thread Zhang Changzhong
When a netdev down event occurs after a successful call to j1939_sk_bind(), j1939_netdev_notify() can handle it correctly. But if the netdev already in down state before calling j1939_sk_bind(), j1939_sk_release() will stay in wait_event_interruptible() blocked forever. Because in this case, j1939

Re: [PATCH net-next] mlx4: make sure to always set the port type

2020-09-06 Thread Jiri Pirko
Sun, Sep 06, 2020 at 06:33:05PM CEST, k...@kernel.org wrote: >On Sun, 6 Sep 2020 10:27:59 +0300 Leon Romanovsky wrote: >> On Fri, Sep 04, 2020 at 01:06:21PM -0700, Jakub Kicinski wrote: >> > Even tho mlx4_core registers the devlink ports, it's mlx4_en >> > and mlx4_ib which set their type. In situa

[net-next v2] tipc: fix a deadlock when flushing scheduled work

2020-09-06 Thread Hoang Huu Le
In the commit fdeba99b1e58 ("tipc: fix use-after-free in tipc_bcast_get_mode"), we're trying to make sure the tipc_net_finalize_work work item finished if it enqueued. But calling flush_scheduled_work() is not just affecting above work item but either any scheduled work. This has turned out to be o

Re: [PATCH v2] net: dsa: microchip: look for phy-mode in port nodes

2020-09-06 Thread Helmut Grohne
Hi Andrew, On Fri, Sep 04, 2020 at 03:52:55PM +0200, Andrew Lunn wrote: > > + dev_warn(dev->dev, > > +"Using legacy switch \"phy-mode\" missing on > > port %d node. Please update your device tree.\n", This is inside ksz8795_port_setup. > That messag

Re: [PATCH v5 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-09-06 Thread Kurt Kanzenbach
On Sat Sep 05 2020, Vladimir Oltean wrote: > On Fri, Sep 04, 2020 at 08:27:34AM +0200, Kurt Kanzenbach wrote: >> Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are >> implementing features needed for Time Sensitive Networking (TSN) such as >> support >> for the Time Preci

Re: [PATCH iproute2 net-next v2] iplink: add support for protodown reason

2020-09-06 Thread Roopa Prabhu
On 9/1/20 6:54 PM, David Ahern wrote: On 8/28/20 9:42 PM, Roopa Prabhu wrote: From: Roopa Prabhu This patch adds support for recently added link IFLA_PROTO_DOWN_REASON attribute. IFLA_PROTO_DOWN_REASON enumerates reasons for the already existing IFLA_PROTO_DOWN link attribute. $ cat /etc/ip

Re: [PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning

2020-09-06 Thread Roopa Prabhu
On 9/6/20 8:31 PM, Randy Dunlap wrote: From: Randy Dunlap Fix kernel-doc warning in : ../include/linux/netdevice.h:2158: warning: Function parameter or member 'proto_down_reason' not described in 'net_device' Fixes: 829eb208e80d ("rtnetlink: add support for protodown reason") Signed-off-by

[net-next v2] tipc: fix a deadlock when flushing scheduled work

2020-09-06 Thread Hoang Huu Le
In the commit fdeba99b1e58 ("tipc: fix use-after-free in tipc_bcast_get_mode"), we're trying to make sure the tipc_net_finalize_work work item finished if it enqueued. But calling flush_scheduled_work() is not just affecting above work item but either any scheduled work. This has turned out to be o

Re: [PATCH for-next] net: provide __sys_shutdown_sock() that takes a socket

2020-09-06 Thread Christoph Hellwig
On Sat, Sep 05, 2020 at 04:05:48PM -0600, Jens Axboe wrote: > There's a trivial io_uring patch that depends on this one. If this one > is acceptable to you, I'd like to queue it up in the io_uring branch for > 5.10. Can you give it a better name? These __ names re just horrible. sock_shutdown_soc

[PATCHv3] selftests: rtnetlink: load fou module for kci_test_encap_fou() test

2020-09-06 Thread Po-Hsu Lin
The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh needs the fou module to work. Otherwise it will fail with: $ ip netns exec "$testns" ip fou add port ipproto 47 RTNETLINK answers: No such file or directory Error talking to the kernel Add the CONFIG_NET_FOU into the c

Re: [PATCH net 2/2] bnxt_en: Fix NULL ptr dereference crash in bnxt_fw_reset_task()

2020-09-06 Thread Michael Chan
On Sun, Sep 6, 2020 at 8:13 PM Jakub Kicinski wrote: > > On Sun, 6 Sep 2020 15:07:02 -0700 Michael Chan wrote: > > On Sun, Sep 6, 2020 at 12:25 PM Jakub Kicinski wrote: > > > > > > devlink can itself scheduler a recovery via: > > > > > > bnxt_fw_fatal_recover() -> bnxt_fw_reset() > > > > > > >

[PATCH net] netdevice.h: fix xdp_state kernel-doc warning

2020-09-06 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warning in : ../include/linux/netdevice.h:2158: warning: Function parameter or member 'xdp_state' not described in 'net_device' Fixes: 7f0a838254bd ("bpf, xdp: Maintain info on attached XDP BPF programs in net_device") Signed-off-by: Randy Dunlap Cc: Andrii

[PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning

2020-09-06 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warning in : ../include/linux/netdevice.h:2158: warning: Function parameter or member 'proto_down_reason' not described in 'net_device' Fixes: 829eb208e80d ("rtnetlink: add support for protodown reason") Signed-off-by: Randy Dunlap Cc: Roopa Prabhu --- incl

Re: [PATCH] tipc: fix shutdown() of connection oriented socket

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 15:14:47 +0900 Tetsuo Handa wrote: > I confirmed that the problem fixed by commit 2a63866c8b51a3f7 ("tipc: fix > shutdown() of connectionless socket") also applies to stream socket. > > -- > #include > #include > #include > > int main(int argc, char *argv[]) > { >

Re: [PATCH net 2/2] bnxt_en: Fix NULL ptr dereference crash in bnxt_fw_reset_task()

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 15:07:02 -0700 Michael Chan wrote: > On Sun, Sep 6, 2020 at 12:25 PM Jakub Kicinski wrote: > > > > devlink can itself scheduler a recovery via: > > > > bnxt_fw_fatal_recover() -> bnxt_fw_reset() > > > > Yes, this is how it is initiated when we call devlink_health_report() >

Re: [PATCH] net: Fix some comments

2020-09-06 Thread linmiaohe
Jakub Kicinski wrote: >On Sat, 5 Sep 2020 05:14:48 -0400 Miaohe Lin wrote: >> Since commit 8d7017fd621d ("blackhole_netdev: use blackhole_netdev to >> invalidate dst entries"), we use blackhole_netdev to invalidate dst >> entries instead of loopback device anymore. Also fix broken NETIF_F_HW_CSU

Re: [RFC v2 07/11] hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication

2020-09-06 Thread Boqun Feng
On Sat, Sep 05, 2020 at 12:30:48AM +, Michael Kelley wrote: > From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 > PM [...] > > struct rndis_request { > > struct list_head list_ent; > > struct completion wait_event; > > @@ -215,18 +215,18 @@ static int rndis_filter_send_request(

Re: [PATCH RFC 0/7] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-09-06 Thread Horatiu Vultur
The 09/04/2020 15:44, Stephen Hemminger wrote: > > On Fri, 4 Sep 2020 09:15:20 + > Henrik Bjoernlund wrote: > > > Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. > > > > Connectivity Fault Management (CFM) comprises capabilities for > > detecting, verifying, and isola

Re: [PATCH net 2/2] bnxt_en: Fix NULL ptr dereference crash in bnxt_fw_reset_task()

2020-09-06 Thread Michael Chan
On Sun, Sep 6, 2020 at 12:25 PM Jakub Kicinski wrote: > > devlink can itself scheduler a recovery via: > > bnxt_fw_fatal_recover() -> bnxt_fw_reset() > Yes, this is how it is initiated when we call devlink_health_report() to report the error condition. From bnxt_fw_reset(), we use a workqueue

Re: [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

2020-09-06 Thread Jakub Kicinski
On Mon, 7 Sep 2020 00:29:10 +0300 Nikolay Aleksandrov wrote: > >> @@ -1641,16 +1647,7 @@ br_multicast_leave_group(struct net_bridge *br, > >>if (p->flags & MDB_PG_FLAGS_PERMANENT) > >>break; > >> > >> - rcu_assign_pointer(*pp, p->n

Re: [PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit

2020-09-06 Thread Jakub Kicinski
On Mon, 7 Sep 2020 00:14:51 +0300 Nikolay Aleksandrov wrote: > On 9/7/20 12:01 AM, Jakub Kicinski wrote: > > On Sat, 5 Sep 2020 11:24:01 +0300 Nikolay Aleksandrov wrote: > >> We need to be able to retransmit group-specific and group-and-source > >> specific queries. The new timer takes care of t

Re: [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

2020-09-06 Thread Nikolay Aleksandrov
On 9/7/20 12:29 AM, Nikolay Aleksandrov wrote: On 9/6/20 11:56 PM, Jakub Kicinski wrote: On Sat,  5 Sep 2020 11:24:00 +0300 Nikolay Aleksandrov wrote: @@ -843,24 +843,11 @@ static int __br_mdb_del(struct net_bridge *br, struct br_mdb_entry *entry)   if (!p->port || p->port->dev->ifinde

Re: [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

2020-09-06 Thread Nikolay Aleksandrov
On 9/6/20 11:56 PM, Jakub Kicinski wrote: On Sat, 5 Sep 2020 11:24:00 +0300 Nikolay Aleksandrov wrote: @@ -843,24 +843,11 @@ static int __br_mdb_del(struct net_bridge *br, struct br_mdb_entry *entry) if (!p->port || p->port->dev->ifindex != entry->ifindex)

[PATCH] ath11k: fix a double free and a memory leak

2020-09-06 Thread trix
From: Tom Rix clang static analyzer reports this problem mac.c:6204:2: warning: Attempt to free released memory kfree(ar->mac.sbands[NL80211_BAND_2GHZ].channels); ^ The channels pointer is allocated in ath11k_mac_setup_channels_rat

[PATCH v2] net: dsa: rtl8366rb: Switch to phylink

2020-09-06 Thread Linus Walleij
This switches the RTL8366RB over to using phylink callbacks instead of .adjust_link(). This is a pretty template switchover. All we adjust is the CPU port so that is why the code only inspects this port. We enhance by adding proper error messages, also disabling the CPU port on the way down and mo

Re: [PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit

2020-09-06 Thread Nikolay Aleksandrov
On 9/7/20 12:01 AM, Jakub Kicinski wrote: On Sat, 5 Sep 2020 11:24:01 +0300 Nikolay Aleksandrov wrote: We need to be able to retransmit group-specific and group-and-source specific queries. The new timer takes care of those. What guarantees that timer will not use pg after free? Do timer call

Re: [PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 11:24:01 +0300 Nikolay Aleksandrov wrote: > We need to be able to retransmit group-specific and group-and-source > specific queries. The new timer takes care of those. What guarantees that timer will not use pg after free? Do timer callbacks hold the RCU read lock?

Re: [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 11:24:00 +0300 Nikolay Aleksandrov wrote: > @@ -843,24 +843,11 @@ static int __br_mdb_del(struct net_bridge *br, struct > br_mdb_entry *entry) > if (!p->port || p->port->dev->ifindex != entry->ifindex) > continue; > > - if (!hli

[PATCH] mwifiex: remove function pointer check

2020-09-06 Thread trix
From: Tom Rix clang static analyzer reports this problem init.c:739:8: warning: Called function pointer is null (null dereference) ret = adapter->if_ops.check_fw_status( ... ^ In mwifiex_dnld_fw, there is an earlier check for check_fw_stat

Re: [PATCH net-next v2 4/6] net: mvpp2: ptp: add TAI support

2020-09-06 Thread Russell King - ARM Linux admin
On Sat, Sep 05, 2020 at 10:02:58AM -0700, Richard Cochran wrote: > On Fri, Sep 04, 2020 at 08:29:27AM +0100, Russell King wrote: > > Add support for the TAI block in the mvpp2.2 hardware. > > > > Signed-off-by: Russell King > > Acked-by: Richard Cochran > > A few minor questions/comments follo

Re: [PATCH] enic: switch from 'pci_' to 'dma_' API

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 14:45:41 +0200 Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When

Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member config

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 21:23:37 +0200 Linus Walleij wrote: > On Sun, Sep 6, 2020 at 7:41 PM Jakub Kicinski wrote: > > On Sat, 5 Sep 2020 12:32:33 +0200 Linus Walleij wrote: > > > When removing a port from a VLAN we are just erasing the > > > member config for the VLAN, which is wrong: other ports >

Re: [PATCH v3] net: gemini: Clean up phy registration

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 21:21:13 +0200 Linus Walleij wrote: > It's nice if the phy is online before we register the netdev > so try to do that first. > > Stop trying to do "second tried" to register the phy, it > works perfectly fine the first time. > > Stop remvoving the phy in uninit. Remove it whe

Re: [PATCH net 2/2] bnxt_en: Fix NULL ptr dereference crash in bnxt_fw_reset_task()

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 22:55:37 -0400 Michael Chan wrote: > From: Vasundhara Volam > > bnxt_fw_reset_task() which runs from a workqueue can race with > bnxt_remove_one(). For example, if firmware reset and VF FLR are > happening at about the same time. > > bnxt_remove_one() already cancels the wor

Re: Failing to attach bond(created with two interfaces from different NICs) to a bridge

2020-09-06 Thread Florian Fainelli
On 9/6/2020 10:13 AM, Jakub Kicinski wrote: On Sun, 6 Sep 2020 14:12:49 +0300 Ido Schimmel wrote: On Thu, Sep 03, 2020 at 12:14:28PM -0700, Jakub Kicinski wrote: On Thu, 3 Sep 2020 12:52:25 +0530 Vasundhara Volam wrote: Hello Jiri, After the following set of upstream commits, the user fail

Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member config

2020-09-06 Thread Linus Walleij
On Sun, Sep 6, 2020 at 7:41 PM Jakub Kicinski wrote: > On Sat, 5 Sep 2020 12:32:33 +0200 Linus Walleij wrote: > > When removing a port from a VLAN we are just erasing the > > member config for the VLAN, which is wrong: other ports > > can be using it. > > > > Just mask off the port and only zero

[PATCH v3] net: gemini: Clean up phy registration

2020-09-06 Thread Linus Walleij
It's nice if the phy is online before we register the netdev so try to do that first. Stop trying to do "second tried" to register the phy, it works perfectly fine the first time. Stop remvoving the phy in uninit. Remove it when the driver is remove():d, symmetric to where it is added, in probe()

Re: [PATCH] net: Add a missing word

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 20:32:18 +0200 Jonathan Neuschäfer wrote: > Signed-off-by: Jonathan Neuschäfer Applied.

Re: [PATCH] net: Fix some comments

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 05:14:48 -0400 Miaohe Lin wrote: > Since commit 8d7017fd621d ("blackhole_netdev: use blackhole_netdev to > invalidate dst entries"), we use blackhole_netdev to invalidate dst entries > instead of loopback device anymore. Also fix broken NETIF_F_HW_CSUM spell. > > Signed-off-by:

Re: [PATCH net] net: macb: fix for pause frame receive enable bit

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 10:21:33 +0200 Parshuram Thombare wrote: > PAE bit of NCFGR register, when set, pauses transmission > if a non-zero 802.3 classic pause frame is received. > > Fixes: 7897b071ac3b ("net: macb: convert to phylink") > Signed-off-by: Parshuram Thombare Applied, thank you!

Re: [PATCH net-next 0/2] net: two updates related to UDP GSO

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 14:11:11 +0800 Huazhong Tan wrote: > There are two updates relates to UDP GSO. > #1 adds a new GSO type for UDPv6 > #2 adds check for UDP GSO when csum is disable in netdev_fix_features(). > > Changes since RFC V2: > - modifies the timing of setting UDP GSO type when doing UDP G

Re: Policy Routing and two independent, not cooperating IPv6 uplinks

2020-09-06 Thread Marc Haber
On Tue, Sep 01, 2020 at 12:14:02AM +0200, Marc Haber wrote: > Thanks for your help and consideration. I hope this message is not going > to be ignored and I would love to have this taken up by you developers > as an every-day, but non-trivial use case from a productive network. Hi, no-one wants t

Re: [net-next] tipc: fix a deadlock when flushing scheduled work

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 11:45:18 +0700 Hoang Huu Le wrote: > In the commit fdeba99b1e58 > ("tipc: fix use-after-free in tipc_bcast_get_mode"), we're trying > to make sure the tipc_net_finalize_work work item finished if it > enqueued. But calling flush_scheduled_work() is not just affecting > above wor

Re: [net-next PATCH] net: dsa: rtl8366rb: Switch to phylink

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 00:48:28 +0200 Linus Walleij wrote: > -static void rtl8366rb_adjust_link(struct dsa_switch *ds, int port, > - struct phy_device *phydev) > +void rtl8366rb_mac_link_up(struct dsa_switch *ds, int port, unsigned int > mode, > +

Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member config

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 12:32:33 +0200 Linus Walleij wrote: > When removing a port from a VLAN we are just erasing the > member config for the VLAN, which is wrong: other ports > can be using it. > > Just mask off the port and only zero out the rest of the > member config once ports using of the VLAN

Re: [PATCH] net: dsa: rtl8366rb: Support setting MTU

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 18:58:08 -0700 Florian Fainelli wrote: > On 9/5/2020 2:59 PM, Linus Walleij wrote: > > This implements the missing MTU setting for the RTL8366RB > > switch. > > > > Apart from supporting jumboframes, this rids us of annoying > > boot messages like this: > > realtek-smi switch: n

Re: [net-next PATCH v2] net: gemini: Clean up phy registration

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 22:42:57 +0200 Linus Walleij wrote: > diff --git a/drivers/net/ethernet/cortina/gemini.c > b/drivers/net/ethernet/cortina/gemini.c > index ffec0f3dd957..94707c9dda88 100644 > --- a/drivers/net/ethernet/cortina/gemini.c > +++ b/drivers/net/ethernet/cortina/gemini.c > @@ -2505,6

Re: [PATCH net-next v2] net/packet: Remove unused macro BLOCK_PRIV

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 11:15:05 +0200 Willem de Bruijn wrote: > On Sat, Sep 5, 2020 at 10:53 AM Wang Hai wrote: > > > > BLOCK_PRIV is never used after it was introduced. > > So better to remove it. > > > > Reported-by: Hulk Robot > > Signed-off-by: Wang Hai > > Acked-by: Willem de Bruijn Applie

Re: Failing to attach bond(created with two interfaces from different NICs) to a bridge

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 14:12:49 +0300 Ido Schimmel wrote: > On Thu, Sep 03, 2020 at 12:14:28PM -0700, Jakub Kicinski wrote: > > On Thu, 3 Sep 2020 12:52:25 +0530 Vasundhara Volam wrote: > > > Hello Jiri, > > > > > > After the following set of upstream commits, the user fails to attach > > > a bond t

Re: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 03:08:45 + Parav Pandit wrote: > > >3) local: { "controller ID": x } > > > remote1: { "controller ID": y, "external": true } > > > remote1: { "controller ID": z, "external": true } > > > > > >We don't have to put the controller ID in the name for local ports, but > > >t

Re: [PATCH V2 net-next 1/4] net: ena: ethtool: use unsigned long for pointer arithmetics

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 13:47:13 +0300 Shay Agroskin wrote: > Maciej Fijalkowski writes: > > I don't want to stir up the pot, but do you really need the > > offsetof() of > > each member in the stats struct? Couldn't you piggyback on > > assumption that > > these stats need to be u64 and just walk th

Re: [PATCH net-next] mlx4: make sure to always set the port type

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 10:27:59 +0300 Leon Romanovsky wrote: > On Fri, Sep 04, 2020 at 01:06:21PM -0700, Jakub Kicinski wrote: > > Even tho mlx4_core registers the devlink ports, it's mlx4_en > > and mlx4_ib which set their type. In situations where one of > > the two is not built yet the machine has p

Re: [PATCH net] hv_netvsc: Fix hibernation for mlx5 VF driver

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 03:05:48 + Dexuan Cui wrote: > > > @@ -2635,6 +2632,10 @@ static int netvsc_resume(struct hv_device *dev) > > > netvsc_devinfo_put(device_info); > > > net_device_ctx->saved_netvsc_dev_info = NULL; > > > > > > + vf_netdev = rtnl_dereference(net_device_ctx->vf_netdev); > >

Re: [PATCH net-next RFC v1 3/4] devlink: Add hierarchy between traps in device level and port level

2020-09-06 Thread Ido Schimmel
On Wed, Sep 02, 2020 at 06:32:13PM +0300, Aya Levin wrote: > Managing large scale port's traps may be complicated. This patch > introduces a shortcut: when setting a trap on a device and this trap is > not registered on this device, the action will take place on all related > ports that did registe

[PATCH v2 2/9] dt-bindings: net: nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs

2020-09-06 Thread Krzysztof Kozlowski
The device tree property prefix describes the vendor, which in case of S3FWRN5 chip is Samsung. Therefore the "s3fwrn5" prefix for "en-gpios" and "fw-gpios" is not correct and should be deprecated. Introduce properly named properties for these GPIOs and rename the fw-gpios" to "wake-gpios" to bet

[PATCH v2 1/9] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema

2020-09-06 Thread Krzysztof Kozlowski
Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. This is conversion only so it includes properties with invalid prefixes (s3fwrn5,en-gpios) which should be addressed later. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 ...

[PATCH v2 0/9] nfc: s3fwrn5: Few cleanups

2020-09-06 Thread Krzysztof Kozlowski
Hi, Changes since v1: 1. Rename dtschema file and add additionalProperties:false, as Rob suggested, 2. Add Marek's tested-by, 3. New patches: #4, #5, #6, #7 and #9. Best regards, Krzysztof Krzysztof Kozlowski (9): dt-bindings: net: nfc: s3fwrn5: Convert to dtschema dt-bindings: net: nfc:

[PATCH v2 5/9] nfc: s3fwrn5: Add missing CRYPTO_HASH dependency

2020-09-06 Thread Krzysztof Kozlowski
The driver uses crypto hash functions so it needs to select CRYPTO_HASH. This fixes build errors: arc-linux-ld: drivers/nfc/s3fwrn5/firmware.o: in function `s3fwrn5_fw_download': firmware.c:(.text+0x152): undefined reference to `crypto_alloc_shash' Signed-off-by: Krzysztof Kozlowski --- dr

[PATCH v2 4/9] nfc: s3fwrn5: Remove unneeded 'ret' variable

2020-09-06 Thread Krzysztof Kozlowski
The local variable 'ret' can be removed: drivers/nfc/s3fwrn5/i2c.c:167:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/s3fwrn5/i2c.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/nfc/s

Re: [PATCH net-next RFC v1 2/4] devlink: Add devlink traps under devlink_ports context

2020-09-06 Thread Ido Schimmel
On Wed, Sep 02, 2020 at 06:32:12PM +0300, Aya Levin wrote: > There are some cases where we would like to trap dropped packets only > for a single port on a device without affecting the others. For that > purpose trap_mngr was added to devlink_port and corresponding Trap API > with devlink_port were

[PATCH v2 6/9] nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified

2020-09-06 Thread Krzysztof Kozlowski
Two functions accept pointer to struct s3fwrn5_fw_info but do not modify the contents. Make them const so the code is a little bit safer. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/s3fwrn5/firmware.c | 4 ++-- drivers/nfc/s3fwrn5/firmware.h | 2 +- 2 files changed, 3 insertions(+), 3 de

[PATCH v2 7/9] MAINTAINERS: Add Krzysztof Kozlowski to Samsung S3FWRN5 and remove Robert

2020-09-06 Thread Krzysztof Kozlowski
Robert Bałdyga's email does not work (bounces) since 2016 so remove it. Additionally there are no review/ack/tested tags from Krzysztof Opasiak so it looks like the driver is not supported. As a maintainer of Samsung ARM/ARM64 SoC, I can take care about this driver and provide some review. Howeve

[PATCH v2 9/9] arm64: defconfig: Enable Samsung S3FWRN5 NFC driver

2020-09-06 Thread Krzysztof Kozlowski
Enable the Samsung S3FWRN5 NFC driver present in Exynos5433-based TM2/TM2E boards. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index a03cefd58799..b78a14d43f

[PATCH v2 8/9] arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433 TM2

2020-09-06 Thread Krzysztof Kozlowski
Since "s3fwrn5" is not a valid vendor prefix, use new GPIO properties instead of the deprecated. Signed-off-by: Krzysztof Kozlowski Tested-by: Marek Szyprowski --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/

[PATCH v2 3/9] nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs

2020-09-06 Thread Krzysztof Kozlowski
The device tree property prefix describes the vendor, which in case of S3FWRN5 chip is Samsung. Therefore the "s3fwrn5" prefix for "en-gpios" and "fw-gpios" is not correct and should be deprecated. Introduce properly named properties for these GPIOs but still support deprecated ones. Signed-off-

Re: [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema

2020-09-06 Thread Krzysztof Kozlowski
On Thu, 3 Sep 2020 at 18:33, Rob Herring wrote: > > On Sat, Aug 29, 2020 at 04:29:45PM +0200, Krzysztof Kozlowski wrote: > > Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. > > This is conversion only so it includes properties with invalid prefixes > > (s3fwrn5,en-gpios) which

Re: [net-next PATCH v2] net: gemini: Clean up phy registration

2020-09-06 Thread Andrew Lunn
On Sat, Sep 05, 2020 at 10:42:57PM +0200, Linus Walleij wrote: > It's nice if the phy is online before we register the netdev > so try to do that first. > > Stop trying to do "second tried" to register the phy, it > works perfectly fine the first time. > > Stop remvoving the phy in uninit. Remove

[PATCH net] netns: fix a deadlock in peernet2id_alloc()

2020-09-06 Thread Taehee Yoo
To protect netns id, the nsid_lock is used when netns id is being allocated and removed by peernet2id_alloc() and unhash_nsid(). The nsid_lock can be used in BH context but only spin_lock() is used in this code. Using spin_lock() instead of spin_lock_bh() can result in a deadlock in the following s

Re: [PATCH v2 net-next 6/9] bpf: helpers: add bpf_xdp_adjust_mb_header helper

2020-09-06 Thread Lorenzo Bianconi
> Lorenzo Bianconi wrote: > > > Lorenzo Bianconi wrote: [...] > > > > + * Description > > > > + * Adjust frame headers moving *offset* bytes from/to the > > > > second > > > > + * buffer to/from the first one. This helper can be used > > > > to move > > > > + *

[PATCH] enic: switch from 'pci_' to 'dma_' API

2020-09-06 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'vnic_dev_classifier()', 'vnic_dev_fw_info()', 'vnic

Re: Failing to attach bond(created with two interfaces from different NICs) to a bridge

2020-09-06 Thread Vasundhara Volam
On Fri, Sep 4, 2020 at 12:44 AM Jakub Kicinski wrote: > > On Thu, 3 Sep 2020 12:52:25 +0530 Vasundhara Volam wrote: > > Hello Jiri, > > > > After the following set of upstream commits, the user fails to attach > > a bond to the bridge, if the user creates the bond with two interfaces > > from diff

Re: Failing to attach bond(created with two interfaces from different NICs) to a bridge

2020-09-06 Thread Ido Schimmel
On Thu, Sep 03, 2020 at 12:14:28PM -0700, Jakub Kicinski wrote: > On Thu, 3 Sep 2020 12:52:25 +0530 Vasundhara Volam wrote: > > Hello Jiri, > > > > After the following set of upstream commits, the user fails to attach > > a bond to the bridge, if the user creates the bond with two interfaces > > f

Re: [PATCH v14 08/10] ptp: arm64: Enable ptp_kvm for arm64

2020-09-06 Thread Marc Zyngier
On Sat, 05 Sep 2020 12:01:42 +0100, Marc Zyngier wrote: > > On Fri, 04 Sep 2020 10:27:42 +0100, > Jianyong Wu wrote: [...] > > +{ > > + ktime_t ktime; > > + > > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID, > > +hvc_res); > > + if ((long long)(hvc_r

Re: [PATCH v2 net-next 3/9] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer

2020-09-06 Thread Lorenzo Bianconi
[...] > > rx_desc->buf_phys_addr, > > len, dma_dir); > > - if (data_len > 0 && sinfo->nr_frags < MAX_SKB_FRAGS) { > > - skb_frag_t *frag = &sinfo->frags[sinfo->nr_frags]; > > + if (data_len > 0 && *nfrags < MAX_SKB_FRAGS) { > >

Re: [PATCH v2 net-next 5/9] net: mvneta: add multi buffer support to XDP_TX

2020-09-06 Thread Lorenzo Bianconi
> > Lorenzo Bianconi writes: > [...] > > - buf->xdpf = xdpf; > > - tx_desc->command = MVNETA_TXD_FLZ_DESC; > > - tx_desc->buf_phys_addr = dma_addr; > > - tx_desc->data_size = xdpf->len; > > + /*last descriptor */ > > + if (tx_desc) > > + tx_desc->command |= MVNETA_TXD_L_D

Re: [net-next PATCH] net: dsa: rtl8366rb: Switch to phylink

2020-09-06 Thread Russell King - ARM Linux admin
On Sat, Sep 05, 2020 at 06:56:45PM -0700, Florian Fainelli wrote: > +Russell, > > On 9/5/2020 3:48 PM, Linus Walleij wrote: > > This switches the RTL8366RB over to using phylink callbacks > > instead of .adjust_link(). This is a pretty template > > switchover. All we adjust is the CPU port so that

RE: [EXT] [PATCH v2 16/17] RDMA/qedr: Remove fbo and zbva from the MR

2020-09-06 Thread Michal Kalderon
> From: Jason Gunthorpe > Sent: Saturday, September 5, 2020 1:42 AM > zbva is always false, so fbo is never read. > > A 'zero-based-virtual-address' is simply IOVA == 0, and the driver already > supports this. > > Signed-off-by: Jason Gunthorpe > --- > drivers/infiniband/hw/qedr/verbs.c

Re: [PATCH v2 net-next 3/9] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer

2020-09-06 Thread Shay Agroskin
Lorenzo Bianconi writes: Update multi-buffer bit (mb) in xdp_buff to notify XDP/eBPF layer and XDP remote drivers if this is a "non-linear" XDP buffer. Access skb_shared_info only if xdp_buff mb is set Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 37 ++

Re: [PATCH net-next] mlx4: make sure to always set the port type

2020-09-06 Thread Leon Romanovsky
On Fri, Sep 04, 2020 at 01:06:21PM -0700, Jakub Kicinski wrote: > Even tho mlx4_core registers the devlink ports, it's mlx4_en > and mlx4_ib which set their type. In situations where one of > the two is not built yet the machine has ports of given type > we see the devlink warning from devlink_port

Re: [PATCH v2 net-next 5/9] net: mvneta: add multi buffer support to XDP_TX

2020-09-06 Thread Shay Agroskin
Lorenzo Bianconi writes: Introduce the capability to map non-linear xdp buffer running mvneta_xdp_submit_frame() for XDP_TX and XDP_REDIRECT Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 79 +-- 1 file changed, 49 insertions(+), 30 d