Hi Andrew,
On Fri, Sep 04, 2020 at 03:52:55PM +0200, Andrew Lunn wrote:
> > + dev_warn(dev->dev,
> > + "Using legacy switch \"phy-mode\" missing on
> > port %d node. Please update your device tree.\n",
This is inside ksz8795_port_setup.
> That message seems mangled.
I'm not sure that I understand what you are objecting to here.
> > + if (!p->interface) {
> > + if (dev->compat_interface) {
> > + dev_warn(dev->dev,
> > + "Using legacy switch
> > \"phy-mode\" missing on port %d node. Please update your device tree.\n",
> > + i);
This is inside ksz9477_config_cpu_port.
> Same warning again.
I guess that you believe the warning should only be issued in one place.
The locations affect different chips driven by the same driver. I
considered moving them to a common function, but figured that it was not
worth tearing the code apart. In case a third chip would be supported by
the driver, it would not need the compatibility code. It would start out
using only the correct phy-mode property.
Does that address your concern?
Helmut
