Re: [net-next PATCH v2] net: gemini: Clean up phy registration

[Jakub Kicinski]

On Sat,  5 Sep 2020 22:42:57 +0200 Linus Walleij wrote:
> diff --git a/drivers/net/ethernet/cortina/gemini.c 
> b/drivers/net/ethernet/cortina/gemini.c
> index ffec0f3dd957..94707c9dda88 100644
> --- a/drivers/net/ethernet/cortina/gemini.c
> +++ b/drivers/net/ethernet/cortina/gemini.c

> @@ -2505,6 +2491,13 @@ static int gemini_ethernet_port_probe(struct 
> platform_device *pdev)
>       if (ret)
>               goto unprepare;
>  
> +     ret = gmac_setup_phy(netdev);
> +     if (ret) {
> +             netdev_err(netdev,
> +                        "PHY init failed\n");
> +             return ret;

goto unprepare?

> +     }
> +
>       ret = register_netdev(netdev);
>       if (ret)
>               goto unprepare;