On Sun, Sep 6, 2020 at 12:25 PM Jakub Kicinski <k...@kernel.org> wrote: > > devlink can itself scheduler a recovery via: > > bnxt_fw_fatal_recover() -> bnxt_fw_reset() >
Yes, this is how it is initiated when we call devlink_health_report() to report the error condition. From bnxt_fw_reset(), we use a workqueue because we have to go through many states, requiring sleeping/polling to transition through the states. > no? Maybe don't make the devlink recovery path need to go via a > workqueue? Current implementation is going through a work queue.