On Sun, 6 Sep 2020 00:48:28 +0200 Linus Walleij wrote: > -static void rtl8366rb_adjust_link(struct dsa_switch *ds, int port, > - struct phy_device *phydev) > +void rtl8366rb_mac_link_up(struct dsa_switch *ds, int port, unsigned int > mode, > + phy_interface_t interface, struct phy_device *phydev, > + int speed, int duplex, bool tx_pause, bool rx_pause) > {
> +void rtl8366rb_mac_link_down(struct dsa_switch *ds, int port, unsigned int > mode, > + phy_interface_t interface) > +{ .get_sset_count = rtl8366_get_sset_count, drivers/net/dsa/rtl8366rb.c:972:6: warning: no previous prototype for ‘rtl8366rb_mac_link_up’ [-Wmissing-prototypes] 972 | void rtl8366rb_mac_link_up(struct dsa_switch *ds, int port, unsigned int mode, | ^~~~~~~~~~~~~~~~~~~~~ drivers/net/dsa/rtl8366rb.c:1009:6: warning: no previous prototype for ‘rtl8366rb_mac_link_down’ [-Wmissing-prototypes] 1009 | void rtl8366rb_mac_link_down(struct dsa_switch *ds, int port, unsigned int mode, | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/dsa/rtl8366rb.c:972:6: warning: symbol 'rtl8366rb_mac_link_up' was not declared. Should it be static? drivers/net/dsa/rtl8366rb.c:1009:6: warning: symbol 'rtl8366rb_mac_link_down' was not declared. Should it be static?