Hi, All
The steps to reproduce this problem. And it is easy to reproduce.
1. boot with 5.2.0-rc2+, and KASAN is also enabled in this kernel
2. run the following scripts:
"
for i in `seq 0 5`
do
rds-ping -c 2 1.1.1.14 -Q $i
done
"
3. run "rmmod rds_rdma"
4. check /var/log/dmesg, th
Currently, when rx csum is disabled, vmxnet3 driver does not turn
off lro, which can cause performance issues if user does not turn off
lro explicitly. This patch adds fix_features support which is used to
turn off LRO whenever RXCSUM is disabled.
Signed-off-by: Ronak Doshi
Acked-by: Rishi Mehta
On Tue, 2019-06-04 at 02:15 +, Bshara, Nafea wrote:
> Andrew,
>
> Sent from my iPhone
>
> On Jun 3, 2019, at 6:52 PM, Andrew Lunn wrote:
>
> > > Any "SmartNIC" vendor has temptation of uAPI-level hand off to the
> > > firmware (including my employer), we all run pretty beefy processors
> >
We have a Xilinx GBit PHY that doesn't have BMSR_ESTATEN set
(what violates the Clause 22 standard). Instead of having the PHY
driver to implement almost identical copies of few generic functions
let's add a flag for this quirk to phylib.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/phy_de
On Mon, 3 Jun 2019 at 19:49, Jonathan Lemon wrote:
>
> v3->v4:
> - Clarify error handling path.
>
> v2->v3:
> - Use correct map type.
>
> Jonathan Lemon (2):
> bpf: Allow bpf_map_lookup_elem() on an xskmap
> libbpf: remove qidconf and better support external bpf programs.
>
Nice work!
For
In preparation of factoring out firmware handling rename r8169.c to
r8169_main.c.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/Makefile | 1 +
drivers/net/ethernet/realtek/{r8169.c => r8169_main.c} | 0
2 files changed, 1 insertion(+)
rename drivers/net/ether
Let's factor out firmware handling into a separate source code file.
This simplifies reading the code and makes clearer what the interface
between driver and firmware handling is.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/Makefile | 2 +-
drivers/net/ethernet/real
Let's factor out firmware handling into a separate source code file.
This simplifies reading the code and makes clearer what the interface
between driver and firmware handling is.
Heiner Kallweit (2):
r8169: rename r8169.c to r8169_main.c
r8169: factor out firmware handling
drivers/net/ether
On 04.06.2019 01:12, Robert Hancock wrote:
> This adds a driver for the PHY device implemented in the Xilinx PCS/PMA
> Core logic. This is mostly a generic gigabit PHY, except that the
> features are explicitly set because the PHY wrongly indicates it has no
> extended status register when it actua
On Tue, 4 Jun 2019 at 01:11, Daniel Borkmann wrote:
>
> On 06/03/2019 10:39 AM, Björn Töpel wrote:
> > On Sat, 1 Jun 2019 at 20:12, Jonathan Lemon wrote:
> >> On 31 May 2019, at 2:42, Björn Töpel wrote:
> >>> From: Björn Töpel
> >>>
> >>> All XDP capable drivers need to implement the XDP_QUERY_P
On Mon, Jun 03, 2019 at 07:36:06PM -0600, David Ahern wrote:
> On 6/3/19 6:58 PM, Martin Lau wrote:
> > I have concern on calling ip6_create_rt_rcu() in general which seems
> > to trace back to this commit
> > dec9b0e295f6 ("net/ipv6: Add rt6_info create function for
> > ip6_pol_route_lookup")
> >
On Mon, 3 Jun 2019 at 23:20, Saeed Mahameed wrote:
>
> On Mon, 2019-06-03 at 11:04 +0200, Björn Töpel wrote:
> > On Sat, 1 Jun 2019 at 21:42, Jakub Kicinski
> > wrote:
> > > On Fri, 31 May 2019 19:18:17 +, Saeed Mahameed wrote:
> > > > On Fri, 2019-05-31 at 11:42 +0200, Björn Töpel wrote:
> >
On Mon, 3 Jun 2019 at 19:03, Jakub Kicinski
wrote:
>
> On Mon, 3 Jun 2019 11:04:36 +0200, Björn Töpel wrote:
> > On Sat, 1 Jun 2019 at 21:57, Jakub Kicinski
> > wrote:
> > >
> > > On Fri, 31 May 2019 19:18:17 +, Saeed Mahameed wrote:
> > > > > + if (!bpf_op || flags & XDP_FLAGS_SKB_MODE)
>
> BTF is mandatory for _any_ new feature.
If something is easy to support without asking everyone to upgrade to
a bleeding edge llvm, why not do it?
So much for backwards compatibility and flexibility.
> It's for introspection and debuggability in the first place.
> Good debugging is not optional.
From: Fabio Estevam Sent: Tuesday, June 4, 2019 11:05 AM
> netdev_err() is more appropriate for printing error messages inside network
> drivers, so switch to netdev_err().
>
> Signed-off-by: Fabio Estevam
> ---
> Changes since v1:
> - Split the changes from fec_main and fec_ptp in two different
From: Fabio Estevam Sent: Tuesday, June 4, 2019 11:05 AM
> dev_err() is more appropriate for printing error messages inside drivers, so
> switch to dev_err().
>
> Signed-off-by: Fabio Estevam
Acked-by: Fugang Duan
> ---
> Changes since v1:
> - Use dev_err() instead of netdev_err() - Andy
>
>
From: David Ahern
Convert more IPv4 code to use fib_nh_common over fib_nh to enable routes
to use a fib6_nh based nexthop. In the end, only code not using a
nexthop object in a fib_info should directly access fib_nh in a fib_info
without checking the famiy and going through fib_nh_common. Those
f
On 2019/5/29 上午 12:11, Arend Van Spriel wrote:
> On May 28, 2019 6:09:21 PM Arend Van Spriel
> wrote:
>
>> On May 28, 2019 5:52:10 PM Doug Anderson wrote:
>>
>>> Hi,
>>>
>>> On Tue, May 28, 2019 at 5:18 AM Kalle Valo wrote:
Douglas Anderson wrote:
> In commit 29f6589140a
From: David Ahern
Use helpers to access fib_nh and fib_nhs fields of a fib_info. Drop the
fib_dev macro which is an alias for the first nexthop. Replacements:
fi->fib_dev--> fib_info_nh(fi, 0)->fib_nh_dev
fi->fib_nh --> fib_info_nh(fi, 0)
fi->fib_nh[i] --> fib_info_nh(fi, i)
fi-
From: David Ahern
Add 'struct nexthop' and nh_list list_head to fib_info. nh_list is the
fib_info side of the nexthop <-> fib_info relationship.
Add fi_list list_head to 'struct nexthop' to track fib_info entries
using a nexthop instance. Add __remove_nexthop_fib and add it to
__remove_nexthop t
From: David Ahern
Fail attempts to use nexthop objects with routes until support can be
properly added.
Signed-off-by: David Ahern
---
drivers/net/ethernet/rocker/rocker_main.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/rocker/rocker_main.c
b/drivers/net/ethe
From: David Ahern
Fail attempts to use nexthop objects with routes until support can be
properly added.
Signed-off-by: David Ahern
---
drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
b/dr
From: David Ahern
Fail attempts to use nexthop objects with routes until support can be
properly added.
Signed-off-by: David Ahern
Reviewed-by: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/ne
From: David Ahern
Set 10 of 11 to improve route scalability via support for nexthops as
standalone objects for fib entries.
https://lwn.net/Articles/763950/
This sets adds 'struct nexthop' to fib_info and fib6_info. IPv4
already handles multiple fib_nh entries in a single fib_info, so
the co
From: David Ahern
Add struct nexthop and nh_list list_head to fib6_info. nh_list is the
fib6_info side of the nexthop <-> fib_info relationship. Since a fib6_info
referencing a nexthop object can not have 'sibling' entries (the old way
of doing multipath routes), the nh_list is a union with fib6_
netdev_err() is more appropriate for printing error messages inside
network drivers, so switch to netdev_err().
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Split the changes from fec_main and fec_ptp in two different patches
drivers/net/ethernet/freescale/fec_main.c | 8
1 fil
dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Use dev_err() instead of netdev_err() - Andy
drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
From: Fabio Estevam [mailto:feste...@gmail.com]
> netdev_err() is more appropriate for printing error messages inside network
> drivers, so switch to netdev_err().
>
> Signed-off-by: Fabio Estevam
> ---
> drivers/net/ethernet/freescale/fec_main.c | 8
> drivers/net/ethernet/freescale/fec
On Mon, Jun 03, 2019 at 03:57:07PM -0600, Robert Hancock wrote:
> The Xilinx DMA blocks each have their own reset register, but they both
> reset the entire DMA engine, so only one of them needs to be reset.
>
> Also, when stopping the device, we need to not just command the DMA
> blocks to stop,
On Mon, Jun 03, 2019 at 03:57:06PM -0600, Robert Hancock wrote:
> The MDIO clock divisor register setting was only applied on the initial
> startup when the driver was loaded. However, this setting is cleared
> when the device is reset, such as would occur when the interface was
> taken down and br
+Heiner, Andrew,
On 6/3/2019 4:12 PM, Robert Hancock wrote:
> This adds a driver for the PHY device implemented in the Xilinx PCS/PMA
> Core logic. This is mostly a generic gigabit PHY, except that the
> features are explicitly set because the PHY wrongly indicates it has no
> extended status regi
test_lirc_mode2_user is included in test_lirc_mode2.sh test and should
not be run directly.
Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program")
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/bpf/Makefile | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff
On Mon, Jun 03, 2019 at 03:57:05PM -0600, Robert Hancock wrote:
> Since the MDIO is is brought up before the netdev is registered, it
> should be torn down after the netdev is removed. Otherwise, PHY accesses
> can potentially access freed MDIO bus references and cause a crash.
>
> Signed-off-by:
On Mon, Jun 03, 2019 at 03:57:04PM -0600, Robert Hancock wrote:
> This driver was previously always calculating the MDIO clock divisor
> (from AXI bus clock to MDIO bus clock) based on the CPU clock frequency,
> but that simplistic method only works on the MicroBlaze platform. This
> really has to
On Mon, Jun 03, 2019 at 03:57:03PM -0600, Robert Hancock wrote:
> This driver should now build on (at least) X86 and ARM platforms, so add
> them as supported platforms for the driver in Kconfig.
>
> Signed-off-by: Robert Hancock
Reviewed-by: Andrew Lunn
Andrew
On Mon, Jun 03, 2019 at 03:57:02PM -0600, Robert Hancock wrote:
> The MDIO bus for this driver was being named using the result of
> of_address_to_resource on a node which may not have any resource on it,
> but the return value of that call was not checked so it was using some
> random value in the
netdev_err() is more appropriate for printing error messages inside
network drivers, so switch to netdev_err().
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/freescale/fec_main.c | 8
drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions
Andrew,
Sent from my iPhone
On Jun 3, 2019, at 6:52 PM, Andrew Lunn wrote:
>> Any "SmartNIC" vendor has temptation of uAPI-level hand off to the
>> firmware (including my employer), we all run pretty beefy processors
>> inside "the NIC" after all. The device centric ethtool configuration
>> ca
By default, packets received in another VRF should not be passed to an
unbound socket in the default VRF. This patch updates the IPv4 UDP
multicast logic to match the unicast VRF logic (in compute_score()),
as well as the IPv6 mcast logic (in __udp_v6_is_mcast_sock()).
The particular case I notice
On Mon, Jun 03, 2019 at 03:57:00PM -0600, Robert Hancock wrote:
> This driver was casting skb pointers to u32 and storing them as such in
> the DMA buffer descriptor, which is obviously broken on 64-bit. The area
> of the buffer descriptor being used is not accessed by the hardware and
> has suffic
> Any "SmartNIC" vendor has temptation of uAPI-level hand off to the
> firmware (including my employer), we all run pretty beefy processors
> inside "the NIC" after all. The device centric ethtool configuration
> can be implemented by just forwarding the uAPI structures as they are
> to the FW. I
From: David Ahern
A recent commit had an unintended side effect with reject routes:
rt6i_pcpu is expected to always be initialized for all fib6_info except
the null entry. The commit mentioned below skips it for reject routes
and ends up leaking references to the loopback device. For example,
On 6/3/19 6:58 PM, Martin Lau wrote:
> I have concern on calling ip6_create_rt_rcu() in general which seems
> to trace back to this commit
> dec9b0e295f6 ("net/ipv6: Add rt6_info create function for
> ip6_pol_route_lookup")
>
> This rt is not tracked in pcpu_rt, rt6_uncached_list or exception buc
Bonjour,
Je soussignée Mme Lilie MARTINS de nationalité française. Je vous envoie ce
présent message afin de solliciter votre accord pour la réalisation d'un projet
de donation. Ayant perdu mon époux et mon enfant de 8 ans au cours d'un
accident tragique et mortel Il y a quelques années, je n'a
Bonjour,
Je soussignée Mme Lilie MARTINS de nationalité française. Je vous envoie ce
présent message afin de solliciter votre accord pour la réalisation d'un projet
de donation. Ayant perdu mon époux et mon enfant de 8 ans au cours d'un
accident tragique et mortel Il y a quelques années, je n'a
On 6/3/19 6:02 PM, Stanislav Fomichev wrote:
> Do we want to lock everyone out of new libbpf features?
BTF is mandatory for _any_ new feature.
It's for introspection and debuggability in the first place.
Good debugging is not optional.
On 06/03, Andrii Nakryiko wrote:
> On Mon, Jun 3, 2019 at 9:32 AM Stanislav Fomichev wrote:
> >
> > On 05/31, Andrii Nakryiko wrote:
> > > On Fri, May 31, 2019 at 2:28 PM Stanislav Fomichev
> > > wrote:
> > > >
> > > > On 05/31, Andrii Nakryiko wrote:
> > > > > This patch adds support for a new
On Mon, Jun 03, 2019 at 05:18:11PM -0600, David Ahern wrote:
> On 6/3/19 5:05 PM, Wei Wang wrote:
> > On Mon, Jun 3, 2019 at 3:35 PM David Ahern wrote:
> >>
> >> On 6/3/19 3:58 PM, Wei Wang wrote:
> >>> Hmm... I am still a bit concerned with the ip6_create_rt_rcu() call.
> >>> If we have a blackho
On Mon, 3 Jun 2019 14:54:53 -0700, Andrii Nakryiko wrote:
> On Sun, Jun 2, 2019 at 5:33 PM Jakub Kicinski wrote:
> > On Fri, 31 May 2019 15:58:41 -0700, Andrii Nakryiko wrote:
> > > On Fri, May 31, 2019 at 2:28 PM Stanislav Fomichev
> > > wrote:
> > > > On 05/31, Andrii Nakryiko wrote:
> >
On Mon, Jun 3, 2019 at 4:18 PM David Ahern wrote:
>
> On 6/3/19 5:05 PM, Wei Wang wrote:
> > On Mon, Jun 3, 2019 at 3:35 PM David Ahern wrote:
> >>
> >> On 6/3/19 3:58 PM, Wei Wang wrote:
> >>> Hmm... I am still a bit concerned with the ip6_create_rt_rcu() call.
> >>> If we have a blackholed next
On Mon, 3 Jun 2019 17:12:04 -0600
Robert Hancock wrote:
> This adds a driver for the PHY device implemented in the Xilinx PCS/PMA
> Core logic. This is mostly a generic gigabit PHY, except that the
> features are explicitly set because the PHY wrongly indicates it has no
> extended status registe
On 6/3/19 5:05 PM, Wei Wang wrote:
> On Mon, Jun 3, 2019 at 3:35 PM David Ahern wrote:
>>
>> On 6/3/19 3:58 PM, Wei Wang wrote:
>>> Hmm... I am still a bit concerned with the ip6_create_rt_rcu() call.
>>> If we have a blackholed nexthop, the lookup code here always tries to
>>> create an rt cache
This adds a driver for the PHY device implemented in the Xilinx PCS/PMA
Core logic. This is mostly a generic gigabit PHY, except that the
features are explicitly set because the PHY wrongly indicates it has no
extended status register when it actually does.
This version is a simplified version of
On 06/03/2019 10:39 AM, Björn Töpel wrote:
> On Sat, 1 Jun 2019 at 20:12, Jonathan Lemon wrote:
>> On 31 May 2019, at 2:42, Björn Töpel wrote:
>>> From: Björn Töpel
>>>
>>> All XDP capable drivers need to implement the XDP_QUERY_PROG{,_HW}
>>> command of ndo_bpf. The query code is fairly generic.
On Mon, Jun 3, 2019 at 3:35 PM David Ahern wrote:
>
> On 6/3/19 3:58 PM, Wei Wang wrote:
> > Hmm... I am still a bit concerned with the ip6_create_rt_rcu() call.
> > If we have a blackholed nexthop, the lookup code here always tries to
> > create an rt cache entry for every lookup.
> > Maybe we co
On Mon, 3 Jun 2019 22:27:28 +, Woodhouse, David wrote:
> On Mon, 2019-06-03 at 14:32 -0700, Jakub Kicinski wrote:
> > On Mon, 3 Jun 2019 17:43:18 +0300, same...@amazon.com wrote:
> > > * net: ena: ethtool: add extra properties retrieval via get_priv_flags
> > > (2/11):
> > > * replaced snp
From: Heiner Kallweit
Date: Mon, 3 Jun 2019 21:22:46 +0200
> This series contains the final steps to make firmware handling code
> ready to be factored out into a separate source code file.
Series applied, thanks.
When setting the bonding interface net device features,
the kernel code doesn't address the slaves' MPLS features
and doesn't inherit them.
Therefore, HW offloads that enhance performance such as
checksumming and TSO are disabled for MPLS tagged traffic
flowing via the bonding interface.
The patc
During the creation of the VLAN interface net device,
the various device features and offloads are being set based
on the parent device's features.
The code initiates the basic, vlan and encapsulation features
but doesn't address the MPLS features set and they remain blank.
As a result, all device
Netdevice HW MPLS features are not passed from device driver's netdevice to
upper netdevice, specifically VLAN and bonding netdevice which are created
by the kernel when needed.
This prevents enablement and usage of HW offloads, such as TSO and checksumming
for MPLS tagged traffic when running via
On 6/3/19 3:58 PM, Wei Wang wrote:
> Hmm... I am still a bit concerned with the ip6_create_rt_rcu() call.
> If we have a blackholed nexthop, the lookup code here always tries to
> create an rt cache entry for every lookup.
> Maybe we could reuse the pcpu cache logic for this? So we only create
> ne
On 6/3/19 12:09 PM, Wei Wang wrote:
>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>> index fada5a13bcb2..51cb5cb027ae 100644
>> --- a/net/ipv6/route.c
>> +++ b/net/ipv6/route.c
>> @@ -432,15 +432,21 @@ void fib6_select_path(const struct net *net, struct
>> fib6_result *res,
>> struct
On Fri, May 31, 2019 at 1:21 PM Andrii Nakryiko wrote:
>
> This patch adds support for a new way to define BPF maps. It relies on
> BTF to describe mandatory and optional attributes of a map, as well as
> captures type information of key and value naturally. This eliminates
> the need for BPF_ANNO
On Fri, May 31, 2019 at 3:29 PM Martin KaFai Lau wrote:
>
> This series has fixes when running reuseport's bpf_prog for udp lookup.
> If there is reuseport's bpf_prog, the common issue is the reuseport code
> path expects skb->data pointing to the transport header (udphdr here).
> A couple of comm
On Mon, 2019-06-03 at 11:51 +0200, Paolo Abeni wrote:
> On Fri, 2019-05-31 at 18:30 +, Saeed Mahameed wrote:
> > On Fri, 2019-05-31 at 14:53 +0200, Paolo Abeni wrote:
> > > Experimental results[1] has shown that resorting to several
> > > branches
> > > and a direct-call is faster than indirect
Hi!
This series cleans up and improves the tls code, mostly the offload
parts.
First a slight performance optimization - avoiding unnecessary re-
-encryption of records in patch 1. Next patch 2 makes the code
more resilient by checking for errors in skb_copy_bits(). Next
commit removes a warnin
tls_device_decrypted() is only called from decrypt_skb_update(),
when ctx->decrypted == false, there is no need to re-check the bit.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
net/tls/tls_device.c | 4
1 file changed, 4 deletions(-)
diff --git a/net/tls/tls_device.c
If strparser gets cornered into starting a new message from
an sk_buff which already has frags, it will allocate a new
skb to become the "wrapper" around the fragments of the
message.
This new skb does not inherit any metadata fields. In case
of TLS offload this may lead to unnecessarily re-encry
struct tls_context is slightly badly laid out. If we reorder things
right we can save 16 bytes (320 -> 304) but also make all fast path
data fit into two cache lines (one read only and one read/write,
down from four cache lines).
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
It's possible that TCP stack will decide to retransmit a packet
right when that packet's data gets acked, especially in presence
of packet reordering. This means that packets may be in flight,
even though tls_device code has already freed their record state.
Make fill_sg_in() and in turn tls_sw_fa
ctx->prot holds the same information as per-direction contexts.
Almost all code gets TLS version from this structure, convert
the last two stragglers, this way we can improve the cache
utilization by moving the per-direction data into cold cache lines.
Signed-off-by: Jakub Kicinski
Reviewed-by: D
If the RX config of a TLS socket is SW, there is no point iterating
over the fragments and checking if frame is decrypted. It will
always be fully encrypted. Note that in fully encrypted case
the function doesn't actually touch any offload-related state,
so it's safe to call for TLS_SW, today. S
From: Eric Dumazet
Date: Sun, 2 Jun 2019 11:24:18 -0700
> syzbot reported nasty use-after-free [1]
>
> Lets remove frag_list field from structs ip_fraglist_iter
> and ip6_fraglist_iter. This seens not needed anyway.
...
> Fixes: 0feca6190f88 ("net: ipv6: add skbuff fraglist splitter")
> Fixes:
In light of recent bugs, we should make a better effort of
checking return values. In theory none of the functions should
fail today.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
net/tls/tls_device.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(
All callers pass prot->version as the last parameter
of tls_advance_record_sn(), yet tls_advance_record_sn()
itself needs a pointer to prot. Pass prot from callers.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
include/net/tls.h| 10 +++---
net/tls/tls_device.c | 2
From: Russell King
Date: Sun, 02 Jun 2019 15:13:00 +0100
> Some SFP modules do not like reads longer than 16 bytes, so read the
> EEPROM in chunks of 16 bytes at a time. This behaviour is not specified
> in the SFP MSAs, which specifies:
>
> "The serial interface uses the 2-wire serial CMOS E2
From: Xin Long
Date: Sun, 2 Jun 2019 19:09:55 +0800
> sysctl setting bc_forwarding for $rp2 is needed when ping_test_from h2,
> otherwise the bc packets from $rp2 won't be forwarded. This patch is to
> add this setting for $rp2.
>
> Also, as ping_test_from does grep "$from" only, which could ma
From: Heiner Kallweit
Date: Sun, 2 Jun 2019 10:53:49 +0200
> Use paged versions of phylib MDIO access functions to simplify
> the code.
>
> Signed-off-by: Heiner Kallweit
Applied.
From: Eric Dumazet
Date: Fri, 31 May 2019 19:17:33 -0700
> this_cpu_read(*X) is slightly faster than *this_cpu_ptr(X)
>
> Signed-off-by: Eric Dumazet
Applied.
From: Eric Dumazet
Date: Fri, 31 May 2019 19:09:02 -0700
> this_cpu_read(*X) is faster than *this_cpu_ptr(X)
>
> Signed-off-by: Eric Dumazet
Applied.
From: Eric Dumazet
Date: Fri, 31 May 2019 18:11:25 -0700
> this_cpu_read(*X) is faster than *this_cpu_ptr(X)
>
> Signed-off-by: Eric Dumazet
Applied.
On Mon, Jun 3, 2019 at 9:32 AM Stanislav Fomichev wrote:
>
> On 05/31, Andrii Nakryiko wrote:
> > On Fri, May 31, 2019 at 2:28 PM Stanislav Fomichev wrote:
> > >
> > > On 05/31, Andrii Nakryiko wrote:
> > > > This patch adds support for a new way to define BPF maps. It relies on
> > > > BTF to de
ethtool_get_regs() allocates a buffer of size ops->get_regs_len(),
and pass it to the kernel driver via ops->get_regs() for filling.
There is no restriction about what the kernel drivers can or cannot do
with the open ethtool_regs structure. They usually set regs->version
and ignore regs->len or s
On Mon, 3 Jun 2019 21:41:43 +0100
Kevin Darbyshire-Bryant wrote:
> ctinfo is an action restoring data stored in conntrack marks to various
> fields. At present it has two independent modes of operation,
> restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack
> marks into packet
From: Saeed Mahameed
Date: Fri, 31 May 2019 20:09:19 +
> This series adds misc updates to mlx5 driver.
> For more information please see tag log below.
>
> Please pull and let me know if there is any problem.
>
> Please note that the series starts with a merge of mlx5-next branch,
> to reso
On Mon, Jun 3, 2019 at 1:42 PM David Ahern wrote:
>
> On 6/3/19 12:09 PM, Wei Wang wrote:
> >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> >> index fada5a13bcb2..51cb5cb027ae 100644
> >> --- a/net/ipv6/route.c
> >> +++ b/net/ipv6/route.c
> >> @@ -432,15 +432,21 @@ void fib6_select_path(cons
From: Eric Dumazet
Date: Fri, 31 May 2019 15:27:00 -0700
> In general, this_cpu_read(*X) is faster than *this_cpu_ptr(X)
>
> Also remove the inline attibute, totally useless.
>
> Signed-off-by: Eric Dumazet
> Cc: Kefeng Wang
Applied.
The axienet driver requires the use of an axistream-connected attribute,
but this isn't documented in the devicetree bindings. Document how this
attribute is supposed to be used, including the upcoming change to make
the usage of this attribute optional.
Signed-off-by: Robert Hancock
---
.../dev
These registers are important for troubleshooting the state of the DMA
cores.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
b/dri
It is possible that the interrupt handler fires and frees up space in
the TX ring in between checking for sufficient TX ring space and
stopping the TX queue in axienet_start_xmit. If this happens, the
queue wake from the interrupt handler will occur before the queue is
stopped, causing a lost wakeu
On some platforms, such as iMX6 with PCIe devices, crashes or hangs can
occur if the axienet device continues to perform DMA transfers after
parent devices/busses have been shut down. Shut down the axienet
interface during its shutdown callback in order to avoid this.
Signed-off-by: Robert Hancock
The MDIO bus for this driver was being named using the result of
of_address_to_resource on a node which may not have any resource on it,
but the return value of that call was not checked so it was using some
random value in the bus name. Change to name the MDIO bus based on the
resource start of th
This driver was casting skb pointers to u32 and storing them as such in
the DMA buffer descriptor, which is obviously broken on 64-bit. The area
of the buffer descriptor being used is not accessed by the hardware and
has sufficient room for a 32 or 64-bit pointer, so just store the skb
pointer as s
Since the MDIO is is brought up before the netdev is registered, it
should be torn down after the netdev is removed. Otherwise, PHY accesses
can potentially access freed MDIO bus references and cause a crash.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2
Convert this driver to use the phylink API rather than the legacy PHY
API. This allows for better support for SFP modules connected using a
1000BaseX or SGMII interface.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/Kconfig | 2 +-
drivers/net/ethernet/xilinx/xili
Failing initialization on a missing MAC address property is excessive.
We can just fall back to using a random MAC instead, which at least
leaves the interface in a functioning state.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 5 ++---
1 file changed, 2
Previously this driver only handled interrupts from the DMA RX and TX
blocks, not from the Ethernet core itself. Add optional support for
the Ethernet core interrupt, which is used to detect rx_missed and
framing errors signalled by the hardware. In order to use this
interrupt, a third interrupt ne
Specify IRQF_SHARED to support shared interrupts. If the interrupt
handler is called and the device is not indicating an interrupt,
just return IRQ_NONE rather than spewing error messages.
Signed-off-by: Robert Hancock
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 14 --
1
This is a series of enhancements and bug fixes in order to get the mainline
version of this driver into a more generally usable state, including on
x86 or ARM platforms. It also converts the driver to use the phylink API
in order to provide support for SFP modules.
Changes since v1:
-Split up som
The Xilinx DMA blocks each have their own reset register, but they both
reset the entire DMA engine, so only one of them needs to be reset.
Also, when stopping the device, we need to not just command the DMA
blocks to stop, but wait for them to stop, and trigger a device reset
to ensure that they
1 - 100 of 217 matches
Mail list logo
