Re: [PATCH iproute2 0/2] tc: flower: Support matching on SCTP ports

On Thu, 3 Nov 2016 13:26:39 +0100 Simon Horman wrote: > Hi, > > this short series adds support for matching on SCTP ports in the same way > that matching on TCP and UDP ports is already supported. It corresponds to > a net-next patch to add the same support to the kernel. > > Example usage: >

Re: [PATCH iproute2] tc: flower: Fix usage message

On Wed, 2 Nov 2016 17:09:58 +0200 Paul Blakey wrote: > Remove left over usage from removal of eth_type argument. > > Fixes: 488b41d020fb ('tc: flower no need to specify the ethertype') > Signed-off-by: Paul Blakey > --- Applied, thanks. Then I changed usage message to pass checkpatch long lin

Re: [PATCH v4] iproute2: macvlan: add "source" mode

On Thu, 27 Oct 2016 12:44:36 +0200 Michael Braun wrote: > Adjusting iproute2 utility to support new macvlan link type mode called > "source". > > Example of commands that can be applied: > ip link add link eth0 name macvlan0 type macvlan mode source > ip link set link dev macvlan0 type macvl

Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket

On Sat, 29 Oct 2016 22:20:19 +0300 Isaac Boukris wrote: > Abstract unix domain socket may embed null characters, > these should be translated to '@' when printed by ss the > same way the null prefix is currently being translated. > > Signed-off-by: Isaac Boukris Applied

Re: [PATCH iproute2] ip: update link types to show 6lowpan and ieee802.15.4 monitor

On Fri, 28 Oct 2016 11:42:03 +0200 Stefan Schmidt wrote: > Both types have been missing here and thus ip always showed > only the numbers. > > Based on a suggestion from Alexander Aring. > > Signed-off-by: Stefan Schmidt Applied

Re: [PATCH net-next] bpf: fix range arithmetic for bpf map access

On Fri, Nov 11, 2016 at 04:47:39PM -0500, Josef Bacik wrote: > I made some invalid assumptions with BPF_AND and BPF_MOD that could result in > invalid accesses to bpf map entries. Fix this up by doing a few things > > 1) Kill BPF_MOD support. This doesn't actually get used by the compiler in >

Re: TCP performance problems - GSO/TSO, MSS, 8139cp related

From: Russell King - ARM Linux Date: Fri, 11 Nov 2016 22:33:08 + > "The new buffer management algorithm provides capabilities of Microsoft > Large-Send offload" and as yet I haven't found anything that describes > what this is or how it works. For once I will give Microsoft a big shout out h

Re: Source address fib invalidation on IPv6

Hi David, On Fri, Nov 11, 2016 at 11:14 PM, David Ahern wrote: > What do you mean by 'valid dst'? ipv6 returns net->ipv6.ip6_null_entry on > lookup failures so yes dst is non-NULL but that does not mean the lookup > succeeded. What I mean is that it returns an ordinary dst, as if that souce ad

Re: Long delays creating a netns after deleting one (possibly RCU related)

On Fri, Nov 11, 2016 at 4:23 PM, Paul E. McKenney wrote: > > Ah! This net_mutex is different than RTNL. Should synchronize_net() be > modified to check for net_mutex being held in addition to the current > checks for RTNL being held? > Good point! Like commit be3fc413da9eb17cce0991f214ab0, che

Re: Long delays creating a netns after deleting one (possibly RCU related)

On Fri, Nov 11, 2016 at 01:11:01PM +, Rolf Neugebauer wrote: > On Thu, Nov 10, 2016 at 9:24 PM, Paul E. McKenney > wrote: > > On Thu, Nov 10, 2016 at 09:37:47AM -0800, Cong Wang wrote: > >> (Cc'ing Paul) > >> > >> On Wed, Nov 9, 2016 at 7:42 AM, Rolf Neugebauer > >> wrote: > >> > Hi > >> > >

Re: [PATCH net-next v2 2/7] vxlan: simplify exception handling

On Fri, Nov 11, 2016 at 3:14 AM, Jiri Benc wrote: > On Thu, 10 Nov 2016 11:21:19 -0800, Pravin Shelar wrote: >> One additional variable is not bad but look at what has happened in >> vxlan_xmit_one(). There are already more than 20 variables defined. It >> is hard to read code in this case. > > I

Re: TCP performance problems - GSO/TSO, MSS, 8139cp related

On Fri, Nov 11, 2016 at 09:23:43PM +, David Woodhouse wrote: > It's also *fairly* unlikely that the kernel in the guest has developed > a bug and isn't setting gso_size sanely. I'm more inclined to suspect > that qemu isn't properly emulating those bits. But at first glance at > the code, it lo

Re: TCP performance problems - GSO/TSO, MSS, 8139cp related

On Fri, Nov 11, 2016 at 09:23:43PM +, David Woodhouse wrote: > On Fri, 2016-11-11 at 21:05 +, Russell King - ARM Linux wrote: > > > > 18:59:38.782818 IP (tos 0x0, ttl 52, id 35619, offset 0, flags [DF], proto > > TCP (6), length 60) > >     84.xx.xxx.196.61236 > 195.92.253.2.http: Flags [

[PATCH] net: alx: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/atheros/alx/ethtool.c | 59 --- 1 files changed, 35 insertions(+), 24 deletions(-) diff --git a/drivers/ne

Re: Source address fib invalidation on IPv6

On 11/11/16 12:29 PM, Jason A. Donenfeld wrote: > Hi folks, > > If I'm replying to a UDP packet, I generally want to use a source > address that's the same as the destination address of the packet to > which I'm replying. For example: > > Peer A sends packet: src = 10.0.0.1, dst = 10.0.0.3 > Pee

[PATCH net-next] bpf: fix range arithmetic for bpf map access

I made some invalid assumptions with BPF_AND and BPF_MOD that could result in invalid accesses to bpf map entries. Fix this up by doing a few things 1) Kill BPF_MOD support. This doesn't actually get used by the compiler in real life and just adds extra complexity. 2) Fix the logic for BPF_AND,

Re: TCP performance problems - GSO/TSO, MSS, 8139cp related

On Fri, 2016-11-11 at 21:05 +, Russell King - ARM Linux wrote: > > 18:59:38.782818 IP (tos 0x0, ttl 52, id 35619, offset 0, flags [DF], proto > TCP (6), length 60) >     84.xx.xxx.196.61236 > 195.92.253.2.http: Flags [S], cksum 0x88db > (correct), seq 158975430, win 29200, options [mss 1452,

do bridge members need to be listed in /proc/net/dev_mcast

Hi. I have a Linux router running 3.18.23 with IPv6 as well as IPv4 interfaces.  It doesn't seem to be hearing IPv6 multicast packets though. For example, it won't hear and respond to either router or neighbour discovery packets unless i put the interface in promiscuous mode with tcpdump.  I'm a

TCP performance problems - GSO/TSO, MSS, 8139cp related

Hi, I seem to have found a severe performance issue somewhere in the networking code. This involves ZenIV.linux.org.uk, which is a qemu-kvm guest instance on ZenV, which is configured to use macvtap for ZenIV to gain its network access, with ZenIV using the 8139cp driver. My initial testing was

Re: [PATCH v2 1/6] qed: Add support for hardware offloaded iSCSI.

On Fri, 11 Nov 2016, 7:57am, Hannes Reinecke wrote: > On 11/08/2016 07:56 AM, Manish Rangankar wrote: > > From: Yuval Mintz > > > > This adds the backbone required for the various HW initalizations > > which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ > > 4 line of adapters

[RFC PATCH net-next] net: ethtool: add support for forward error correction modes

N.B. Sorry I'm not able to respond to the original message since I wasn't subscribed to netdev when it was sent a couple of weeks ago. This feature is something that Chelsio's cxgb4 driver needs. As we've tested our adapters against a number of switches, we've discovered a few which use varying d

[PATCH] icmp: Restore resistence to abnormal messages

Restore network resistance to abnormal ICMP fragmentation needed messages with next hop MTU equal to (or exceeding) dropped packet size Fixes: 46517008e116 ("ipv4: Kill ip_rt_frag_needed().") Signed-off-by: Vicente Jimenez Aguilar --- net/ipv4/icmp.c | 7 +++ 1 file changed, 7 insertions(+)

Source address fib invalidation on IPv6

Hi folks, If I'm replying to a UDP packet, I generally want to use a source address that's the same as the destination address of the packet to which I'm replying. For example: Peer A sends packet: src = 10.0.0.1, dst = 10.0.0.3 Peer B replies with: src = 10.0.0.3, dst = 10.0.0.1 But let's comp

Re: [net-next PATCH] net: dummy: Introduce dummy virtual functions

Hi Phil, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Phil-Sutter/net-dummy-Introduce-dummy-virtual-functions/20161112-013558 config: m68k-sun3_defconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce: wget https://git

Re: [net-next PATCH] net: dummy: Introduce dummy virtual functions

Hi Phil, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Phil-Sutter/net-dummy-Introduce-dummy-virtual-functions/20161112-013558 config: xtensa-common_defconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https

Re: [PATCH] bpf: fix range arithmetic for bpf map access

On 11/11/2016 11:36 AM, Jann Horn wrote: On Fri, Nov 11, 2016 at 1:18 AM, Josef Bacik wrote: --- Sorry Jann, I saw your response last night and then promptly forgot about it, here's the git-send-email version. --- A note: This doesn't seem to apply cleanly to current net-next (or I'm too stup

[PATCH iproute2 v1 1/2] iproute2: avoid exit in case of error.

Be consistent with how non-0 print_route() return values are handled elesewhere: return -1. --- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index 98bfad6..dae793b 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -1743,7 +1743,7 @@ s

[PATCH iproute2 v1 2/2] iproute2: a non-expected rtnl message is an error

--- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index dae793b..10d0afe 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -320,7 +320,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) if (n->nl

[PATCH v2 net-next 6/6] bpf: Add tests for the LRU bpf_htab

This patch has some unit tests and a test_lru_dist. The test_lru_dist reads in the numeric keys from a file. The files used here are generated by a modified fio-genzipf tool originated from the fio test suit. The sample data file can be found here: https://github.com/iamkafai/bpf-lru The zipf.*

[PATCH v2 net-next 3/6] bpf: Refactor codes handling percpu map

Refactor the codes that populate the value of a htab_elem in a BPF_MAP_TYPE_PERCPU_HASH typed bpf_map. Signed-off-by: Martin KaFai Lau --- kernel/bpf/hashtab.c | 47 +-- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/kernel/bpf/hashtab

[PATCH v2 net-next 4/6] bpf: Add BPF_MAP_TYPE_LRU_HASH

Provide a LRU version of the existing BPF_MAP_TYPE_HASH. Signed-off-by: Martin KaFai Lau --- include/uapi/linux/bpf.h | 8 ++ kernel/bpf/hashtab.c | 266 --- 2 files changed, 260 insertions(+), 14 deletions(-) diff --git a/include/uapi/linux/bpf

[PATCH v2 net-next 5/6] bpf: Add BPF_MAP_TYPE_LRU_PERCPU_HASH

Provide a LRU version of the existing BPF_MAP_TYPE_PERCPU_HASH Signed-off-by: Martin KaFai Lau --- include/uapi/linux/bpf.h | 3 +- kernel/bpf/hashtab.c | 129 --- kernel/bpf/syscall.c | 8 ++- 3 files changed, 131 insertions(+), 9 deletion

[PATCH v2 net-next 1/6] bpf: LRU List

Introduce bpf_lru_list which will provide LRU capability to the bpf_htab in the later patch. * General Thoughts: 1. Target use case. Read is more often than update. (i.e. bpf_lookup_elem() is more often than bpf_update_elem()). If bpf_prog does a bpf_lookup_elem() first and then an in-place

[PATCH v2 net-next 0/6] bpf: LRU map

Hi, This patch set adds LRU map implementation to the existing BPF map family. The first few patches introduce the basic BPF LRU list implementation. The later patches introduce the LRU versions of the existing BPF_MAP_TYPE_LRU_[PERCPU_]HASH maps by leveraging the BPF LRU list. v2: - Added a pe

[PATCH v2 net-next 2/6] bpf: Add percpu LRU list

Instead of having a common LRU list, this patch allows a percpu LRU list which can be selected by specifying a map attribute. The map attribute will be added in the later patch. While the common use case for LRU is #reads >> #updates, percpu LRU list allows bpf prog to absorb unusual #updates und

[Patch net-next] net: fix sleeping for sk_wait_event()

Similar to commit 14135f30e33c ("inet: fix sleeping inside inet_wait_for_connect()"), sk_wait_event() needs to fix too, because release_sock() is blocking, it changes the process state back to running after sleep, which breaks the previous prepare_to_wait(). Switch to the new wait API. Cc: Eric

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

On 10/27/2016 10:26 AM, Eric Dumazet wrote: > On Wed, 2016-10-26 at 11:09 +1100, Jon Maxwell wrote: >> We recently encountered a bug where a few customers using ibmveth on the >> same LPAR hit an issue where a TCP session hung when large receive was >> enabled. Closer analysis revealed that the se

Re: [patch net-next 5/8] Introduce sample tc action

From: John Fastabend Date: Fri, 11 Nov 2016 06:52:31 -0800 > On 16-11-11 04:43 AM, Simon Horman wrote: >> On Fri, Nov 11, 2016 at 08:28:50AM +, Yotam Gigi wrote: >> >> ... >> >>> John, as a result of your question I realized that our hardware does do >>> randomized sampling that I was not a

Re: [PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

On Fri, Nov 11, 2016 at 6:02 AM, Baoquan He wrote: > On 11/11/16 at 09:46pm, Baoquan He wrote: >> Hi bnx2 experts, >> >> In commit 3e1be7a ("bnx2: Reset device during driver initialization"), >> firmware requesting code was moved from open stage to probe stage. >> The reason is in kdump kernel har

[net-next PATCH] net: dummy: Introduce dummy virtual functions

The idea for this was born when testing VF support in iproute2 which was impeded by hardware requirements. In fact, not every VF-capable hardware driver implements all netdev ops, so testing the interface is still hard to do even with a well-sorted hardware shelf. To overcome this and allow for te

wl1251 & mac address & calibration data

Hi! I will open discussion about mac address and calibration data for wl1251 wireless chip again... Problem: Mac address & calibration data for wl1251 chip on Nokia N900 are stored on second nand partition (mtd1) in special proprietary format which is used only for Nokia N900 (probably on N8x0

RE: [patch net-next 5/8] Introduce sample tc action

>-Original Message- >From: Simon Horman [mailto:simon.hor...@netronome.com] >Sent: Friday, November 11, 2016 2:44 PM >To: Yotam Gigi >Cc: John Fastabend ; Jiri Pirko ; >netdev@vger.kernel.org; da...@davemloft.net; Ido Schimmel >; Elad Raz ; Nogah Frankel >; Or Gerlitz ; >j...@mojatatu.com;

Re: [PATCH v2 5/6] qedi: Add support for iSCSI session management.

On 11/08/2016 07:57 AM, Manish Rangankar wrote: This patch adds support for iscsi_transport LLD Login, Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing and Firmware async event handling support. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Si

[PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure

This structure was mapped but never subsequently unmapped. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index f6c9b6d..921c40f 100644 --- a/drive

[PATCH net 2/2] ibmvnic: Fix size of debugfs name buffer

This mistake was causing debugfs directory creation failures when multiple ibmvnic devices were probed. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethern

Re: [PATCH v2 6/6] qedi: Add support for data path.

On 11/08/2016 07:57 AM, Manish Rangankar wrote: This patch adds support for data path and TMF handling. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap Signed-off-by: Arun Easi Signed-off-by: Manish Rangankar --- dr

Re: [PATCH v2 4/6] qedi: Add LL2 iSCSI interface for offload iSCSI.

On 11/08/2016 07:57 AM, Manish Rangankar wrote: This patch adds support for iscsiuio interface using Light L2 (LL2) qed interface. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap Signed-off-by: Arun Easi Signed-off-by

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

On 11/08/2016 07:57 AM, Manish Rangankar wrote: The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module for 41000 Series Converged Network Adapters by QLogic. This patch consists of following changes: - MAINTAINERS Makefile and Kconfig changes for qedi, - PCI driver registra

Re: [PATCH] bpf: fix range arithmetic for bpf map access

On Fri, Nov 11, 2016 at 1:18 AM, Josef Bacik wrote: > --- > Sorry Jann, I saw your response last night and then promptly forgot about it, > here's the git-send-email version. > --- A note: This doesn't seem to apply cleanly to current net-next (or I'm too stupid to use "git am"), so I'm applying

Re: [PATCH 2/3] vhost: better detection of available buffers

On Fri, Nov 11, 2016 at 12:18:50PM +0800, Jason Wang wrote: > > > On 2016年11月11日 11:41, Michael S. Tsirkin wrote: > > On Fri, Nov 11, 2016 at 10:18:37AM +0800, Jason Wang wrote: > > > > > > > > > > > >On 2016年11月10日 03:57, Michael S. Tsirkin wrote: > > > > > >On Wed, Nov 09, 2016 at 03:38:32PM +0

Re: [PATCH 1/3] tuntap: rx batching

On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: > > > On 2016年11月11日 12:17, John Fastabend wrote: > > On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: > > > >On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: > > > > >> > > > > >> > > > > >>On 2016年11月10日 00:38, Michael S. Tsi

Re: [PATCH net-next] sfc: clear napi_hash state when copying channels

Apologies, this was meant for net, not net-next. Shall I resubmit? Bert.

Re: [PATCH v2 2/6] qed: Add iSCSI out of order packet handling.

On 11/08/2016 07:56 AM, Manish Rangankar wrote: From: Yuval Mintz This patch adds out of order packet handling for hardware offloaded iSCSI. Out of order packet handling requires driver buffer allocation and assistance. Signed-off-by: Arun Easi Signed-off-by: Yuval Mintz --- drivers/net/eth

Re: [PATCH v2 1/6] qed: Add support for hardware offloaded iSCSI.

On 11/08/2016 07:56 AM, Manish Rangankar wrote: From: Yuval Mintz This adds the backbone required for the various HW initalizations which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun E

[PATCH net-next] sfc: clear napi_hash state when copying channels

efx_copy_channel() doesn't correctly clear the napi_hash related state. This means that when napi_hash_add is called for that channel nothing is done, and we are left with a copy of the napi_hash_node from the old channel. When we later call napi_hash_del() on this channel we have a stale napi_hash

[patch net v2 1/2] mlxsw: spectrum: Fix refcount bug on span entries

From: Yotam Gigi When binding port to a newly created span entry, its refcount is initialized to zero even though it has a bound port. That leads to unexpected behaviour when the user tries to delete that port from the span entry. Fix this by initializing the reference count to 1. Also add a wa

[patch net v2 2/2] mlxsw: spectrum_router: Correctly dump neighbour activity

From: Arkadi Sharshevsky The device's neighbour table is periodically dumped in order to update the kernel about active neighbours. A single dump session may span multiple queries, until the response carries less records than requested or when a record (can contain up to four neighbour entries) i

[patch net v2 0/2] mlxsw: Couple of fixes

From: Jiri Pirko Please, queue-up both for stable. Thanks! --- v1->v2: - patch 1: - fix this rather by initializing refcount to 1 - fix typo in description - patch 2: - remove an extra space - fix the description Arkadi Sharshevsky (1): mlxsw: spectrum_router: Correctly dump neighbour act

[PATCH] net: ioctl SIOCSIFADDR minor cleanup

From: yuan linyu 1. set interface address label to ioctl request device name is enough 2. when address pass inet_abc_len check, prefixlen less than 31 is always true Signed-off-by: yuan linyu ---  net/ipv4/devinet.c | 8 ++--  1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net

Re: [patch net-next 5/8] Introduce sample tc action

On 16-11-11 04:43 AM, Simon Horman wrote: > On Fri, Nov 11, 2016 at 08:28:50AM +, Yotam Gigi wrote: > > ... > >> John, as a result of your question I realized that our hardware does do >> randomized sampling that I was not aware of. I will use the extensibility of >> the API and implement a r

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

On 10.11.2016 13:22, Oliver Neukum wrote: On Thu, 2016-11-10 at 12:09 +0100, Bjørn Mork wrote: Kai-Heng Feng writes: On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: Oliver Neukum writes: On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: These problems could very well be caused by r

Re: AF_VSOCK loopback

Hi Stefan, All datagram communication in VMCI based AF_VSOCK is going through the host - also for loopback communication. The only difference wrt loopback is that the VMCI queue pairs implementing the shared queues for the stream protocols aren't registered with the hypervisor - they are create

[PATCH] net: ethernet: ti: davinci_cpdma: don't stop ctlr if it was stopped

No need to stop ctlr if it was already stopped. It can cause timeout warns. Steps: - ifconfig eth0 down - ethtool -l eth0 rx 8 tx 8 - ethtool -l eth0 rx 1 tx 1 Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- 1 file changed, 1 insertio

Re: [PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

On 11/11/16 at 09:46pm, Baoquan He wrote: > Hi bnx2 experts, > > In commit 3e1be7a ("bnx2: Reset device during driver initialization"), > firmware requesting code was moved from open stage to probe stage. > The reason is in kdump kernel hardware iommu need device be reset in > driver probe stage,

Re: [PATCH 1/2] Revert "bnx2: Reset device during driver initialization"

Dear Baoquan, On 11/11/16 14:46, Baoquan He wrote: This reverts commit 3e1be7ad2d38c6bd6aeef96df9bd0a7822f4e51c. Thanks a lot. When people build bnx2 driver into kernel, it will fail to detect and load firmware because firmware is contained in initramfs and initramfs has not been uncompress

[PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

Hi bnx2 experts, In commit 3e1be7a ("bnx2: Reset device during driver initialization"), firmware requesting code was moved from open stage to probe stage. The reason is in kdump kernel hardware iommu need device be reset in driver probe stage, otherwise those in-flight DMA from 1st kernel will con

[PATCH 2/2] bnx2: Hard reset bnx2 chip at probe stage

In commit 3e1be7a ("bnx2: Reset device during driver initialization"), firmware requesting code was moved to driver probe stage, into function bnx2_init_one. But if bnx2 driver is build into kernel, it will fail to request firmware because firmware is contained in initramfs, but initramfs has not b

[PATCH 1/2] Revert "bnx2: Reset device during driver initialization"

This reverts commit 3e1be7ad2d38c6bd6aeef96df9bd0a7822f4e51c. When people build bnx2 driver into kernel, it will fail to detect and load firmware because firmware is contained in initramfs and initramfs has not been uncompressed yet during do_initcalls. So revert commit 3e1be7a and work out a new

[PATCH v2] net: ethernet: ti: davinci_cpdma: fix fixed prio cpdma ctlr configuration

The dma ctlr is reseted to 0 while cpdma soft reset, thus cpdma ctlr cannot be configured after cpdma is stopped. So restoring content of cpdma ctlr while off/on procedure is needed. The cpdma ctlr off/on procedure is present while interface down/up and while changing number of channels with ethtoo

Hopefully

Hi friend I am a banker in ADB BANK. I want to transfer an abandoned $25.5Million to your Bank account. 40/percent will be your share. No risks involved but keep it as secret. Contact me for more details And also acknowledge receipt of this message in acceptance of my mutual business Endeavour by f

[PATCH] vhost/scsi: Remove unused but set variable

Remove the unused but set variable se_tpg in vhost_scsi_nexus_cb() to fix the following GCC warning when building with 'W=1': drivers/vhost/scsi.c:1752:26: warning: variable ‘se_tpg’ set but not used Signed-off-by: Tobias Klauser --- drivers/vhost/scsi.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH] vhost/vsock: Remove unused but set variable

Remove the unused but set variable vq in vhost_transport_send_pkt() to fix the following GCC warning when building with 'W=1': drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used Signed-off-by: Tobias Klauser --- drivers/vhost/vsock.c | 3 --- 1 file changed, 3 deletions(-)

[iproute PATCH 10/18] ss: Make user_ent_hash_build_init local to user_ent_hash_build()

By having it statically defined, there is no need for it to be global. Signed-off-by: Phil Sutter --- misc/ss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 477910a842726..3e5c93bb7c6f9 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -99,8 +99,6 @@

[iproute PATCH 17/18] ss: Make sstate_namel local to scan_state()

Signed-off-by: Phil Sutter --- misc/ss.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 14492da256c61..6e669f7b0593c 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -634,21 +634,6 @@ static unsigned long long cookie_sk_get

Re: [patch net 2/2] mlxsw: spectrum_router: Correctly dump neighbour activity

Fri, Nov 11, 2016 at 01:54:05PM CET, ido...@idosch.org wrote: >On Fri, Nov 11, 2016 at 11:20:42AM +0100, Jiri Pirko wrote: >> From: Arkadi Sharshevsky >> >> During neighbour activity check the device's table is dumped by multiple >> query requests. The query session should end when the response c

[iproute PATCH 14/18] ss: Get rid of single-fielded struct snmpstat

A struct with only a single field does not make much sense. Besides that, it was used by print_summary() only. Signed-off-by: Phil Sutter --- misc/ss.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index b06b9e6fa9884..85fc6096a986f 100644 -

Re: Long delays creating a netns after deleting one (possibly RCU related)

On Thu, Nov 10, 2016 at 9:24 PM, Paul E. McKenney wrote: > On Thu, Nov 10, 2016 at 09:37:47AM -0800, Cong Wang wrote: >> (Cc'ing Paul) >> >> On Wed, Nov 9, 2016 at 7:42 AM, Rolf Neugebauer >> wrote: >> > Hi >> > >> > We noticed some long delays starting docker containers on some newer >> > kernel

Re: [patch net 1/2] mlxsw: spectrum: Fix refcount bug on span entries

Fri, Nov 11, 2016 at 01:49:28PM CET, ido...@idosch.org wrote: >On Fri, Nov 11, 2016 at 11:20:41AM +0100, Jiri Pirko wrote: >> From: Yotam Gigi >> >> When binding port to a newly created span entry, its refcount is set 0 >> even though it has a bound port. That leeds to unexpected behaviour when >

[iproute PATCH 02/18] ss: Drop empty lines in UDP output

When dumping UDP sockets and show_tcpinfo (-i) is active but not show_mem (-m), print_tcpinfo() does not output anything leading to an empty line being printed after every socket. Fix this by skipping the call to print_tcpinfo() and the previous newline printing in that case. Signed-off-by: Phil S

[iproute PATCH 13/18] ss: Get rid of useless goto in handle_follow_request()

Signed-off-by: Phil Sutter --- misc/ss.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index c3a5148e05013..b06b9e6fa9884 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3443,7 +3443,7 @@ static int generic_show_sock(const struct sockaddr_nl *addr,

[iproute PATCH 07/18] ss: Eliminate unix_use_proc()

This function is used only at a single place anymore, so replace the call to it by it's content, which makes that specific part of unix_show() consistent with e.g. tcp_show(). Signed-off-by: Phil Sutter --- misc/ss.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/mis

[iproute PATCH 03/18] ss: Add missing tab when printing UNIX details

When dumping UNIX sockets and show_details is active but not show_mem (ss -xne), the socket details are printed without being prefixed by tab. Fix this by printing the tab character when either one of '-e' or '-m' has been specified. Signed-off-by: Phil Sutter --- misc/ss.c | 4 ++-- 1 file chan

[iproute PATCH 15/18] ss: Make unix_state_map local to unix_show()

Also make it const, since there won't be any write access happening. Signed-off-by: Phil Sutter --- misc/ss.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 85fc6096a986f..cf4187310816e 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -2727,9 +2727,

[iproute PATCH 16/18] ss: Make sstate_name local to sock_state_print()

Signed-off-by: Phil Sutter --- misc/ss.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index cf4187310816e..14492da256c61 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -634,21 +634,6 @@ static unsigned long long cookie_sk_get

[iproute PATCH 11/18] ss: Make some variables function-local

addrp_width and screen_width are used in main() only, so no need to have them globally available. Signed-off-by: Phil Sutter --- misc/ss.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 3e5c93bb7c6f9..d546a00eb2c24 100644 --- a/misc/ss.c +++ b/

[iproute PATCH 08/18] ss: Turn generic_proc_open() wrappers into macros

Signed-off-by: Phil Sutter --- misc/ss.c | 89 ++- 1 file changed, 19 insertions(+), 70 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 8e021731cf71c..e9fecd39a8493 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -306,76 +306,25 @@ stat

[iproute PATCH 06/18] ss: Drop list traversal from unix_stats_print()

Although this complicates the dedicated procfs-based code path in unix_show() a bit, it's the only sane way to get rid of unix_show_sock() output diverging from other socket types in that it prints all socket details in a new line. As a side effect, it allows to eliminate all procfs specific code

[iproute PATCH 18/18] ss: unix_show: No need to initialize members of calloc'ed structs

Signed-off-by: Phil Sutter --- misc/ss.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 6e669f7b0593c..1e3ccf28c4e84 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -2877,8 +2877,6 @@ static int unix_show(struct filter *f) if (!(u = calloc(1, sizeof(*

[iproute PATCH 00/18] ss: Minor code review

This is a series of misc changes to ss code which happened as fall-out when working on a unified output formatter (still unfinished). Phil Sutter (18): ss: Mark fall through in arg parsing switch() ss: Drop empty lines in UDP output ss: Add missing tab when printing UNIX details ss: Use so

[iproute PATCH 09/18] ss: Make tmr_name local to tcp_timer_print()

It's used only there, so no need to have it globally defined. Signed-off-by: Phil Sutter --- misc/ss.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index e9fecd39a8493..477910a842726 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -830,15

[iproute PATCH 01/18] ss: Mark fall through in arg parsing switch()

As there is a certain chance of overlooking this, better add a comment to draw readers' attention. Signed-off-by: Phil Sutter --- misc/ss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/ss.c b/misc/ss.c index dd77b8153b6da..c20bfbdb01c62 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -4025

[iproute PATCH 05/18] ss: introduce proc_ctx_print()

This consolidates identical code in three places. While the function name is not quite perfect as there is different proc_ctx printing code in netlink_show_one() as well, I sadly didn't find a more suitable one. Signed-off-by: Phil Sutter --- misc/ss.c | 49 ++

[iproute PATCH 04/18] ss: Use sockstat->type in all socket types

Unix sockets used that field already to hold info about the socket type. By replicating this approach in all other socket types, we can get rid of protocol parameter in inet_stats_print() and have sock_state_print() figure things out by itself. Signed-off-by: Phil Sutter --- misc/ss.c | 124

[iproute PATCH 12/18] ss: Make slabstat_ids local to get_slabstat()

Signed-off-by: Phil Sutter --- misc/ss.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index d546a00eb2c24..c3a5148e05013 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -580,21 +580,19 @@ struct slabstat { static struct slabstat slabstat;

Re: BUG() can be hit in tcp_collapse()

Hello, Eric, > Another sk_filter() is used in tcp v6. > So the correct patch would be : Thank you much for your research. I'm happy my report has resulted as the proposed patch. Best regards, Vladis Dronov | Red Hat, Inc. | Product Security Engineer

Re: [patch net 2/2] mlxsw: spectrum_router: Correctly dump neighbour activity

On Fri, Nov 11, 2016 at 11:20:42AM +0100, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > During neighbour activity check the device's table is dumped by multiple > query requests. The query session should end when the response carries > less records than requested or when a given record is not

[PATCH] netfilter: x_tables: simplify IS_ERR_OR_NULL to NULL test

Since commit 7926dbfa4bc1 ("netfilter: don't use mutex_lock_interruptible()"), the function xt_find_table_lock can only return NULL on an error. Simplify the call sites and update the comment before the function. The semantic patch that change the code is as follows: (http://coccinelle.lip6.fr/)

Re: [patch net 1/2] mlxsw: spectrum: Fix refcount bug on span entries

On Fri, Nov 11, 2016 at 11:20:41AM +0100, Jiri Pirko wrote: > From: Yotam Gigi > > When binding port to a newly created span entry, its refcount is set 0 > even though it has a bound port. That leeds to unexpected behaviour when s/leeds/leads/ > the user tries to delete that port from the span

Re: [patch net-next 5/8] Introduce sample tc action

On Fri, Nov 11, 2016 at 08:28:50AM +, Yotam Gigi wrote: ... > John, as a result of your question I realized that our hardware does do > randomized sampling that I was not aware of. I will use the extensibility of > the API and implement a random keyword, that will be offloaded in our > hardwa

[PATCH v2] net: ethernet: ti: davinci_cpdma: free memory while channel destroy

While create/destroy channel operation memory is not freed. It was supposed that memory is freed while driver remove. But a channel can be created and destroyed many times while changing number of channels with ethtool. Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk --- Based on

  1   2   >