>-----Original Message----- >From: Simon Horman [mailto:simon.hor...@netronome.com] >Sent: Friday, November 11, 2016 2:44 PM >To: Yotam Gigi <yot...@mellanox.com> >Cc: John Fastabend <john.fastab...@gmail.com>; Jiri Pirko <j...@resnulli.us>; >netdev@vger.kernel.org; da...@davemloft.net; Ido Schimmel ><ido...@mellanox.com>; Elad Raz <el...@mellanox.com>; Nogah Frankel ><nog...@mellanox.com>; Or Gerlitz <ogerl...@mellanox.com>; >j...@mojatatu.com; geert+rene...@glider.be; step...@networkplumber.org; >xiyou.wangc...@gmail.com; li...@roeck-us.net; ro...@cumulusnetworks.com >Subject: Re: [patch net-next 5/8] Introduce sample tc action > >On Fri, Nov 11, 2016 at 08:28:50AM +0000, Yotam Gigi wrote: > >... > >> John, as a result of your question I realized that our hardware does do >> randomized sampling that I was not aware of. I will use the extensibility of >> the API and implement a random keyword, that will be offloaded in our >> hardware. Those changes will be sent on v2. >> >> Eventually, your question was very relevant :) Thanks! > >Perhaps I am missing the point but why not just make random the default and >implement the inverse as an extension if it turns out to be needed in >future?
It makes sense. It does seem to me that the average user does prefer random sampling over deterministic one. We will consider that. Thanks for the comment!
