Fri, Nov 11, 2016 at 01:49:28PM CET, ido...@idosch.org wrote:
>On Fri, Nov 11, 2016 at 11:20:41AM +0100, Jiri Pirko wrote:
>> From: Yotam Gigi <yot...@mellanox.com>
>>
>> When binding port to a newly created span entry, its refcount is set 0
>> even though it has a bound port. That leeds to unexpected behaviour when
>
>s/leeds/leads/
>
>> the user tries to delete that port from the span entry.
>>
>> Change the binding process to increase the refcount of the bound entry
>> even if the entry is newly created, and add warning on the process of
>> removing bound port from entry when its refcount is 0.
>>
>> Fixes: 763b4b70afcd3 ("mlxsw: spectrum: Add support in matchall mirror TC
>> offloading")
>
>You only need the first 12 characters.
>
>> Signed-off-by: Yotam Gigi <yot...@mellanox.com>
>> Signed-off-by: Jiri Pirko <j...@mellanox.com>
>> ---
>> drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
>> b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
>> index 1ec0a4c..d75c1ff 100644
>> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
>> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
>> @@ -269,17 +269,18 @@ static struct mlxsw_sp_span_entry
>> struct mlxsw_sp_span_entry *span_entry;
>>
>> span_entry = mlxsw_sp_span_entry_find(port);
>> - if (span_entry) {
>> - span_entry->ref_count++;
>> - return span_entry;
>> - }
>> + if (!span_entry)
>> + span_entry = mlxsw_sp_span_entry_create(port);
>>
>> - return mlxsw_sp_span_entry_create(port);
>> + span_entry->ref_count++;
>
>mlxsw_sp_span_entry_create() can return NULL. You can look at
>mlxsw_sp_fib_entry_get() for reference.
Right, missed that. Will fix. Thanks.
