[Lldb-commits] [PATCH] D40745: Add a clang-ast subcommand to lldb-test

davide added subscribers: vsk, aprantl. davide added a comment. I really like this approach. I think it's going to expose a large amount of bugs, and probably facilitate the transition in case we want to move to the LLVM readers for this. @aprantl / @vsk , what do you think? https://reviews.ll

[Lldb-commits] [PATCH] D40745: Add a clang-ast subcommand to lldb-test

davide added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2764-2765 switch (reloc_type(rel)) { case R_386_32: case R_386_PC32: default: It's unclear to me why PC-rel and 32-bit abs rel are not handl

[Lldb-commits] [PATCH] D40757: Disable warnings related to anonymous types

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, I stumbled upon the same issue :) An alternative would be that of naming (as you suggested), but if this is consistent, no worries. https://reviews.llvm.org/D40757 __

[Lldb-commits] [PATCH] D40757: Disable warnings related to anonymous types in the ObjC plugin

davide added a comment. LGTM (again) https://reviews.llvm.org/D40757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D41008: MainLoop: avoid infinite loop when pty slave gets closed

davide added subscribers: jingham, davide. davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. @jingham ? I'll try this change on macOS to make sure it won't break anything. https://reviews.llvm.org/D41008

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

davide added a comment. In https://reviews.llvm.org/D40616#951256, @labath wrote: > @davide: Any thoughts on `.yaml` as a test file suffix? I think this is fine. https://reviews.llvm.org/D40616 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D41101: [testsuite] Remove testing failures vestiges

This revision was automatically updated to reflect the committed changes. Closed by commit rL320444: [testsuite] Remove testing failures vestiges. (authored by davide). Changed prior to commit: https://reviews.llvm.org/D41101?vs=126478&id=126479#toc Repository: rL LLVM https://reviews.llvm.

[Lldb-commits] [PATCH] D41169: ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D41169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D41427: [lldb] Fix crash when parsing the type of a function without any arguments

davide added a comment. Indeed, this needs to be tested. Repository: rL LLVM https://reviews.llvm.org/D41427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D41824: Remove use of private header in LLDB

davide added a comment. Opened https://bugs.llvm.org/show_bug.cgi?id=35857 Repository: rL LLVM https://reviews.llvm.org/D41824 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D41871: [dotest] Remove crashinfo hook

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. No objections from me. Thanks. https://reviews.llvm.org/D41871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This LGTM but please wait for a second opinion. https://reviews.llvm.org/D41902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://

[Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

davide added a comment. In https://reviews.llvm.org/D41902#972619, @zturner wrote: > In https://reviews.llvm.org/D41902#972614, @clayborg wrote: > > > As long as: > > > > % lldb /path/to/Foo.app > > (lldb) r > > > > > > Still works, then I am fine with this. The resolve executable should find

[Lldb-commits] [PATCH] D41997: Build virtual override tables in DWARFASTParserClang::CompleteTypeFromDWARF

davide added a comment. In https://reviews.llvm.org/D41997#974957, @clayborg wrote: > Very cool and close. It would be nice to function correctly without asserts, > see inlined comment. Out of curiosity, why does `lldb` roll its own assertion() mechanism instead of using the standard one? R

[Lldb-commits] [PATCH] D42182: Add LLDB_LOG_ERROR (?)

davide added a comment. I think this is fine, but I'll defer to Zachary. https://reviews.llvm.org/D42182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42182: Add LLDB_LOG_ERROR (?)

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Forgot to click accept. https://reviews.llvm.org/D42182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D42206: If kevent() is interrupted by signal (or is being debugged) and we get EINTR, retry

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. I think this one is reasonable, but please wait for another opinion before committing (and write a test). Pavel touched this code very recently and added tests for this so it should

[Lldb-commits] [PATCH] D42206: If kevent() is interrupted by signal (or is being debugged) and we get EINTR, retry

davide added a comment. In https://reviews.llvm.org/D42206#979566, @vsk wrote: > Why not take an approach similar to the one in > https://reviews.llvm.org/D41008? It looks like it's possible to set up a poll > loop, call signal(), and verify that the loop is still running. Yes, that was what

[Lldb-commits] [PATCH] D42206: If kevent() is interrupted by signal (or is being debugged) and we get EINTR, retry

davide added a comment. In https://reviews.llvm.org/D42206#979570, @jasonmolenda wrote: > I tried sending signals to lldb-server via kill() and the signal handler > caught them, the bit of code I had printing out the return value & errno > value never got executed. The only way I was able to r

[Lldb-commits] [PATCH] D42210: Re-enable logging on the child side of a fork() in lldb-server platform mode

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. I took a look and I think this is a sensible change, but we should really test it. Repository: rL LLVM https://reviews.llvm.org/D42210

[Lldb-commits] [PATCH] D42215: [CMake] Make check-lldb work with LLDB_CODESIGN_IDENTITY=''

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM with Adrian's suggestion applied, thanks for doing this! https://reviews.llvm.org/D42215 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Wait a minute. Is there any reason why we can't add tests now? https://reviews.llvm.org/D41702 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D42264: Update lldb architecture doc

davide added a comment. Do you have commit rights or you need somebody to commit this on your behalf? https://reviews.llvm.org/D42264 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D42264: Update lldb architecture doc

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, ideally this file should be autogenerated. https://reviews.llvm.org/D42264 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. lgtm, feel free to go ahead. https://reviews.llvm.org/D41702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

davide added a comment. In https://reviews.llvm.org/D42281#981973, @aprantl wrote: > In https://reviews.llvm.org/D42281#981969, @clayborg wrote: > > > Looks like a good start. It might be nice to validate that after "clean" > > that we have no files that are untracked in the test directory? This

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This looks like a decent way of going forward, I'm a little concerned about swallowing an error, see comment inline. Comment at: packages/Python/lldbsuite/test/dot

[Lldb-commits] [PATCH] D42280: Wrap all references to build artifacts in the LLDB testsuite in TestBase::getBuildArtifact()

davide accepted this revision. davide added a comment. lgtm https://reviews.llvm.org/D42280 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

davide added a comment. In https://reviews.llvm.org/D40283#983057, @nelhage wrote: > I did a little bit of looking into performance implications today. It looks > like `DWARFASTParserClang::ParseTypeFromDWARF` is only called lazily as > symbols are needed, which alleviates some of my concerns,

[Lldb-commits] [PATCH] D42348: Prevent unaligned memory read in parseMinidumpString

davide added a comment. I'll be happy to review all your patch set tomorrow, Raphael. Do you mind to add me as reviewer so I don't lose track of your work? https://reviews.llvm.org/D42348 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D42348: Prevent unaligned memory read in parseMinidumpString

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Did you run the testsuite? If it's clean, feel free to merge. https://reviews.llvm.org/D42348 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D42339: Fix uninitialized variable in GoParser

davide added a comment. LGTM. FWIW, if people are not maintaining the `Go` and the `Java` plugin we should consider removing them entirely. It's a huge amount of code and if there are no users/developers, it's really not worth the trouble. Repository: rL LLVM https://reviews.llvm.org/D42339

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Thanks Greg. I'll wait another day and check this one in. Nelson, does the plan make sense to you? https://reviews.llvm.org/D40283 ___ lldb-comm

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

davide added a comment. In https://reviews.llvm.org/D40283#983946, @aprantl wrote: > In https://reviews.llvm.org/D40283#983908, @clayborg wrote: > > > I am fine with checking this. The only issue on my end is the extra memory > > that will be needed to store these often huge mangled names in eve

[Lldb-commits] [PATCH] D42488: Remove ObjectFile usage from HostLinux::GetProcessInfo

davide accepted this revision. davide added a comment. Thanks for the spring cleaning! https://reviews.llvm.org/D42488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Testcase? Repository: rL LLVM https://reviews.llvm.org/D42563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

davide added a comment. In https://reviews.llvm.org/D42563#988700, @alexshap wrote: > @davide - the test case is in the description but i can try to add it to the > test suite. yes, please. Repository: rL LLVM https://reviews.llvm.org/D42563

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

davide added a comment. As there are no strong objections, I'm going to check this in tomorrow PST and see how it goes. Thanks for your contribution. https://reviews.llvm.org/D40283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://

[Lldb-commits] [PATCH] D42620: [lldb] Silence signed <-> unsigned integer comparison warning

davide accepted this revision. davide added a comment. LGTM. `unsigned` is probably fine as well. Do you need somebody to commit this on your behalf? https://reviews.llvm.org/D42620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D42656: [testsuite] Remove flakey test relying on `pexpect`

davide added a comment. In https://reviews.llvm.org/D42656#991065, @jingham wrote: > There are a whole bunch of other tests that test completion in this file that > use the exact same mechanism but don't seem to be flakey. Why is this one > test flakey? > > If for instance it's because "Fo" en

[Lldb-commits] [PATCH] D42656: [testsuite] Remove flakey test relying on `pexpect`

davide added a comment. In https://reviews.llvm.org/D42656#991065, @jingham wrote: > There are a whole bunch of other tests that test completion in this file that > use the exact same mechanism but don't seem to be flakey. Why is this one > test flakey? > > If for instance it's because "Fo" en

[Lldb-commits] [PATCH] D42656: [testsuite] Remove flakey test relying on `pexpect`

davide added a comment. In https://reviews.llvm.org/D42656#991065, @jingham wrote: > There are a whole bunch of other tests that test completion in this file that > use the exact same mechanism but don't seem to be flakey. Why is this one > test flakey? So, I take a look at this to reply to

[Lldb-commits] [PATCH] D42656: [testsuite] Remove flakey test relying on `pexpect`

davide added a comment. In https://reviews.llvm.org/D42656#991239, @davide wrote: > In https://reviews.llvm.org/D42656#991065, @jingham wrote: > > > There are a whole bunch of other tests that test completion in this file > > that use the exact same mechanism but don't seem to be flakey. Why is

[Lldb-commits] [PATCH] D42656: [testsuite] Remove flakey test relying on `pexpect`

davide added a comment. In https://reviews.llvm.org/D42656#991284, @zturner wrote: > If we just need to test completion, write a lit-style test that uses > lldb-test that looks like this: > > RUN: lldb-test complete --target=%T/foo --complete_str=MyPrefix | FileCheck > %s > > CHECK: Foo::

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

davide accepted this revision. davide added a subscriber: aprantl. davide added a comment. This revision is now accepted and ready to land. This looks good. Feel free to go ahead and commit, but please coordinate with @aprantl as he just landed his changes for the testsuite (so you might need to

[Lldb-commits] [PATCH] D42870: Correct recognition of NetBSD images

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Please add a test case. Repository: rL LLVM https://reviews.llvm.org/D42870 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D42870: Correct recognition of NetBSD images

davide added a comment. In https://reviews.llvm.org/D42870#996899, @clayborg wrote: > Probably take a ELF file that is NetBSD and obj2yaml it. The test would run > yaml2obj on it and then test that things are recognized correctly via the SB > interfaces (check triple is correct)? The SBApi in

[Lldb-commits] [PATCH] D42870: Correct recognition of NetBSD images

davide added a subscriber: zturner. davide added a comment. In https://reviews.llvm.org/D42870#996913, @krytarowski wrote: > Is there a working example of this? I would clone an existing code for Linux > or other supported OS and adapt it for NetBSD. > > Please note that I'm in the process of re

[Lldb-commits] [PATCH] D42912: Sync PlatformNetBSD.cpp with Linux

davide added a comment. LGTM. I always found supercumbersome having to check `if log()` and error prone. Repository: rL LLVM https://reviews.llvm.org/D42912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

davide added a comment. Nice :) This looks already fine as-is, but I wonder whether we can get rid of the python boilerplate altogether? There has been quite a bit of discussion about using `lldb-test` for this sort of more focused testing, so I wonder whether you gave it a try? (just a random

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

davide added a comment. In https://reviews.llvm.org/D42914#997974, @zturner wrote: > Yea this seems like a good candidate for an lldb-test test. Something like > this. > > RUN: yaml2obj %S/Inputs/stripped.yaml > %t.stripped.out > RUN: yaml2obj %S/Inputs/unstripped.yaml > > %t/.build-id/1b

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. thanks for fixing this. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:526 return None - + header = os.path.join( ---

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide created this revision. davide added reviewers: aprantl, vsk, friss, labath, zturner, jingham, jasonmolenda. This is an experiment to improve out lldb testing capabilities and making them more similar to the one used in LLVM. Example: davide@Davidinos-Mac-Pro ~/w/l/b/bin> ./lldb-test a

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide added a comment. You can take a look at the `test/testcases/functionalities/completion/TestCompletion.py` for the python equivalent. I find the potential FileCheck'ed version much easier to read/write/understand. I'm possibly biased having worked many years on LLVM, hence I'm asking for

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide added a comment. In https://reviews.llvm.org/D43048#1001287, @jingham wrote: > The current auto-completer tests aren't interactive - they do exactly the > same thing your command does, but from Python. It's fine if you want to add > tests but please don't remove the current tests since

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide added a comment. In https://reviews.llvm.org/D43048#1001293, @davide wrote: > In https://reviews.llvm.org/D43048#1001287, @jingham wrote: > > > The current auto-completer tests aren't interactive - they do exactly the > > same thing your command does, but from Python. It's fine if you wa

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide added a comment. In https://reviews.llvm.org/D43048#1001311, @davide wrote: > In https://reviews.llvm.org/D43048#1001283, @zturner wrote: > > > By the way, I'd suggest printing indices in front of each match and > > including those in the FileCheck tests. Otherwise we could miss > > com

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide added a comment. In https://reviews.llvm.org/D43048#1001283, @zturner wrote: > By the way, I'd suggest printing indices in front of each match and including > those in the FileCheck tests. Otherwise we could miss completions that sneak > in. Instead, or in addition, we might dump the

[Lldb-commits] [PATCH] D43059: Add implementation for MSVC in CPlusPlusLanguage::IsCPPMangledName

davide added a comment. Can you add a unittest for this? :) Repository: rL LLVM https://reviews.llvm.org/D43059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43099: Make LLDB's clang module cache path customizable

davide accepted this revision. davide added a comment. LGTM modulo minor. Comment at: source/Plugins/ExpressionParser/Clang/CMakeLists.txt:26 clangCodeGen +clangDriver clangEdit aprantl wrote: > I checked and this does not affects LLDB's binary si

[Lldb-commits] [PATCH] D43099: Make LLDB's clang module cache path customizable

davide added inline comments. Comment at: source/Target/Target.cpp:3949 + idx); + assert(option_value); + return option_value->GetCurrentValue(); aprantl wrote: > davide wrote: > > add an assertion m

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide added a comment. In https://reviews.llvm.org/D43048#1004807, @labath wrote: > (Btw, if you're looking for things to FileCheck-ify, I think the stuff under > `lldb/unittests/UnwindAssembly` is a prime candidate and has a much higher > bang/buck ratio.) If you have ideas on how to FileCh

[Lldb-commits] [PATCH] D43292: [dotest] Add ability to skip tests based on build configuration

davide added a comment. After all the work he did on the testsuite I think Adrian is in a good position to review this one. https://reviews.llvm.org/D43292 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D43376: Fix TestStopReplyContainsThreadPcs on 32-bit x86 (pr36013)

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D43376 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [PATCH] D43464: Avoid dirtying the source tree in breakpoint command tests

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this :) https://reviews.llvm.org/D43464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Jonas, this looks a good use case for using lit. Is it possible to reuse the machinery we use in `lldb/lit/Expr` ? If not, well, we know there's something we can improve :) https://r

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

davide added inline comments. Comment at: lit/Expr/TestTypeOfExpr.test:2 +# RUN: %lldb -b -s %s | FileCheck %s + +expression int i; __typeof__(i) j = 1; j I really really love how concise and clear the new test is! https://reviews.llvm.org/D43471 ___

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43471 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [PATCH] D43506: Fix a couple of more tests to not create files in the source tree

davide added a comment. LGTM. This is really good work, thanks https://reviews.llvm.org/D43506 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43577: Fix TestUbsanBasic

davide added a comment. I wonder whether we could use something like >>> import os >>> os.path.basename('/patatino/ino/main.c') 'main.c' to make this slightly more robust against files which end in `main.c` but we don't want to really match, e.g. `blahmain.c`. https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Comment at: source/Core/Module.cpp:1286 +if (SymbolVendor *vendor = GetSymbolVendor()) + vendor->CreateSections(*GetUnifiedSectionList()); } ---

[Lldb-commits] [PATCH] D43591: [testsuite] Run lit tests as part of `check-lldb`

davide created this revision. davide added reviewers: friss, vsk, JDevlieghere, labath, zturner. Herald added a subscriber: mgorny. Also, fix a missing dependency, as lit requires `llvm-config` to run. This is becoming more and more important as we write more FileCheck style tests (see Jonas' las

[Lldb-commits] [PATCH] D43591: [testsuite] Run lit tests as part of `check-lldb`

This revision was automatically updated to reflect the committed changes. Closed by commit rL325719: [testsuite] Run lit tests as part of `check-lldb`. (authored by davide, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43591?vs=13531

[Lldb-commits] [PATCH] D43596: Replace HashStringUsingDJB with llvm::djbHash

davide accepted this revision. davide added a comment. Thanks. https://reviews.llvm.org/D43596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43686: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I was going to suggest the same thing Zach suggested, but I think this fine as is. LGTM. The fact the test is more concise is definitely a win, but I don't think this is the main reason for do

[Lldb-commits] [PATCH] D43686: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

davide added a comment. (and thanks for saving 1 minutes and 30 seconds of my life multiplied by the many times I run the test suite per day). https://reviews.llvm.org/D43686 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D40475: DWZ 10/11: DWZ test mode

davide added a comment. fwiw, you don't need unit tests or python tests to implement this. If I understand the feature correctly you can probably extend `lldb-test` (which is run as part of `check-lldb-lit`). Up to you though. https://reviews.llvm.org/D40475 _

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This commit has no tests. It should have many. It's very big, so it could be split in several pieces. I'd really appreciate if you can take the time to do so. For now, some comments.

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

davide added a comment. In https://reviews.llvm.org/D32167#1019621, @labath wrote: > In https://reviews.llvm.org/D32167#1019504, @clayborg wrote: > > > In https://reviews.llvm.org/D32167#1019467, @labath wrote: > > > > > However, I am not so sure about the proliferation of debug info variants >

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

davide added a comment. I like the way this patch is structured, some comments inline. Comment at: packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py:1-4 +# encoding: utf-8 +""" +Test lldb Obj-C exception support. +""" This looks like it

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

davide added a comment. LG modulo the test. Update that, I'll take another look and approve it. Thanks for your contribution! Comment at: packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py:1-4 +# encoding: utf-8 +""" +Test lldb Obj-C exception support.

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. As already pointed out, I think this feature should be thought again & have more focused testing. We can have a meeting/discussion about this, and I need to think about it more. But

[Lldb-commits] [PATCH] D44055: [lldb] Fix "requires global constructor" warning in g_range_specifiers

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM with Pavel's suggestion implemented. https://reviews.llvm.org/D44055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

[Lldb-commits] [PATCH] D44058: [lldb] Fix "code unreachable" warning in DNBArchImplX86_64::SetRegisterValue

davide added a comment. This seems scary. We really need a test case for this. https://reviews.llvm.org/D44058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

davide added a comment. In https://reviews.llvm.org/D32167#1026762, @jankratochvil wrote: > In https://reviews.llvm.org/D32167#1024546, @labath wrote: > > > I personally don't think having a new debug info flavour is a good idea. > > Tests written specifically to test this functionality will be

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

davide added a comment. In https://reviews.llvm.org/D32167#1026780, @jankratochvil wrote: > In https://reviews.llvm.org/D32167#1026779, @davide wrote: > > > Do you have a way of reproducing? > > > It just happens for me each time - on Fedora 27 x86_64 on 16-core (32HT) > 2-node NUMA machine havi

[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

davide accepted this revision. davide added a comment. LGTM Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:191-202 + struct SegmentParsingContext { +const EncryptedFileRanges EncryptedRanges; +lldb_private::SectionList &UnifiedList; +uint32_t NextSe

[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

davide added a comment. Fair, I don't have a strong opinion on whether this should be in an header or not. Probably Greg is right though, if this is not used anywhere else, we could make it somehow private. Thanks! https://reviews.llvm.org/D44074

[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This patch has no testcase. It shouldn't be particularly hard to write one, you can take inspiration from the one in `lit/`. Thanks! Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

davide added a comment. In https://reviews.llvm.org/D44321#1034043, @timotheecour wrote: > In https://reviews.llvm.org/D44321#1033325, @davide wrote: > > > This patch has no testcase. It shouldn't be particularly hard to write one, > > you can take inspiration from the one in `lit/`. > > > > Tha

[Lldb-commits] [PATCH] D40466: DWZ 01/11: DWARFUnit split out of DWARFCompileUnit

davide accepted this revision. davide added a comment. This is No functional change, right (just code churn)? If so, LGTM. https://reviews.llvm.org/D40466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D42892: DWZ 02/11: Move the codebase to use: DWARFCompileUnit -> DWARFUnit

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D42892 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D44473 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

davide added a comment. Also, I second the feeling of having `lldb` somewhere in the name for the utility (rather than `llvm` :) Repository: rL LLVM https://reviews.llvm.org/D44473 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

davide added a comment. The name should be changed (also the utility name), but that should be done separately. Repository: rL LLVM https://reviews.llvm.org/D44473 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D44502: Fix a bug in "target.source-map" where we would resolve unmapped paths incorrectly

davide added a comment. (please wait a day or two if @labath has comments) but this should be fine. https://reviews.llvm.org/D44502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44502: Fix a bug in "target.source-map" where we would resolve unmapped paths incorrectly

davide accepted this revision. davide added a comment. LGTM, thanks https://reviews.llvm.org/D44502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

davide added subscribers: alexandreyy, labath, davide. davide added a comment. Leonardo, this breaks the Mac OS X bot. I'm going to revert this to get the bots green again, unless you have a super quick fix (please let me know :) https://reviews.llvm.org/D44472 ___

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

davide added a comment. In https://reviews.llvm.org/D44472#1043464, @lbianc wrote: > @davide Are you sure this is the correct patch? This one was not merged yet. > Could you give more details about the issue? Is it related with one of our > changes? Apologies, this is the right one commit 98

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

davide added a comment. In https://reviews.llvm.org/D44472#1043510, @davide wrote: > In https://reviews.llvm.org/D44472#1043464, @lbianc wrote: > > > @davide Are you sure this is the correct patch? This one was not merged yet. > > Could you give more details about the issue? Is it related with o

<    1   2   3   4   5   6   >