davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.

This looks like a decent way of going forward, I'm a little concerned about 
swallowing an error, see comment inline.



================
Comment at: packages/Python/lldbsuite/test/dotest.py:1196
+        try: os.makedirs(configuration.test_build_dir, 448)
+        except: pass
+    else:
----------------
should we actually print some warning here? (e.g. directory `blah/` already 
exists?)


https://reviews.llvm.org/D42281



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to