davide accepted this revision.
davide added a comment.
LGTM modulo minor.
================
Comment at: source/Plugins/ExpressionParser/Clang/CMakeLists.txt:26
clangCodeGen
+ clangDriver
clangEdit
----------------
aprantl wrote:
> I checked and this does not affects LLDB's binary size in any measurable way.
This doesn't surprise me, as the driver is very small.
================
Comment at: source/Target/Target.cpp:3949
+ idx);
+ assert(option_value);
+ return option_value->GetCurrentValue();
----------------
add an assertion message if you don't mind?
https://reviews.llvm.org/D43099
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
