[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

aleksandr.urakov added a comment. I also have some strange failures on Windows x86 (I run tests from x64_86 MSVC command line). If I locally revert this commit and 3 fix commits right after this one, then all seems to work. Here is the failure: C:\Work\llvm\build_x86\bin>llvm-lit.py -v C:\Wo

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

aleksandr.urakov added a comment. But all compiles without errors if I run this manually: clang-cl -m32 /Z7 /c /GS- C:\Work\llvm\tools\lldb\lit\SymbolFile\PDB/Inputs/SimpleTypesTest.cpp /o C:\Work\llvm\build_x86\tools\lldb\lit\SymbolFile\PDB\Output/SimpleTypesTest.cpp.enums.obj Repository:

[Lldb-commits] [PATCH] D54452: [NativePDB] Add support for handling S_CONSTANT records

aleksandr.urakov added a comment. LGTM too, thanks! https://reviews.llvm.org/D54452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

aleksandr.urakov updated this revision to Diff 174916. aleksandr.urakov added a comment. Update the patch, move symtab finalization back to object files. This patch makes object files and symbol files (in the case if they add symbols in a symtab) to be responsible for finalization of a symtab. I

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

aleksandr.urakov added a comment. Ping! Can someone to have a look as well? https://reviews.llvm.org/D53759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: jingham, zturner. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds the check of the language before ignoring names like `id` or `Class`, which are reserved in Objective C, but

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:401-404 -// FIXME: the following language option is a temporary workaround, -// to "ask for C++, get ObjC++". Apple hopes to remove this requirement on -

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov added a reviewer: labath. aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:401-404 -// FIXME: the following language option is a temporary w

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, abidh. This patch makes old PDB plugin tests to use the new builder (see D54914

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

aleksandr.urakov added a comment. In D54914#1308919 , @zturner wrote: > @aleksandr.urakov Would you also mind giving this a try? I think it will > mean that you can re-write the SymbolFile/PDB tests to not be dependent on > running from a VS command pro

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov updated this revision to Diff 175443. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54843/new/ https://reviews.llvm.org/D54843 Files: packages/Python/lldbsuite/test/expression_command/options/TestExprOptions.py packages/Python/lldbsuite/test/expression_command/option

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov marked 2 inline comments as done. aleksandr.urakov added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:404 -// non-Apple platforms, but for now it is needed. -m_compiler->getLangOpts().ObjC = true; break

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

aleksandr.urakov added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53759/new/ https://reviews.llvm.org/D53759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

aleksandr.urakov updated this revision to Diff 175634. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53759/new/ https://reviews.llvm.org/D53759 Files: lit/SymbolFile/PDB/Inputs/ExpressionsTest.cpp lit/SymbolFile/PDB/Inputs/ExpressionsTest0.script lit/SymbolFile/PDB/Inputs/Expressio

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

aleksandr.urakov marked 2 inline comments as done. aleksandr.urakov added inline comments. Comment at: source/Core/RichManglingContext.cpp:134-135 get(m_cxx_method_parser)->GetBasename(); +if (!m_buffer.data()) + m_buffer = llvm::StringRef("", 0); return; -

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov added a comment. Thanks all! In D54942#1310224 , @zturner wrote: > Makes sense. Just curious, is the order file strictly necessary for this > test? `/Gy` is the same as `-ffunction-sections`, so there could be an > argument to be made

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

aleksandr.urakov added a comment. Ping! Can you take a look, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53368/new/ https://reviews.llvm.org/D53368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

This revision was automatically updated to reflect the committed changes. Closed by commit rL347960: [Symbol] Search symbols with name and type in a symbol file (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

This revision was automatically updated to reflect the committed changes. aleksandr.urakov marked an inline comment as done. Closed by commit rL347962: [PDB] Support PDB-backed expressions evaluation (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed p

[Lldb-commits] [PATCH] D53761: [Target] Do not skip a stop on a breakpoint if a plan was completed

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB347974: [Target] Do not skip a stop on a breakpoint if a plan was completed (authored by aleksandr.urakov, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D55002: [NativePDB] Fix ast-reconstruction test on x86

This revision was automatically updated to reflect the committed changes. Closed by commit rL347975: [NativePDB] Fix ast-reconstruction test on x86 (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55002?vs

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Ping! Can you look at this, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54843/new/ https://reviews.llvm.org/D54843 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

aleksandr.urakov added a comment. I can do it, but unfortunately not this week... I want to join the native plugin development some later, at the end of this month, after some current work. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://revi

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348240: [Expr] Check the language before ignoring Objective C keywords (authored by aleksandr.urakov, committed by ). Hera

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov added a comment. Ok, thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54843/new/ https://reviews.llvm.org/D54843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

aleksandr.urakov abandoned this revision. aleksandr.urakov added a comment. Abandon due to D55122 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53086/new/ https://reviews.llvm.org/D53086 ___ lldb-commits m

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov added a comment. The test was broken after this commit. It seems that on MacOS X the process of the compiled test application always contains Objective C Runtime, so the part of the test, which assumes that there is no ObjC option enabled, fails. To fix it I've skip this part f

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov updated this revision to Diff 176611. aleksandr.urakov added a comment. Update tests due to D55230 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54942 Files: lit/SymbolFile/PDB/ast-restore.test

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

aleksandr.urakov added a comment. Thanks! I've updated DIA PDB tests in D55230 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55230/new/ https://reviews.llvm.org/D55230 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: teemperor, clayborg, jingham, zturner, labath, davide, spyffe. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, abidh. This patch adds support of expression evaluation in a context of some obj

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov added a comment. It seems that all the reviews this one depends on are already in. Can we proceed with it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54942 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348386: [PDB] Make PDB lit tests use the new builder (authored by aleksandr.urakov, committed by ). Herald added a subscri

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Btw, it can be useful if there ever would be a declarative format for pretty printers in LLDB. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov added a comment. It looks strange. The compiler can't open the object file. And in the next build it is ok - may be it was some server failure (e.g. full disk)? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov added a subscriber: zturner. aleksandr.urakov added a comment. The similar problem with `typedefs.test` is here: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1940/steps/test/logs/stdio I have an assumption about the cause of the problem. Are the tests running

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov updated this revision to Diff 176980. aleksandr.urakov added a comment. Thanks for the interest to the feature! I've updated the patch due to the comments. The only problem is that I'm not familiar with Objective C and have no Mac OS to test it, so I haven't written the test fo

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:577 + + clang::DeclContext *decl_context = m_clang->GetTranslationUnit

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov marked 6 inline comments as done. aleksandr.urakov added inline comments. Comment at: include/lldb/Expression/UserExpression.h:296 + lldb::ModuleSP *jit_module_sp_ptr = nullptr, + const lldb::ValueObjectSP &ctx_obj = lldb::ValueObjectSP());

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov updated this revision to Diff 177139. aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Thanks for the comments, I've updated the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 Files:

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. Now it looks more clear, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.org/D55384 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Ping! What do you think about this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56010/new/ https://reviews.llvm.org/D56010 ___ lldb-commits

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, labath, lemo, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, abidh. This patch adds the basic support of methods reconstruction by native PDB plugin. It

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. In D56126#1342114 , @zturner wrote: > I think it's probably best to skip this part for now and come back to it > later. The only thing that will be missing is the abilit

[Lldb-commits] [PATCH] D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, JDevlieghere, clayborg, labath. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. This patch allows to retrieve an address object for `ValueObject`'s children retrieved through e.g. `

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/ast-methods.cpp:28 +// CHECK: |-CXXRecordDecl {{.*}} struct Struct definition +// CHECK: | |-CXXMethodDecl {{.*}} simple_method 'void () __attribute__(

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, zturner. Herald added a subscriber: mgorny. The patch adds support of splitted functions (when MSVC is used with PGO) and function-level linking feature. SymbolFilePDB::ParseCompileUnitLineTable function relies on

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. Thank you! But it looks like the binary files (*.pdb and *.exe) have not been committed properly (they have zero size). https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. > I think you have to specify --binary when generating the diff. I have specified --binary when I was generating the patch, and there is encoded binaries in the patch file, may be they was somehow cutted out during an upload to the Phabricator... I have attache

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. Yes, it does really need to be a VS PDB. Function-level linking is a linker's feature and I can't found support of this feature in lld, so I think module addresses inconsistency will not be reproducible with lld. I've tried to convert a VS PDB to YAML and back

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. > I suppose the reason you can't do the same yaml2obj trick on the .exe is > because yaml2obj does not support serializing exe's yet? Yes, it's so. > Could we shrink the size of these binaries by not using c and c++ standard > library features? The problem is

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov updated this revision to Diff 150287. aleksandr.urakov added a comment. Formatted test sources corresponding to LLVM rules. https://reviews.llvm.org/D47708 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp unittests/SymbolFile/PDB/CMakeLists.txt unittests/SymbolFile/

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. In https://reviews.llvm.org/D47708#1124743, @labath wrote: > We have an lldb-test executable, which we use for writing tests (see tests in > lit/SymbolFile). It's `symbols` subcommand currently just dumps their > contents and then we match that. > > Your checks

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. In https://reviews.llvm.org/D47708#1124749, @labath wrote: > Btw, would it be possible to use the `/order` directive to achive what you > want? > (/order:function_from_first_file,function_from_second_file,another_function_from_first_file) Yes, thanks for poin

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov updated this revision to Diff 150295. aleksandr.urakov added a comment. Use /ORDER switch to reduce test binaries size. https://reviews.llvm.org/D47708 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp unittests/SymbolFile/PDB/CMakeLists.txt unittests/SymbolFile/PDB/

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov updated this revision to Diff 150322. aleksandr.urakov added a comment. The implementation of lldb-test symbols -verify option. https://reviews.llvm.org/D47708 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp tools/lldb-test/lldb-test.cpp unittests/SymbolFile/PDB/CM

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. > Function level linking is a compiler feature, not a linker feature. It's > enabled via the /Gy option in the compiler and causes the compiler to put > each function into its own COMDAT. The linker can then use this to discard > more functions (e.g. during /

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. In https://reviews.llvm.org/D47708#1124994, @zturner wrote: > As a general rule, lld-link is command line compatible with MSVC and > clang-cl is command line compatible with cl. So, the /order option should > work exactly the same with lld-link as it does with

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. In https://reviews.llvm.org/D47708#1125029, @labath wrote: > Thank you for implementing the lldb-test extension. Now that we have that, > and the `/order`, we should be able to get rid of the binaries for the > function-level-linking test. You should be able to

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov updated this revision to Diff 150356. aleksandr.urakov added a comment. Avoid binaries in tests. https://reviews.llvm.org/D47708 Files: lit/SymbolFile/PDB/Inputs/FunctionLevelLinkingTest.cpp lit/SymbolFile/PDB/Inputs/FunctionLevelLinkingTest.h lit/SymbolFile/PDB/Inputs/Fu

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. I replaced all binaries by a lit-based test, as you told. The only thing, I have made it more like other PDB tests. https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

aleksandr.urakov added a comment. Thank you for explanations! https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. The test here can be expanded to include https://reviews.llvm.org/D48960 case. https://reviews.llvm.org/D49018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D48960: Use an unwinder to get register contexts of frames other than zeroth under Windows

aleksandr.urakov added a comment. This can be tested after applying https://reviews.llvm.org/D49018 patch. https://reviews.llvm.org/D48960 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

aleksandr.urakov added a comment. Add LLDB_API to SBAddress's operator== to fix lldb-mi build on Windows. https://reviews.llvm.org/D49006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. Excuse me, I have forgot to add lldb-commits as a subscriber, so I'll repeat initial message. The current version of SymbolFilePDB::ParseVariableForPDBData function always initializes variables with an empty location. This patch adds the converter of a locatio

[Lldb-commits] [PATCH] D48960: Use an unwinder to get register contexts of frames other than zeroth under Windows

aleksandr.urakov added a comment. Excuse me, I have forgot to add lldb-commits as a subscriber, so I'll repeat initial message. The current version of TargetThreadWindows::CreateRegisterContextForFrame function always returns the register context of the zeroth frame. This patch uses an unwinde

[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

aleksandr.urakov added a comment. Thank you! It builds well on Windows with this patch for me. Can you commit this, please? I have no commit access. https://reviews.llvm.org/D49006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D48960: Use an unwinder to get register contexts of frames other than zeroth under Windows

aleksandr.urakov abandoned this revision. aleksandr.urakov added a comment. Thank you! Yes, https://reviews.llvm.org/D49111 is more like other targets, so I think it will be a better choice. So I will abandon the current revision. https://reviews.llvm.org/D48960

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. Ping! Can you review this, please? I have just implemented the UDT types completion for PDB symbol files and I am preparing a patch for that, but it makes no sense without the part implemented in this one :) https://reviews.llvm.org/D49018

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h:26 +//-- +/// Converts a location inform

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov updated this revision to Diff 155154. aleksandr.urakov added a comment. Thanks a lot, I have updated the patch! I also have added a test case for a non-zeroth frame (it became possible after https://reviews.llvm.org/D49111). If it's all right, can you commit this for me, please

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. Thank you! Repository: rL LLVM https://reviews.llvm.org/D49018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. This doesn't look like the cause, the test fails for me without this patch... Here is my tests output for PDB folder: -- Testing: 10 tests, 8 threads -- FAIL: lldb :: SymbolFile/PDB/enums-layout.test (1 of 10) FAIL: lldb :: SymbolFile/PDB/typedefs.test (2

[Lldb-commits] [PATCH] D49368: Complete user-defined types from PDB symbol files

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, zturner, labath, clayborg. Herald added a subscriber: JDevlieghere. This patch adds the implementation of an UDT completion from PDB symbol files. For now it supports different UDT kinds (union, struct and class), s

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. Yes, you are right, extra `location = DW_OP_addr(000140004114)` appeared after this commit. But I hadn't noticed that, because the test was already broken for me on `0fa537f42f1af238c74bf41998dc1af31195839a`. Now I have checked one out and ran the test to r

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added a comment. Ah, we need some way to synchronize our work :) I think in this case it will be better to appreciate the pros and cons of our patches, choose the better variant and improve that with the features available in another variant. I will investigate your patch to un

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added a comment. It seems that you forgot to add the testing `*.cpp` files from the `Input` directory to the patch... Repository: rL LLVM https://reviews.llvm.org/D49410 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. The expression `location = {{.*}},` should process that space correctly. It is possible to remove that space in `DWARFExpression::DumpLocation` function, but I don't know how necessary is it. But what about a compiler version? I want to fix the issue if somethi

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added a comment. I think that this patch is more solid and covers more cases, than https://reviews.llvm.org/D49368, especially in `CreateLLDBTypeFromPDBType` part. But https://reviews.llvm.org/D49368 has also following: - Filling of a layout info. It allows use of packed types,

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. I've removed spaces in such places, but i'm not sure if this won't break anything (may be something relies on that spaces). @clayborg, are these spaces have some special purpose? I think it's a decor and not really important.F6716378: patch.diff

[Lldb-commits] [PATCH] D49475: Fix variables.test after D49018

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: stella.stamenova, lldb-commits. This one fixes variables.test after https://reviews.llvm.org/D49018. The test was broken because https://reviews.llvm.org/D49018 adds a location information to variables, but I hadn't notice

[Lldb-commits] [PATCH] D49475: Fix variables.test after D49018

aleksandr.urakov added a comment. Can you commit this for me, please? I have no commit access. https://reviews.llvm.org/D49475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:291-295 +if (udt->isConstType()) + clang_type = clang_type.AddConstModifier(); + +if (udt->isVolatileType()) + clang_type = clang_type.AddVolatileModifier(); -

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added a comment. Don't you mind if I try to combine this with https://reviews.llvm.org/D49368? To avoid doing the work twice. https://reviews.llvm.org/D49410 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D49475: Fix variables.test after D49018

aleksandr.urakov added a comment. Thanks! Repository: rL LLVM https://reviews.llvm.org/D49475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. Can you explain me, please, why do you think that we should remove these spaces? I have the following considerations: - For eight years (the spaces were commited in 2010) some tests may have relied on these spaces. It's a good case - we can run tests and see it

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:696 + base_ast_type.GetOpaqueQualType(), access, + pdb_base_class->isVirtualBaseClass(), /*base_of_class*/ true); + base_classes.push_back(base_spec); ---

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:186 +return lldb::eAccessProtected; + return lldb::eAccessNone; +} zturner wrote: > I wonder if this would be better as an `llvm_unreachable`. Being able to

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp:37 + }; + union { // Test unnamed union. MSVC treats it as `int a; float b;` +int a; Here is a problem. `MicrosoftRecordLayoutBuilder` asserts every field or

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:273 +udt->getClassParent()) { + access = GetDefaultAccessibilityForUdtKind(udt_kind); +} Yes, we can occur here, as I have mentioned at the line 18

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/PDB/class-layout.test:3 +RUN: clang-cl -m32 /Z7 /c /GS- %S/Inputs/ClassLayoutTest.cpp /o %T/ClassLayoutTest.cpp.obj +RUN: link %T/ClassLayoutTest.cpp.obj /DEBUG /nodefaultlib /ENTRY:main /OUT:%T/ClassLayoutTest.

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/PDB/class-layout.test:3 +RUN: clang-cl -m32 /Z7 /c /GS- %S/Inputs/ClassLayoutTest.cpp /o %T/ClassLayoutTest.cpp.obj +RUN: link %T/ClassLayoutTest.cpp.obj /DEBUG /nodefaultlib /ENTRY:main /OUT:%T/ClassLayoutTest.

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp:37 + }; + union { // Test unnamed union. MSVC treats it as `int a; float b;` +int a; Hui wrote: > aleksandr.urakov wrote: > > Here is a problem. `MicrosoftRec

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp:37 + }; + union { // Test unnamed union. MSVC treats it as `int a; float b;` +int a; aleksandr.urakov wrote: > Hui wrote: > > aleksandr.urakov wrote: > > > He

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp:37 + }; + union { // Test unnamed union. MSVC treats it as `int a; float b;` +int a; aleksandr.urakov wrote: > aleksandr.urakov wrote: > > Hui wrote: > > > al

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added a comment. In https://reviews.llvm.org/D49410#1174787, @zturner wrote: > When you have a DIA interface for struct S, can you just call > findChildren()? Will that enumerate tge unnamed struct? I have checked this again with `cl` and `clang-cl` (but I have enumerated all

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added a subscriber: zturner. aleksandr.urakov added a comment. Yes, I have understood that, thank you. It may be not trivial in a case of multiple nested unnamed unions/structs, but it's solvable for clang-emitted PDBs. But I'm not sure about cl-emitted PDBs too. Can we leave t

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added a comment. Thanks! I have created the corresponding patch for Clang (https://reviews.llvm.org/D49871, @rnk have accepted it. Can you commit this, please? I have no commit access). But current patch intersects with https://reviews.llvm.org/D49368, and I'm preparing the c

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added a comment. It would be great, thank you! I'll also do it on Monday, if it's already possible. https://reviews.llvm.org/D49410 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

<    1   2   3   4   >