aleksandr.urakov added a reviewer: labath. aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments.
================ Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:401-404 - // FIXME: the following language option is a temporary workaround, - // to "ask for C++, get ObjC++". Apple hopes to remove this requirement on - // non-Apple platforms, but for now it is needed. - m_compiler->getLangOpts().ObjC = true; ---------------- labath wrote: > aleksandr.urakov wrote: > > Is it still necessary? We can do here something like `#ifdef __APPLE__`, > > but then the test will fail on Apple platforms. Can we somehow specify a > > platform requirement in the test? > Instead of `ifdef` it would be better to do a > `target->GetArchitecture().getTriple().getVendor() == llvm::Triple::Apple` > and then `@skipIfDarwin` in the test. But it would be certainly better to > remove this altogether :) Yes, your variant is better! I'll do it in the way you have described if there will be objections against removing it at all. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54843/new/ https://reviews.llvm.org/D54843 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
