aleksandr.urakov marked 6 inline comments as done. aleksandr.urakov added inline comments.
================ Comment at: include/lldb/Expression/UserExpression.h:296 + lldb::ModuleSP *jit_module_sp_ptr = nullptr, + const lldb::ValueObjectSP &ctx_obj = lldb::ValueObjectSP()); ---------------- zturner wrote: > A reference to a `shared_ptr` seems odd. Why don't we just say `const > ValueObject* ctx_obj = nullptr`? Yes, I agree. I wasn't sure about the lifetime of the context object, that's why I've used a shared pointer here. But now it is obvious that there should be no problems with the lifetime - an expression evaluation with a context object is called from `SBValue` only, so it is guaranteed that the required value exists during the evaluation. The only thing is that the pointer points to a non-const value object - non-const methods are used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
