aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: stella.stamenova, lldb-commits.
This one fixes variables.test after https://reviews.llvm.org/D49018. The test
was broken because https://reviews.llvm.org/D49018 adds a location information
to variables, but I hadn't noticed that, because I used 32-bit build to run
tests, so the test looked to me already broken before that commit (the test
relies on mangled names, but the mangling schemes are different for 32-bit and
64-bit).
https://reviews.llvm.org/D49475
Files:
lit/SymbolFile/PDB/variables.test
Index: lit/SymbolFile/PDB/variables.test
===================================================================
--- lit/SymbolFile/PDB/variables.test
+++ lit/SymbolFile/PDB/variables.test
@@ -7,19 +7,19 @@
CHECK: SymbolVendor ([[MOD]])
CHECK: CompileUnit{{.*}}, language = "c++", file =
'{{.*}}\VariablesTest.cpp'
CHECK-DAG: Variable{{.*}}, name = "g_IntVar"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "m_StaticClassMember"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "g_pConst"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "same_name_var"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "g_EnumVar"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "g_tls"
-CHECK-SAME: scope = thread local, external
+CHECK-SAME: scope = thread local, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "ClassVar"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "g_Const"
CHECK-SAME: scope = ??? (2)
Index: lit/SymbolFile/PDB/variables.test
===================================================================
--- lit/SymbolFile/PDB/variables.test
+++ lit/SymbolFile/PDB/variables.test
@@ -7,19 +7,19 @@
CHECK: SymbolVendor ([[MOD]])
CHECK: CompileUnit{{.*}}, language = "c++", file = '{{.*}}\VariablesTest.cpp'
CHECK-DAG: Variable{{.*}}, name = "g_IntVar"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "m_StaticClassMember"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "g_pConst"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "same_name_var"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "g_EnumVar"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "g_tls"
-CHECK-SAME: scope = thread local, external
+CHECK-SAME: scope = thread local, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "ClassVar"
-CHECK-SAME: scope = global, external
+CHECK-SAME: scope = global, location = {{.*}}, external
CHECK-DAG: Variable{{.*}}, name = "g_Const"
CHECK-SAME: scope = ??? (2)
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
