[Lldb-commits] [PATCH] D42083: [lldb][PPC64] Fixed long double variables dump

labath added a comment. This adds a special case to "long double" logic, which is already a special case compared to "float" and "double" cases. This was written this way (see http://reviews.llvm.org/D8417) because the x86 long double type is special, but if I understand this correctly, for the

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. First, I'd like to thank you for taking the time to create a method for testing patches like these. I think this will be very valuable for all out-of-tree stub support patches we will get in the future. Could I ask that you split out the generic test-suite-stuff part of

[Lldb-commits] [PATCH] D42083: [lldb][PPC64] Fixed long double variables dump

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome, thanks. https://reviews.llvm.org/D42083 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D42182: Add LLDB_LOG_ERROR (?)

labath created this revision. labath added reviewers: davide, zturner, jingham, clayborg. Herald added a subscriber: emaste. The difference between this and regular LLDB_LOG is that this one clears the error object unconditionally. This was inspired by the ObjectFileELF bug (r322664), where the e

[Lldb-commits] [PATCH] D42083: [lldb][PPC64] Fixed long double variables dump

This revision was automatically updated to reflect the committed changes. Closed by commit rL322666: [lldb][PPC64] Fixed long double variables dump (authored by labath, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42083 Files: lldb/trunk/source/Core/DumpDataExtractor.cpp

[Lldb-commits] [PATCH] D42206: If kevent() is interrupted by signal (or is being debugged) and we get EINTR, retry

labath added a comment. I actually enjoy debugging things like this, so I tried playing around and came up with this test case: // Test that a signal which is not monitored by the MainLoop does not cause a premature exit. TEST_F(MainLoopTest, UnmonitoredSignal) { MainLoop loop; Stat

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thank you for taking the time to do this. @chmeee, do you want to take a quick look at this? https://reviews.llvm.org/D41702 ___ lldb-commits mai

[Lldb-commits] [PATCH] D42210: Re-enable logging on the child side of a fork() in lldb-server platform mode

labath added a comment. In https://reviews.llvm.org/D42210#979608, @jasonmolenda wrote: > Jim remembers some problem with logging across a fork()'ed process, Pavel > does this ring a bell? This change might be completely bogus -- but it's > very difficult to debug the child side of an lldb-ser

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added a comment. My main comment is about making sure the tearDown story is sufficiently robust. I want to be sure we don't introduce flakyness here. Comment at: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py:12 +target

[Lldb-commits] [PATCH] D42182: Add LLDB_LOG_ERROR (?)

labath added a comment. The behavior of llvm::Error is one more quirk that you need to know about, but I don't think the logging machinery is the place that should teach you that. If you're working with llvm::Error, in all likelyhook you've already had to learn about this behavior anyway, in wh

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

labath added a comment. Well.. whether this plugin is tested depends on what machine you're running on. If you're running on a ppc machine, plenty of tests will exercise this code (TestReturnValue, and pretty much any test doing expression evaluation). Correct me if I am wrong, but I am assumin

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

labath added a comment. I like the direction this is going in. When looking at this, it occurred to me some of our tests do recursive make invocations, generally to build shared libraries (TestConflictingSymbol is a good example). The $(MAKE) line in those may need to be fixed somehow. =

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added a comment. Thank you for making the changes. The parsing code looks much cleaner now. I just have one more round of tiny remarks. Comment at: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py:241 +self.port = self._socket.

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added a comment. Oh, and please add yaml2obj as a dependency of the check-lldb target in cmake. https://reviews.llvm.org/D42195 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

labath added a comment. I don't know much about clang modules, but the change seems reasonable to me. https://reviews.llvm.org/D42277 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

This revision was automatically updated to reflect the committed changes. Closed by commit rL322935: Remove Platform references from the Host module (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41902?vs=129435&i

[Lldb-commits] [PATCH] D42280: Wrap all references to build artifacts in the LLDB testsuite in TestBase::getBuildArtifact()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome. This will make flipping the out-of-tree switch much easier. Making more tests use lldbutil.run_to_source_breakpoint would be nice, but I suspect that cannot be done with a shellscript

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added subscribers: krytarowski, jingham, davide. labath added a comment. In https://reviews.llvm.org/D42195#982035, @owenpshaw wrote: > - Added yaml2obj dependency. It it okay to be an unconditional dependency? Yeah, it probably needs to be conditional (if(TARGET yaml2obj)), because st

[Lldb-commits] [PATCH] D42280: Wrap all references to build artifacts in the LLDB testsuite in TestBase::getBuildArtifact()

labath added a comment. In https://reviews.llvm.org/D42280#982229, @jingham wrote: > I didn't intend to block this patch, just to point out that this was really > work you shouldn't have had to do, and that as we touch these files we should > clean them up so next time we don't have to. It wil

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

This revision was automatically updated to reflect the committed changes. Closed by commit rL323100: Add SysV Abi for PPC64le (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41702?vs=130236&id=130860#toc Repositor

[Lldb-commits] [PATCH] D42339: Fix uninitialized variable in GoParser

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm (the go plugin is kinda unmaintained now...) https://reviews.llvm.org/D42339 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D41427: [SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it

labath added a comment. I have reverted this because this breaks the lldb-Unit::SymbolFilePDBTests.TestTypedefs test http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/7715. My guess is that this is because you did not update the checked-in exe to account for the changes in it's

[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

labath added a comment. A couple of thoughts come to mind: - Does this functionality really belong in the client? In case of memory reads, it's the server who patches out the breakpoint opcodes (NativeProcessProtocol::ReadMemoryWithoutTrap). I think it would make sense to do this in the same p

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added a comment. Herald added a subscriber: hintonda. In https://reviews.llvm.org/D42195#984003, @owenpshaw wrote: > It looks like the yaml2obj target hasn't been defined yet when the check-lldb > target is defined, so if(TARGET yaml2obj) always returns false. Is there > another way to

[Lldb-commits] [PATCH] D42409: Fix memory leaks in GoParser

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. It looks like all of these parsing functions would benefit from returning unique_ptr, but that's probably not something we should bother doing now that we are contemplating removing this code.

[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

labath added a comment. In https://reviews.llvm.org/D39967#985171, @clayborg wrote: > That would be an easy fix for the ObjectFile::Load(), we could see if there > are any breakpoints in the range we are trying to write, get a list of them, > disable them all, write memory and re-enable. But th

[Lldb-commits] [PATCH] D42488: Remove ObjectFile usage from HostLinux::GetProcessInfo

labath created this revision. labath added reviewers: eugene, krytarowski. Herald added subscribers: hintonda, mgorny. The ObjectFile class was used to determine the architecture of a running process by inspecting it's main executable. There were two issues with this: - it's in the wrong layer -

[Lldb-commits] [PATCH] D42488: Remove ObjectFile usage from HostLinux::GetProcessInfo

labath planned changes to this revision. labath added inline comments. Comment at: source/Host/linux/Host.cpp:129 + auto buffer_sp = DataBufferLLVM::CreateSliceFromPath(exe_path, 0x20, 0); + if (buffer_sp) +return ArchSpec(); eugene wrote: > Shouldn't it be

[Lldb-commits] [PATCH] D42488: Remove ObjectFile usage from HostLinux::GetProcessInfo

labath updated this revision to Diff 131401. labath added a comment. This revision is now accepted and ready to land. Ok, so the issue was a subsequent MergeFrom(HostArchitecture) call which was overwriting the invalid ArchSpec I was returning here. I think this was present there to fill in the bi

[Lldb-commits] [PATCH] D31451: New C++ function name parsing logic

labath added a comment. This code is processing demangled names. Since you say (I could not get my demangler to process it either) the symbol demangles to a multi-megabyte name, we can probably make the cutoff even longer then 1000 bytes. OTOH, if we abort demangling of such names in the first

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is great. Thank you for doing this. I think we're ready to wrap this up. https://reviews.llvm.org/D42195 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

labath added a comment. I've created https://reviews.llvm.org/D42572 with the fixups necessary to make this run on linux. It's way smaller than I expected we would need -- I basically fixed one typo and corrected for some shared library weirdness. Can you apply that on top of your CL? I'll try

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:1588 paths_to_try = [ "llvm-build/Release+Asserts/x86_64/Release+Asserts/bin/clang", "llvm-build/Debug+Asserts/x86_64/Debug+Asserts/bin/clang",

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

labath added a comment. In https://reviews.llvm.org/D42281#989793, @aprantl wrote: > I am now working on building each test variant (dwarf,dwo,dsym,...) in its > own build directory so they can run in parallel and we can get rid of the > lockfile. Are you planning to merge that into this patc

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added a comment. Thanks for the clarification. It seems nobody was calling that function, so maybe it never actually worked. I'll try committing this for Owen with the clang paths modified and check whether the bots like it. https://reviews.llvm.org/D42195 __

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL323636: [lldb] Generic base for testing gdb-remote behavior (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42195?vs=1313

[Lldb-commits] [PATCH] D42488: Remove ObjectFile usage from HostLinux::GetProcessInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL323637: Remove ObjectFile usage from HostLinux::GetProcessInfo (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42488?vs=1

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

labath added a comment. I haven't gotten around to trying this out on windows yet, but I have tried running the tests remotely. I've updated https://reviews.llvm.org/D42572 with the two fixes necessary to make the remote tests pass (for android). https://reviews.llvm.org/D42281

[Lldb-commits] [PATCH] D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. We have one plugin in-tree (tools/intel-features), but I'm not sure if anyone uses/installs it. In any case, the change seems like the right thing to do. https://reviews.llvm.org/D42317 _

[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

labath added a comment. I'll leave it up to others to say whether this solution is fully correct, but I have to say that it looks much cleaner than the previous one. Comment at: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile:1-17 +.PHONY : all +.PHO

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. I still like my `WriteMemory(ArrayRef)` proposal the best. If you don't have any special writing requirements, it can be viewed as a convenience wrapper for the one-shot `WriteMemory`, and if a subclass needs special handling, it can implement it in a smarter way (while

[Lldb-commits] [PATCH] D42182: Add LLDB_LOG_ERROR (?)

labath added a comment. It looks like we haven't come up with a better name, and there's new code in https://reviews.llvm.org/D42468 which would benefit a lot from this functionality, so I'm going to land this. I don't expect hundreds of uses of this macro appearing any time soon, so it should

[Lldb-commits] [PATCH] D42182: Add LLDB_LOG_ERROR (?)

This revision was automatically updated to reflect the committed changes. Closed by commit rL323753: Add LLDB_LOG_ERROR macro (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42182?vs=130176&id=131944#toc Repositor

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

labath accepted this revision. labath added a comment. Right, so I tried this out on windows today (targetting android, because I know the state of that target, but I think this should catch problems with windows host builds as well). The main problem i ran into is that `$(realpath)` is just br

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. In https://reviews.llvm.org/D42145#992289, @owenpshaw wrote: > > So the main question is: do we want WriteMemory to work anywhere and always > > try to do the right thing, or return an error an the user would be expected > > to know to check the memory region you are wri

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

labath added a comment. In https://reviews.llvm.org/D42281#992359, @aprantl wrote: > In https://reviews.llvm.org/D42281#992295, @aprantl wrote: > > > There are a few test failures, but they look manageable. I will need help > > resolving them though: > > > Updated list: > > http://lab.llvm.org:8

[Lldb-commits] [PATCH] D42443: [SymbolFilePDB] Add support for function symbols

labath added inline comments. Comment at: lit/SymbolFile/PDB/func-symbols.test:4 +RUN: clang-cl -m32 /Z7 /c /GS- %S/Inputs/FuncSymbols.cpp /o %T/FuncSymbols.cpp.obj +RUN: link %T/FuncSymbolsTestMain.cpp.obj %T/FuncSymbols.cpp.obj /DEBUG /nodefaultlib /Entry:main /OUT:%T/FuncSym

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath added a comment. I am not sure this actually creates enough separation. Plenty of tests have more then one test method per file: TestFoo.py: class FooTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True def test_bar(self): ... def test_baz(self): ... If I underst

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. I think we're slowly getting there, but we could cleanup the implementation a bit. I am also not sure that the `WriteObjectFile` name really captures what this function does, but I don't have a suggestion for a better name either Comment at: incl

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py:335-337 +# However, if we aren't expecting an ack, it's likely the initial +# ack that lldb client sends, and observati

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath added inline comments. Comment at: packages/Python/lldbsuite/test/lldbinline.py:96-98 +return "-N dwarf %s" % (testdir) else: +return "-N dsym %s" % (testdir) aprantl wrote: > labath wrote: > > xiaobai wrote: > > > Good opp

[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

labath added a comment. In https://reviews.llvm.org/D42195#995087, @clayborg wrote: > I am pretty sure that the ack that gets sent should happen in response to > getting an ACK. Note that LLDB send an ACK and then waits for an ACK. This > helps us see if anything is there. So yes, this code can

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath added inline comments. Comment at: packages/Python/lldbsuite/test/api/listeners/TestListener.py:26 TestBase.setUp(self) -self.build() I'm confused by these changes. I was under the impression that setUp() runs before each test method (a

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. Yes, it's mostly stylistic differences, but there is one more important thing that we need to figure out, and that's making sure that the test only runs if we actually have XML support compiled-in. If there's isn't anything in the SB API that would tell us that (I cursor

[Lldb-commits] [PATCH] D42828: Fix for read-past-end-of-array buglet in ProcessElfCore.cpp while reading linux notes

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, just make sure to not include extra \0 bytes. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:668 return status.ToError(); - thread_d

[Lldb-commits] [PATCH] D42836: [dotest] make debug info variant accessible in setUp()

labath created this revision. labath added reviewers: aprantl, jingham. Herald added subscribers: JDevlieghere, eraman. This changes the way we store the debug info variant to make it available earlier in the test bringup: instead of it being set by the test wrapper method, it is set as a *propert

[Lldb-commits] [PATCH] D42836: [dotest] make debug info variant accessible in setUp()

labath updated this revision to Diff 132557. labath added a comment. Move getDebugInfo definition to "Base" class (fixes lldb-mi tests). https://reviews.llvm.org/D42836 Files: packages/Python/lldbsuite/test/decorators.py packages/Python/lldbsuite/test/functionalities/exec/TestExec.py pack

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath added inline comments. Comment at: packages/Python/lldbsuite/test/api/listeners/TestListener.py:26 TestBase.setUp(self) -self.build() aprantl wrote: > labath wrote: > > I'm confused by these changes. I was under the impression that setUp

[Lldb-commits] [PATCH] D42836: [dotest] make debug info variant accessible in setUp()

labath added a comment. In https://reviews.llvm.org/D42836#996288, @aprantl wrote: > That looks great, to make sure I understand this correctly, is the following > accurate? > > If we apply this on top of https://reviews.llvm.org/D42763, and we have > > tests/my/testA.py: > class TestA(Bas

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

labath accepted this revision. labath added a comment. Looks fine, just a couple of tweaks to the test case. No need to wait for another round of review. Comment at: packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py:17 +TestBase.

[Lldb-commits] [PATCH] D42836: [dotest] make debug info variant accessible in setUp()

This revision was automatically updated to reflect the committed changes. Closed by commit rL324226: [dotest] make debug info variant accessible in setUp() (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42836 Files:

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. In https://reviews.llvm.org/D42145#996575, @owenpshaw wrote: > - adjust WriteObjectFile signature to return Status and take an std::vector > - match project formatting style > > I toyed with adding allow_flash to as an argument, but didn't really like > it because it se

[Lldb-commits] [PATCH] D42870: Correct recognition of NetBSD images

labath added a comment. Extending lldb-test's dumpModules() to also dump out the module's triple sounds like a reasonable thing to do (I am assuming that the Module class will do something reasonable when given an object file with no sections, like a core file -- if not we could make a separate

[Lldb-commits] [PATCH] D42908: Fix Bug 36237 - TestTargetSymbolsSepDebugSymlink fails when run remotely

labath added a comment. >> I think that a more reasonable behavior here would be to copy the file >> contents instead. > The symlink is essential for this testcase otherwise it does not test the > bugfix. OK to just disable it for remote testing? My comment you are quoting should applies to

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

labath created this revision. labath added a reviewer: jankratochvil. The test was failing in remote debugging scenario with windows as a host as cmd.exe is not able to parse the complicated shell commands in the Makefile. The test seemed like a perfect candidate for a more focused testing approa

[Lldb-commits] [PATCH] D42939: More correct handling of error cases C++ name parser

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Being more resilient when handling demangler outputs seems like a good thing, but I think it is important to understand what made the demangler produce that output in the first place, to make

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks much better. Thanks. https://reviews.llvm.org/D42763 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

labath added a comment. As I mentioned in the patch above, I don't think it's worth it trying to tiptoe here, as for 99% of files (basically, anything that is not yaml2obj's output, I think), we will end up reading the whole file anyway. It just increases the number of things that can go wrong.

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

labath added a comment. Heh, no good deed goes unpunished, right.. :) It occured to me that this could be testable using the existing `lldb-test module-sections` functionality (I don't need to use a symbol, I can easily use a section name to recognise that a debug info was loaded from the other

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath created this revision. labath added reviewers: clayborg, jingham, davide. Herald added a subscriber: emaste. The result of Module::GetSectionList depended on whether the symbol vendor has been loaded (which would augment the section list with the extra sections that have been found by the v

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added inline comments. Comment at: tools/lldb-test/lldb-test.cpp:75 ModuleSpec Spec{FileSpec(File, false)}; -Spec.GetSymbolFileSpec().SetFile(File, false); The expliciting symbol filespec setting was short-circuiting the regular search process.

[Lldb-commits] [PATCH] D42959: Rewrite the flaky test_restart_bug test in a more deterministic way

labath created this revision. labath added a reviewer: owenpshaw. Herald added a subscriber: srhines. The test was trying to reproduce a bug in handling of two concurrent events, which was impossible to do reliably in a black-box style test. In practice, this meant the test was only ever failing o

[Lldb-commits] [PATCH] D42990: Add CMAKE_CFG_INTDIR as part of the include path for the default test compiler.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good. Technically, this is a property of the cmake generator (VS projects), and not the host system (windows), but I get what you mean.. Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows

labath added a comment. In https://reviews.llvm.org/D42994#999891, @zturner wrote: > In the future when you upload diffs can you include context? (i.e. `git diff > -U99`). It's nice to be able to see the surrounding code when I'm > looking at a diff. > > Is there ever a case where you wou

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:307-308 "@add_test_categories can only be used to decorate a test method") if hasattr(func, "categories"): cat.extend(func.categories) +# Fo

[Lldb-commits] [PATCH] D43059: Add implementation for MSVC in CPlusPlusLanguage::IsCPPMangledName

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. That seems extremely dodgy. Surely whether something is a mangled name does not depend on the compiler we built lldb with. I am aware that we have many places with _Z hardcoded, but

[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows

labath added inline comments. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:550 #-- $(DYLIB_OBJECTS) : CFLAGS += -DCOMPILING_LLDB_TEST_DLL I think Zachary meant only when bui

[Lldb-commits] [PATCH] D42959: Rewrite the flaky test_restart_bug test in a more deterministic way

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL324590: Rewrite the flaky test_restart_bug test in a more deterministic way (authored by labath, committed by ). Herald ad

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

labath added a comment. The change seems fine to me, and I don't really have anything to add to the things that were said already. Testing the completion of things that require a target/module/etc. will be a bit tricky, but that's something we should figure out anyway to have more targeted com

[Lldb-commits] [PATCH] D43076: llgs-test: Parse and store register info recieved from lldb-server

labath created this revision. labath added reviewers: eugene, davide. Right now the test client is not parsing register values correctly, which is manifesting itself in one test failing on 32-bit architectures (pr36013). This parses the information from the qRegisterInfo packets and stores it in t

[Lldb-commits] [PATCH] D43076: llgs-test: Parse and store register info recieved from lldb-server

This revision was automatically updated to reflect the committed changes. Closed by commit rL324722: llgs-test: Parse and store register info recieved from lldb-server (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43

[Lldb-commits] [PATCH] D43099: Make LLDB's clang module cache path customizable

labath added a comment. There are several components in the "command line parsing" 1. argparse: parsing a single string into the individual words (processing quotes, backslashes, etc.) 2. resolving the "command" part of the command line (the "frame variable" part of "frame variable --raw-output

[Lldb-commits] [PATCH] D43096: [lit] Update how clang and other binaries are found in per-configuration directories

labath added inline comments. Comment at: CMakeLists.txt:73-80 + if ("${LLDB_TEST_C_COMPILER}" STREQUAL "") +set(LLDB_TESTING_DEFAULT_C_COMPILER ON) + endif() + + if ("${LLDB_TEST_CXX_COMPILER}" STREQUAL "") +set(LLDB_TESTING_DEFAULT_CXX_COMPILER ON) + endif() ---

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

labath added a comment. (Btw, if you're looking for things to FileCheck-ify, I think the stuff under `lldb/unittests/UnwindAssembly` is a prime candidate and has a much higher bang/buck ratio.) https://reviews.llvm.org/D43048 ___ lldb-commits mail

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added inline comments. Comment at: source/Core/Module.cpp:1286 +if (SymbolVendor *vendor = GetSymbolVendor()) + vendor->CreateSections(*GetUnifiedSectionList()); } clayborg wrote: > should we pass "obj_file" down into the SymbolVendor::CreateSe

[Lldb-commits] [PATCH] D43292: [dotest] Add ability to skip tests based on build configuration

labath created this revision. labath added reviewers: zturner, jingham, davide. Herald added a subscriber: mgorny. Some lldb features depend on xml support. Tests exercising that functionality can only succeed if lldb was built with xml support. Right now we have one such test, and another waiting

[Lldb-commits] [PATCH] D43333: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test

labath created this revision. labath added reviewers: zturner, jingham, clayborg, davide. This adds a SBDebugger::GetBuildConfiguration static function, which returns a SBStructuredData describing the the build parameters of liblldb. Right now, it just contains one entry: whether we were built wit

[Lldb-commits] [PATCH] D43335: [dosep] Run tests in a more parallel fashion

labath created this revision. labath added a reviewer: aprantl. Due to in-tree builds, we were parallelizing the tests at the directory level. Now that the tests are built out-of-tree, we can remove this limitation and paralelize at file level instead. This decreases test suite time by about 10%

[Lldb-commits] [PATCH] D43333: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test

labath updated this revision to Diff 134564. labath added a comment. I've updated the format to include a description of the item. I don't we need to worry about the expensiveness of this data structure too much, as it should never be used in a hot loop (the only use case I can think of is queryin

[Lldb-commits] [PATCH] D43335: [dosep] Run tests in a more parallel fashion

This revision was automatically updated to reflect the committed changes. Closed by commit rL325322: [dosep] Run tests in a more parallel fashion (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43335 Files: lldb/tru

[Lldb-commits] [PATCH] D43292: [dotest] Add ability to skip tests based on build configuration

labath abandoned this revision. labath added a comment. It looks like we'll do something like https://reviews.llvm.org/D4 instead... https://reviews.llvm.org/D43292 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/

[Lldb-commits] [PATCH] D43376: Fix TestStopReplyContainsThreadPcs on 32-bit x86 (pr36013)

labath created this revision. labath added reviewers: eugene, davide. The issue was that we were parsing the registers into 64-bit integers and the calling swapByteOrder without regard for the actual size of the register. This switches the test to use the RegisterValue class which tracks the regis

[Lldb-commits] [PATCH] D43419: Fix TestBreakpointInGlobalConstructor for Windows

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Yeah, setting this to zero would break other platforms that are able to locate shared libraries before running the executable. On linux, we try to locate them as well, but it's kind

[Lldb-commits] [PATCH] D43464: Avoid dirtying the source tree in breakpoint command tests

labath created this revision. labath added reviewers: jingham, aprantl. The paralelization patch exposed a bunch of cases where we were still touching the source tree (as these tests were now stepping on each others toes and being flaky). This patch removes such issues from breakpoint command tes

[Lldb-commits] [PATCH] D43333: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test

This revision was automatically updated to reflect the committed changes. Closed by commit rL325504: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D43376: Fix TestStopReplyContainsThreadPcs on 32-bit x86 (pr36013)

This revision was automatically updated to reflect the committed changes. Closed by commit rL325511: Fix TestStopReplyContainsThreadPcs on 32-bit x86 (pr36013) (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43376 Fil

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

labath added a comment. Seems straight-forward enough, but technically Jim is the owner of the expression evaluator these days, so I'll leave the honours to him. Comment at: packages/Python/lldbsuite/test/expression_command/test/TestExprs.py:270 +# output: (typeof (i)

[Lldb-commits] [PATCH] D43464: Avoid dirtying the source tree in breakpoint command tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL325570: Avoid dirtying the source tree in breakpoint command tests (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43464 Fil

[Lldb-commits] [PATCH] D43506: Fix a couple of more tests to not create files in the source tree

labath created this revision. labath added reviewers: davide, aprantl. These were not being flaky, but they're still making the tree dirty. These tests were using lldbutil.append_to_process_working_directory to derive the file path so I fix them by modifying the function to return the build direc

[Lldb-commits] [PATCH] D43419: Fix TestBreakpointInGlobalConstructor for Windows

labath added a comment. I was actually thinking of making this unconditional. It makes the behaviour easier to understand and this test really does not care about whether the libraries were resolved statically or not. I'm with Jim that we should make targeted tests for that functionality. htt

<    3   4   5   6   7   8   9   10   11   12   >