labath added a comment.

I like the direction this is going in. When looking at this, it occurred to me 
some of our tests do recursive make invocations, generally to build shared 
libraries (TestConflictingSymbol is a good example). The $(MAKE) line in those 
may need to be fixed somehow.



================
Comment at: packages/Python/lldbsuite/test/dotest.py:1195
+    if configuration.test_build_dir:
+        try: os.makedirs(configuration.test_build_dir, 448)
+        except: pass
----------------
Can we just not specify the mode and let user's umask do the selection. That's 
the standard behaviour of all unix tools.


================
Comment at: packages/Python/lldbsuite/test/plugins/builder_base.py:69
+            "-I", test_dir,
+            "-f", os.path.join(test_dir, "Makefile")]
 
----------------
I like this trick. :)
Originally, I was afraid we'd have to copy the Makefile to the build folder or 
something...


https://reviews.llvm.org/D42281



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to