labath planned changes to this revision.
labath added inline comments.

================
Comment at: source/Host/linux/Host.cpp:129
+  auto buffer_sp = DataBufferLLVM::CreateSliceFromPath(exe_path, 0x20, 0);
+  if (buffer_sp)
+    return ArchSpec();
----------------
eugene wrote:
> Shouldn't it be
> 
> ```
> if (!buffer_sp)
> ```
> 
> ?
Indeed it should. Thanks.
I'll have to figure out tomorrow why the test still passed... :/


https://reviews.llvm.org/D42488



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to