labath added a comment. Thank you for making the changes. The parsing code looks much cleaner now. I just have one more round of tiny remarks.
================ Comment at: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py:241 + self.port = self._socket.getsockname()[1] + self._socket.listen(0) + self._thread = threading.Thread(target=self._run) ---------------- You've deleted closing of the listening socket altogether (I just wanted you to delete the comment). The socket itself needs to be closed, of course, I just don't think calling shutdown on it is needed. ================ Comment at: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py:400 + temp_files = None + process = None + ---------------- There's already a `TestBase.process()` that should do what you need. https://reviews.llvm.org/D42195 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
