labath added a comment.

I'll leave it up to others to say whether this solution is fully correct, but I 
have to say that it looks much cleaner than the previous one.



================
Comment at: 
packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile:1-17
+.PHONY : all
+.PHONY : clean
+all: main
+
+CCFLAGS=-O0 -g
+
+a.o : a.c
----------------
Could you convert this Makefile to use the standard `Makefile.rules` like other 
tests do. This will make sure it gets all the command line arguments it needs 
for e.g. a cross-compile. The magic syntax you'll need for compiling one file 
with extra compiler arguments is:
```
a.o: CFLAGS_EXTRAS += -gsplit-dwarf
```
(have a look at TestConflictingSymbol  to see it in action).


https://reviews.llvm.org/D42563



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to