[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid updated this revision to Diff 305680. omjavaid added a comment. This update tries to fix concerns raised by removing AArch64 specific code and makes offset assignment more generic. We now have a new flag which is set to true if offset field was present and on basis of that we assign of

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2397083 , @labath wrote: > I disagree, and my main reason for that is that this approach requires > hardcoding the "supported architectures" for which we do this fixup in the > DynamicRegisterInfo class. Besides being

[Lldb-commits] [PATCH] D91422: [lldb] [Process/FreeBSDRemote] Check for regset support early [WIP]

omjavaid added a comment. In D91422#2396697 , @labath wrote: > My guess is that this is because of the extra debug registers that you're > exposing. You'll notice that Get(User)RegisterSetCount returns just a number, > and this means that it is not reall

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:60-78 +static int runCallback(lua_State *L) { + LuaCallback *callback = static_cast(lua_touserdata(L, -1)); + return (*callback)(L); +} + +llvm::Error Lua::Run(LuaCallback &callback) {

[Lldb-commits] [PATCH] D91612: [lldb] Fix a couple of remote llgs tests

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. init_llgs_test no longer takes an argument but these two were not updated. Also fix some mistakes i

[Lldb-commits] [PATCH] D91612: [lldb] Fix a couple of remote llgs tests

DavidSpickett added a reviewer: JDevlieghere. DavidSpickett added a comment. I presume these tests aren't commonly run or have been masked by the expected failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91612/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D91612: [lldb] Fix a couple of remote llgs tests

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. For reference the argument was removed in: https://reviews.llvm.org/D90313 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91612/new/ https://reviews.llvm.org/D91612

[Lldb-commits] [PATCH] D91057: [LLDB] Update SVE Z reg info to remove invalidate regs

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcca6fe93f04: [LLDB] Update SVE Z reg info to remove invalidate regs (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] fcca6fe - [LLDB] Update SVE Z reg info to remove invalidate regs

Author: Muhammad Omair Javaid Date: 2020-11-17T17:14:44+05:00 New Revision: fcca6fe93f04f50c302f9ce2d1bad8f5f3fa369a URL: https://github.com/llvm/llvm-project/commit/fcca6fe93f04f50c302f9ce2d1bad8f5f3fa369a DIFF: https://github.com/llvm/llvm-project/commit/fcca6fe93f04f50c302f9ce2d1bad8f5f3fa36

[Lldb-commits] [lldb] 661e404 - [LLDB] Fix SVE reginfo for sequential offset in g packet

Author: Muhammad Omair Javaid Date: 2020-11-17T17:18:34+05:00 New Revision: 661e4040ac60b3df06b2495ea916302b35d9bac2 URL: https://github.com/llvm/llvm-project/commit/661e4040ac60b3df06b2495ea916302b35d9bac2 DIFF: https://github.com/llvm/llvm-project/commit/661e4040ac60b3df06b2495ea916302b35d9ba

[Lldb-commits] [PATCH] D90741: [LLDB] Fix SVE reginfo for sequential offset in g packet

This revision was automatically updated to reflect the committed changes. Closed by commit rG661e4040ac60: [LLDB] Fix SVE reginfo for sequential offset in g packet (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

aarzilli added a comment. I don't want to be overbearing but should I be doing something else? Is this going to be merged and, if it is, what timeline should I expect? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89315/new/ https://reviews.llvm.org/D89315

[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. Previously if you did: $ lldb-server platform --server <...> --min-gdbserver-port 12346 --max-gdbser

[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

DavidSpickett added a comment. I have found existing tests that launch an lldb-server with specific arguments, using an existing lldb-server platform to do it. The ideal test would be: - run lldb-server with min port some known to be available port, max is that +1 - connect the client - send qL

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

JDevlieghere added a comment. In D91508#2396392 , @tammela wrote: > @JDevlieghere > > When writing this patch I noticed that there is no mechanism in-place to > remove the Python/Lua function when the breakpoint is removed or when the > callback function

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

JDevlieghere added a comment. This looks good with Pavel's comments addressed and an integration test added for the breakpoint callback. (Watchpoints are not supported everywhere and it's hard to determine whether they are from a Shell test). Comment at: lldb/bindings/lua/lua

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

JDevlieghere added a comment. In D89315#2399805 , @aarzilli wrote: > I don't want to be overbearing but should I be doing something else? Is this > going to be merged and, if it is, what timeline should I expect? I think nobody realized you didn't have c

[Lldb-commits] [lldb] 27012c0 - [debugserver] Add option to propagate SIGSEGV to target process

Author: Alessandro Arzilli Date: 2020-11-17T09:27:52-08:00 New Revision: 27012c0f75c2e4891277d0d14f9f97a9f564d596 URL: https://github.com/llvm/llvm-project/commit/27012c0f75c2e4891277d0d14f9f97a9f564d596 DIFF: https://github.com/llvm/llvm-project/commit/27012c0f75c2e4891277d0d14f9f97a9f564d596.

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

This revision was automatically updated to reflect the committed changes. Closed by commit rG27012c0f75c2: [debugserver] Add option to propagate SIGSEGV to target process (authored by aarzilli, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D91612: [lldb] Fix a couple of remote llgs tests

labath accepted this revision. labath added a comment. In D91612#2399408 , @DavidSpickett wrote: > I presume these tests aren't commonly run or have been masked by the expected > failures. Yes, that seems to be the case, though I don't actually see a re

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I'll have more questions about this, but probably won't get around to asking them today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Restrict i386-specific XFAIL on a few tests to non-FreeBSD systems, as they pass on FreeBSD. https://reviews.llvm.org/D91645 Files

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 305874. tammela marked 4 inline comments as done and an inline comment as not done. tammela added a comment. Adressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:200 + Debugger &debugger = target->GetDebugger(); + ScriptInterpreterLua *lua_interpreter = + static_cast(debugger.GetScriptInterpreter()); labat

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added a comment. In D91508#2400222 , @JDevlieghere wrote: > In D91508#2396392 , @tammela wrote: > >> @JDevlieghere >> >> When writing this patch I noticed that there is no mechanism in-place to >> remove t

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

emaste added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:19 -@expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532") +@expectedFailureAll(archs=['i386'], +oslist=no_match(["freebsd"]), Int

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace created this revision. wallace added a reviewer: clayborg. Herald added subscribers: lldb-commits, dang. Herald added a project: LLDB. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. This implements the interactive trace start and stop methods. There's

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

clayborg added a comment. LGTM. A few inline nits, but nothing major. I only question if "RecordedProcess" is the right name for the base class for a core file/trace file, but don't have much of a better name. Maybe SerializedProcess? SavedProcess? Don't we usually have Pavel in on these review

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So I think I get the gist of what you were trying to go for with this patch. I stopped inline comments after I got the idea. A few things: We need to be able to enable tracing o