JDevlieghere added a comment. This looks good with Pavel's comments addressed and an integration test added for the breakpoint callback. (Watchpoints are not supported everywhere and it's hard to determine whether they are from a Shell test).
================ Comment at: lldb/bindings/lua/lua-wrapper.swig:29 + + lua_call(L, 2, 1); + ---------------- Might be nice to add a comment to explain the "magic values" here. ================ Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:27 +using LuaCallback = std::function<int(lua_State *L)>; + ---------------- Let's move this into the `Lua` class (and rename it to `Callback`) so we don't taint every CU that includes this file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
