Author: ovyalov
Date: Fri Aug 5 19:42:23 2016
New Revision: 277895
URL: http://llvm.org/viewvc/llvm-project?rev=277895&view=rev
Log:
Fix Windows build - add return statement in
SBThread::StepUsingScriptedThreadPlan.
Modified:
lldb/trunk/source/API/SBThread.cpp
Modified: lldb/trunk/source/A
Author: ovyalov
Date: Thu Jul 21 12:03:25 2016
New Revision: 276303
URL: http://llvm.org/viewvc/llvm-project?rev=276303&view=rev
Log:
Add check for non-null log instance in PlatformAndroid.
Modified:
lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
Modified: lldb/trunk/source/
Author: ovyalov
Date: Tue Jul 12 13:14:27 2016
New Revision: 275198
URL: http://llvm.org/viewvc/llvm-project?rev=275198&view=rev
Log:
Add logging to Linux Host::GetProcessAndStatInfo.
Modified:
lldb/trunk/source/Host/linux/Host.cpp
Modified: lldb/trunk/source/Host/linux/Host.cpp
URL:
http:/
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
Users:
ovyalov (Author)
http://reviews.llvm.or
Author: ovyalov
Date: Fri Jul 8 12:45:37 2016
New Revision: 274895
URL: http://llvm.org/viewvc/llvm-project?rev=274895&view=rev
Log:
Use shell cat command as a workaround if ADB stat cannot lookup a file.
http://reviews.llvm.org/D22081
Modified:
lldb/trunk/source/Plugins/Platform/Android/A
ovyalov updated this revision to Diff 63255.
ovyalov added a comment.
Reran with proper clang-format.
http://reviews.llvm.org/D22081
Files:
source/Plugins/Platform/Android/AdbClient.cpp
source/Plugins/Platform/Android/AdbClient.h
source/Plugins/Platform/Android/PlatformAndroid.cpp
Index:
ovyalov added a comment.
In http://reviews.llvm.org/D22081#477746, @labath wrote:
> Thanks for adding the additional checks. Looks good apart from the
> clang-format changes. This looks like the llvm style. I am not sure how
> you've run this but it does not seem to have picked up LLDB's `.clan
ovyalov added a comment.
In http://reviews.llvm.org/D22081#476766, @labath wrote:
> You raised good points here, Luke.
>
> I've thought about the quoting issue, but as you have already noticed there
> is no way to pass arguments containing quotes to adb correctly. Thinking
> about it more, what
ovyalov updated this revision to Diff 63173.
ovyalov added a comment.
Addressed review comments:
- Check whether shell command output starts with /system/bin/sh: in order to
find out whether command failed
- Fail-fast download if filename contains single-quotes
- clang-format
http://reviews.ll
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D22052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov created this revision.
ovyalov added reviewers: tberghammer, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
adbd may fail to access a file due security constraints - in such case
sync:stat command returns file's mode as 0. If it's the c
ovyalov added inline comments.
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:71
@@ +70,3 @@
+{
+if (const char *android_serial = std::getenv("ANDROID_SERIAL"))
+adb.SetDeviceID(android_serial);
Could you check whethe
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
/lldb/trunk/source/Plugins/Platform/Android/Platf
Author: ovyalov
Date: Wed Jul 6 12:02:42 2016
New Revision: 274638
URL: http://llvm.org/viewvc/llvm-project?rev=274638&view=rev
Log:
Fix ADB client disconnect issues.
http://reviews.llvm.org/D22029
Modified:
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
lldb/trunk/source/Plu
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D22040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
Author: ovyalov
Date: Tue Jul 5 21:20:39 2016
New Revision: 274594
URL: http://llvm.org/viewvc/llvm-project?rev=274594&view=rev
Log:
Fix Linux build.
Modified:
lldb/trunk/source/Core/UserSettingsController.cpp
Modified: lldb/trunk/source/Core/UserSettingsController.cpp
URL:
http://llvm.or
ovyalov created this revision.
ovyalov added reviewers: labath, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
- Disconnect SyncService in case of pull/push/stat request failure and make
Android platform to establish new ADB syn
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
/lldb/trunk/source/Plugins/Platform/Android/Platf
Author: ovyalov
Date: Thu Jun 30 13:10:27 2016
New Revision: 274256
URL: http://llvm.org/viewvc/llvm-project?rev=274256&view=rev
Log:
Improve ADB utilization within Android platform.
http://reviews.llvm.org/D21770
Modified:
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
lldb/t
ovyalov added a comment.
If you okay with that I'd like to submit this CL as-is and come up with unit
test with a separate change list.
http://reviews.llvm.org/D21770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
ovyalov added a comment.
In http://reviews.llvm.org/D21770#469876, @labath wrote:
> Is AdbClient getting big enough to deserve a couple of unit tests? All it
> would take is to add the ability to specify the address to connect to and
> make a small mock server that listens at that address?
It
ovyalov created this revision.
ovyalov added reviewers: labath, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
- Extract sync commands like push/pull file and stat into SyncService so ADB
connection that's switched in sync mode can be reu
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D21680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov added a comment.
In http://reviews.llvm.org/D16861#441964, @tfiala wrote:
> This change broke connection to debugserver on OS X - the constructed URL on
> debugserver does not take the tcp:// (URL-scheme) portion. This would
> manifest when 'lldb-server platform' was attempting to laun
ovyalov closed this revision.
ovyalov added a comment.
Submitted as r270590
http://reviews.llvm.org/D20548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Tue May 24 13:09:05 2016
New Revision: 270590
URL: http://llvm.org/viewvc/llvm-project?rev=270590&view=rev
Log:
Replace file system forbidden symbols in the hostname which passed to the
ModuleCache.
http://reviews.llvm.org/D20548
Modified:
lldb/trunk/source/Utility/Mo
ovyalov accepted this revision.
Comment at: unittests/Utility/ModuleCacheTest.cpp:74
@@ +73,3 @@
+{
+HostInfo::Initialize();
+ObjectFileELF::Initialize();
If it's one-off initialization can we use setUpTestCase for these purposes (for
HostInfo::Initialize
ovyalov added a comment.
In http://reviews.llvm.org/D20548#437862, @clayborg wrote:
> At some point we should probably make a host layer call like:
>
> const char *const char *Host::GetIllegalFilenameCharacters();" so that each
> host can determine the correct thing for the current host. Then Fi
ovyalov added a comment.
In http://reviews.llvm.org/D20548#437567, @labath wrote:
> According to
> https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396,
> characters with codes 1..31 (basically `< ' '`), are illegal as well. We
> might
ovyalov updated this revision to Diff 58258.
ovyalov added a comment.
Added the check for symbol in [1;31] range.
http://reviews.llvm.org/D20548
Files:
source/Utility/ModuleCache.cpp
Index: source/Utility/ModuleCache.cpp
===
---
ovyalov updated this revision to Diff 58180.
ovyalov added a comment.
Added asterisk symbol
http://reviews.llvm.org/D20548
Files:
source/Utility/ModuleCache.cpp
Index: source/Utility/ModuleCache.cpp
===
--- source/Utility/Module
ovyalov created this revision.
ovyalov added reviewers: labath, clayborg.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
ModuleCache hostname may contain symbols that are not allowed in filenames -
for example, in Android device_id is used as a hostna
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
Looks like this CL broke CMake build bot -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14634,
could you take a look?
Repository:
rL LLVM
http://reviews.llvm.org/D19124
__
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D19916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov added a comment.
LGTM
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:37
@@ -36,3 +36,3 @@
-const uint32_t kReadTimeout = 100; // 1 second
+const uint32_t kReadTimeout = 400; // 4 seconds
const char * kOKAY = "OKAY";
It might be usef
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:103
@@ +102,3 @@
+AddCXXSynthetic(g_category,
lldb_private::formatters::JavaArraySyntheticFrontEn
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D19557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Sat Apr 16 11:29:17 2016
New Revision: 266530
URL: http://llvm.org/viewvc/llvm-project?rev=266530&view=rev
Log:
Fix cmake build after r266524.
Modified:
lldb/trunk/source/Core/RegisterValue.cpp
Modified: lldb/trunk/source/Core/RegisterValue.cpp
URL:
http://llvm.org/vi
Author: ovyalov
Date: Thu Apr 14 19:56:11 2016
New Revision: 266401
URL: http://llvm.org/viewvc/llvm-project?rev=266401&view=rev
Log:
Rename out->std_out in AppleObjCRuntimeV2.cpp.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Modified:
l
ovyalov added a comment.
In http://reviews.llvm.org/D19092#401450, @jingham wrote:
> Why is this necessary? stdout is a local variable defined in this scope.
> Why would the android g++ have problems with this?
>
> Anyway, if you have to avoid using stdout as a name, maybe name it std_out as
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL266274
http://reviews.llvm.org/D19092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Wed Apr 13 21:02:12 2016
New Revision: 266274
URL: http://llvm.org/viewvc/llvm-project?rev=266274&view=rev
Log:
Fix Android build after r266267
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Modified:
lldb/trunk/sourc
ovyalov created this revision.
ovyalov added a reviewer: granata.enrico.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Fix Android build after r266267
http://reviews.llvm.org/D19092
Files:
source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleO
Author: ovyalov
Date: Tue Apr 12 23:21:05 2016
New Revision: 266164
URL: http://llvm.org/viewvc/llvm-project?rev=266164&view=rev
Log:
Attempt to fix TestCPPBreakpointLocations on Linux/Android.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/TestCPPBreakpo
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11
@@ -10,2 +10,3 @@
+#include
#include
#include
You may remove iostream si
ovyalov added a comment.
In http://reviews.llvm.org/D18886#397637, @amccarth wrote:
> FYI: According to git bisect, this patch seems to have introduced a new test
> failure on Windows.
Thanks for the report - will fix today.
http://reviews.llvm.org/D18886
Author: ovyalov
Date: Fri Apr 8 22:08:02 2016
New Revision: 265869
URL: http://llvm.org/viewvc/llvm-project?rev=265869&view=rev
Log:
Fix TestBreakpointSetRestart failure on Android.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/TestBr
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL265843
http://reviews.llvm.org/D18886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Fri Apr 8 15:44:28 2016
New Revision: 265843
URL: http://llvm.org/viewvc/llvm-project?rev=265843&view=rev
Log:
Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.
http://reviews.llvm.org/D18886
Added:
lldb/trunk/packages/Python/lldbsuite/test/fun
ovyalov added a comment.
In http://reviews.llvm.org/D18886#395216, @labath wrote:
> Does this fix an existing test or is a new issue? If it's new (it sounds like
> it is, as I don't see any test failures), could you also add a test for this.
> It shouldn't be too difficult to write one... Would
ovyalov updated this revision to Diff 53054.
ovyalov added a comment.
Added new TestBreakpointSetRestart test to cover the addressed issue.
http://reviews.llvm.org/D18886
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/Makefile
packages/Python/lldbs
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Reset continue_after_async only if neither SIGINIT nor SIGSTOP received -
otherwise it leads to stopped inferior when setting breakpoint (when
m_interrupt_sent == true and signal is SIGST
ovyalov accepted this revision.
ovyalov added a comment.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D18858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Thu Feb 25 22:01:58 2016
New Revision: 261974
URL: http://llvm.org/viewvc/llvm-project?rev=261974&view=rev
Log:
Make TestPlatformProcessConnect to support abstract/domain sockets.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/platform-process-co
ovyalov accepted this revision.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:35
@@ +34,3 @@
+lldb::TypeSP
+DWARFASTParserJava::ParseTypeFromDWARF(const lldb_private::SymbolContext &sc,
const DWARFDIE &die,
+ lldb_private
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D17604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Linux/NativeThreadLinux.cpp:250
@@ +249,3 @@
+log->Printf("NativeThreadLinux::%s Unable to get cpu affinity for
thread %" PRIx64 ": %s", __FUNCTION__,
+
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17510
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D17131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
ovyalov added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py:22
@@ -20,1 +21,3 @@
+# Backtracing failed due to lack of prolog/epilog informations in assert
function of libc.so.6
+@expectedFailureAll(tripl
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL259714
http://reviews.llvm.org/D16861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Wed Feb 3 16:02:43 2016
New Revision: 259714
URL: http://llvm.org/viewvc/llvm-project?rev=259714&view=rev
Log:
Pass socket scheme as part of debug server listen URL.
http://reviews.llvm.org/D16861
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommun
ovyalov created this revision.
ovyalov added reviewers: sivachandra, tberghammer.
ovyalov added a subscriber: lldb-commits.
Pass socket scheme as part of debug server listen URL in order to fix custom
protocols like unix-abstract.
http://reviews.llvm.org/D16861
Files:
source/Plugins/Process/g
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D16720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL258150
http://reviews.llvm.org/D16244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Tue Jan 19 11:54:47 2016
New Revision: 258150
URL: http://llvm.org/viewvc/llvm-project?rev=258150&view=rev
Log:
Implementing the method Target::TargetEventData::Dump (Stream *s) so that its
clients can easily dump it out for informational messages.
http://reviews.llvm.org/D
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D16244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov added a comment.
If vdso bug pertains to ELF format then it looks reasonable to keep the fix
within ObjectFileELF.
I experimented a while ago with making ObjectFileELF to read from arbitrary
offsets - please see http://reviews.llvm.org/D16151 as reflection of this idea
(patch is pretty
ovyalov added a comment.
vdso issue is related to ELF format and I'm wondering whether we can keep the
fix contained in ObjectFileELF - for example, if a section that we're trying to
read is beyond the boundaries of memory buffer we can read its content from
inferior's memory using ObjectFile::
ovyalov accepted this revision.
Comment at:
packages/Python/lldbsuite/test/python_api/disassemble-raw-data/TestDisassembleRawData.py:29
@@ +28,3 @@
+elif re.match("mips",arch):
+ target = self.dbg.CreateTargetWithFileAndTargetTriple ("", "mips")
+
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:973
@@ +972,3 @@
+{
+// PTRACE_PEEKUSER don't work in the aarch64 liux kernel used on android
devices (always return
+
Author: ovyalov
Date: Fri Dec 11 20:13:17 2015
New Revision: 255419
URL: http://llvm.org/viewvc/llvm-project?rev=255419&view=rev
Log:
Remove unused mips typedefs.
Modified:
lldb/trunk/source/Plugins/Process/Linux/Procfs.h
Modified: lldb/trunk/source/Plugins/Process/Linux/Procfs.h
URL:
http
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
Comment at: cmake/platforms/Android.cmake:124
@@ -123,1 +123,3 @@
+# Use gold linker and enable safe ICF in case of x86, x86_64 and arm
+if ( ANDROID_ABI STREQUAL "x86"OR
Just out of curiosity -
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL254638
http://reviews.llvm.org/D15172
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Thu Dec 3 13:41:21 2015
New Revision: 254638
URL: http://llvm.org/viewvc/llvm-project?rev=254638&view=rev
Log:
Fix in-memory section loading for JIT-ed code.
http://reviews.llvm.org/D15172
Modified:
lldb/trunk/source/Symbol/ObjectFile.cpp
Modified: lldb/trunk/source/
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Debug sections for JIT-ed code are stored in-memory and loaded as part of
module's image once __jit_debug_register_code is called -
if we cannot load a section by its base loa
ovyalov closed this revision.
ovyalov added a comment.
Submitted as r250474
http://reviews.llvm.org/D13754
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
Users:
ovyalov (Author)
http://reviews.llvm.org/rL253906
http://reviews.llvm.org/D14895
_
Author: ovyalov
Date: Mon Nov 23 13:32:24 2015
New Revision: 253906
URL: http://llvm.org/viewvc/llvm-project?rev=253906&view=rev
Log:
Prevent ProcessGDBRemote from launching local debug server in case of remote
debug server connection failure.
http://reviews.llvm.org/D14895
Modified:
lldb/
ovyalov updated this revision to Diff 40948.
ovyalov added a comment.
Addressed review comments - renamed the method to EstablishConnectionIfNeeded.
http://reviews.llvm.org/D14895
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
source/Plugins/Process/gdb-remote/ProcessGDBRemot
ovyalov created this revision.
ovyalov added reviewers: clayborg, labath.
ovyalov added a subscriber: lldb-commits.
If remote platform is used and we're losing remote debug server connection in
between Process::ConnectRemote and Process::Attach (in context of
PlatformRemoteGDBServer::Attach) cur
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D14816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: packages/Python/lldbsuite/test/lldbtest.py:464
@@ -463,3 +463,3 @@
parsed_url = urlparse.urlparse(lldb.platform_url)
-if parsed_url.scheme
ovyalov added a comment.
Please see my comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:464
@@ -463,3 +463,3 @@
parsed_url = urlparse.urlparse(lldb.platform_url)
-if parsed_url.scheme == "adb":
+if parsed_url.scheme in ["adb", "unix-abstr
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D14634
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
/lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/A
Author: ovyalov
Date: Mon Nov 2 19:37:01 2015
New Revision: 251879
URL: http://llvm.org/viewvc/llvm-project?rev=251879&view=rev
Log:
Provide ADB port forwarding support for abstract sockets.
http://reviews.llvm.org/D14262
Modified:
lldb/trunk/include/lldb/Host/posix/ConnectionFileDescripto
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL251871
http://reviews.llvm.org/D14264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Mon Nov 2 18:30:19 2015
New Revision: 251871
URL: http://llvm.org/viewvc/llvm-project?rev=251871&view=rev
Log:
Fix module cache sym links' creation for symbol files.
http://reviews.llvm.org/D14264
Modified:
lldb/trunk/source/Utility/ModuleCache.cpp
Modified: lldb/tru
ovyalov created this revision.
ovyalov added a reviewer: tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, aemerson.
Pass symbol file platform's file spec to ModuleCache::Put - i.e., to make sym
link path like this:
.lldb/module_cache/remot
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Provide ADB port forwarding support for abstract sockets.
http://reviews.llvm.org/D14262
Files:
include/lldb/Host/posix/Con
Author: ovyalov
Date: Mon Nov 2 14:04:18 2015
New Revision: 251825
URL: http://llvm.org/viewvc/llvm-project?rev=251825&view=rev
Log:
Calculate size of sockaddr_un manually for abstract sockets:
- SUN_LEN doesn't work because strlen(sun_path) == 0
- sizeof(sockaddr_un) doesn't work on Android.
ovyalov added a comment.
In http://reviews.llvm.org/D14118#277675, @ravitheja wrote:
> Hi,
>
> This link for the traces needs a password, could u maybe provide me the
> login details or upload these somewhere else ? Also could u provide me the
> value of the AuxVectors during this test ?
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D14166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
Author: ovyalov
Date: Wed Oct 28 17:21:02 2015
New Revision: 251563
URL: http://llvm.org/viewvc/llvm-project?rev=251563&view=rev
Log:
Remove unused SUN_LEN macro for Android.
Modified:
lldb/trunk/source/Host/posix/DomainSocket.cpp
Modified: lldb/trunk/source/Host/posix/DomainSocket.cpp
URL:
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h
/lldb/trunk/tools/lldb-server/Acceptor.cpp
/lldb/trun
Author: ovyalov
Date: Wed Oct 28 14:49:50 2015
New Revision: 251547
URL: http://llvm.org/viewvc/llvm-project?rev=251547&view=rev
Log:
Make lldb-gdbserver to take explicit socket scheme as command line argument.
http://reviews.llvm.org/D14126
Modified:
lldb/trunk/source/Plugins/Process/gdb-
ovyalov added a comment.
Greg, is it ok to submit the CL?
http://reviews.llvm.org/D14126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 193 matches
Mail list logo
