ovyalov accepted this revision. ================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:35 @@ +34,3 @@ +lldb::TypeSP +DWARFASTParserJava::ParseTypeFromDWARF(const lldb_private::SymbolContext &sc, const DWARFDIE &die, + lldb_private::Log *log, bool *type_is_new_ptr) ---------------- Please consider splitting this method in smaller sub-methods.
================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:519 @@ +518,1 @@ +} \ No newline at end of file ---------------- Please fix. http://reviews.llvm.org/D17616 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
