ovyalov accepted this revision.
This revision is now accepted and ready to land.
================
Comment at: source/Plugins/Process/Linux/NativeThreadLinux.cpp:250
@@ +249,3 @@
+ log->Printf("NativeThreadLinux::%s Unable to get cpu affinity for
thread %" PRIx64 ": %s", __FUNCTION__,
+ m_tid, strerror(errno));
+ return;
----------------
Could you use Error error(errno, eErrorTypePOSIX) instead of strerror here?
================
Comment at: source/Plugins/Process/Linux/SingleStepCheck.cpp:79
@@ +78,3 @@
+ }
+ return false;
+ }
----------------
Kill child before return?
================
Comment at: source/Plugins/Process/Linux/SingleStepCheck.h:41
@@ +40,2 @@
+
+#endif // #ifndef liblldb_NativeThreadLinux_H_
----------------
s/liblldb_NativeThreadLinux_H_/liblldb_SingleStepCheck_H_
http://reviews.llvm.org/D17509
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
