[Lldb-commits] [PATCH] D14264: Fix module cache sym links' creation for symbol files

[Oleksiy Vyalov via lldb-commits]

ovyalov created this revision.
ovyalov added a reviewer: tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, aemerson.

Pass symbol file platform's file spec to ModuleCache::Put  - i.e., to make sym 
link path like this: 
.lldb/module_cache/remote-android/04a2366b2238fb06/data/dalvik-cache/arm/system@framew...@boot.oat.sym

http://reviews.llvm.org/D14264

Files:
  source/Utility/ModuleCache.cpp

Index: source/Utility/ModuleCache.cpp
===================================================================
--- source/Utility/ModuleCache.cpp
+++ source/Utility/ModuleCache.cpp
@@ -304,13 +304,13 @@
         // contain the neccessary symbols and the debugging is also possible 
without a symfile.
         return Error ();
 
-    FileSpec symfile_spec = GetSymbolFileSpec (cached_module_sp->GetFileSpec 
());
-    error = Put (root_dir_spec, hostname, module_spec, 
tmp_download_sym_file_spec, symfile_spec);
+    error = Put (root_dir_spec, hostname, module_spec, 
tmp_download_sym_file_spec, GetSymbolFileSpec(module_spec.GetFileSpec ()));
     if (error.Fail ())
         return Error ("Failed to put symbol file into cache: %s", 
error.AsCString ());
     
     tmp_symfile_remover.releaseFile();
 
+    FileSpec symfile_spec = GetSymbolFileSpec (cached_module_sp->GetFileSpec 
());
     cached_module_sp->SetSymbolFileFileSpec (symfile_spec);
     return Error ();
 }



Index: source/Utility/ModuleCache.cpp
===================================================================
--- source/Utility/ModuleCache.cpp
+++ source/Utility/ModuleCache.cpp
@@ -304,13 +304,13 @@
         // contain the neccessary symbols and the debugging is also possible without a symfile.
         return Error ();
 
-    FileSpec symfile_spec = GetSymbolFileSpec (cached_module_sp->GetFileSpec ());
-    error = Put (root_dir_spec, hostname, module_spec, tmp_download_sym_file_spec, symfile_spec);
+    error = Put (root_dir_spec, hostname, module_spec, tmp_download_sym_file_spec, GetSymbolFileSpec(module_spec.GetFileSpec ()));
     if (error.Fail ())
         return Error ("Failed to put symbol file into cache: %s", error.AsCString ());
     
     tmp_symfile_remover.releaseFile();
 
+    FileSpec symfile_spec = GetSymbolFileSpec (cached_module_sp->GetFileSpec ());
     cached_module_sp->SetSymbolFileFileSpec (symfile_spec);
     return Error ();
 }

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits