Re: [Lldb-commits] [PATCH] D19540: Add support for displaying Java array types on Andorid

[Oleksiy Vyalov via lldb-commits]

ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:103
@@ +102,3 @@
+            AddCXXSynthetic(g_category, 
lldb_private::formatters::JavaArraySyntheticFrontEndCreator,
+                            "Java array synthetic children", 
ConstString("^.*\\[\\]&?$"),
+                            SyntheticChildren::Flags().SetCascades(true), 
true);
----------------
Could you define a constant for "^.*\\[\\]&?$" since it's used twice?


http://reviews.llvm.org/D19540



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits