[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Michael137 added a comment. In D159127#4655450 , @aprantl wrote: > @Mordante @Michael137 This seems to fail on older versions of > compiler/libcxx > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/7247/ You > can probably fix this by

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. Was looking at leftover reviews, would be nice to land this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159127/new/ https://reviews.ll

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. Also, I assume the extra changes to make the PointerIntPair formatter work will be in a follow-up patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.org/D156774 __

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4644503 , @Endill wrote: > Ping @Michael137 Sorry for the delay, just came back from vacation The change itself LGTM. Can we add a test though? We do have DWARFASTParserClang unittests: https://github.com/llvm/ll

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4601767 , @Endill wrote: > In D156774#4601736 , @Michael137 > wrote: > >> What were your lldb commands when you tested this? > > `script import lldb; frame = lldb.thread.Get

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4601705 , @Endill wrote: > I tested this patch together with the following new code: > > uint32_t TypeSystemClang::GetNumMemberEnums(lldb::opaque_compiler_type_t > type) { > using EnumIt = > clang::DeclContex

[Lldb-commits] [PATCH] D158172: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c3f1f42cbed: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D158172: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

Michael137 updated this revision to Diff 551086. Michael137 added a comment. - Reword commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158172/new/ https://reviews.llvm.org/D158172 Files: lldb/source/Plugins/ExpressionParser/Clang/Cla

[Lldb-commits] [PATCH] D158172: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a su

[Lldb-commits] [PATCH] D157992: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter

This revision was automatically updated to reflect the committed changes. Closed by commit rG92d7254a989d: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D157992: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The usag

[Lldb-commits] [PATCH] D157636: [lldb][test] Remove tests relying on deprecated std::char_traits specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rG487ab39a5082: [lldb][test] Remove tests relying on deprecated std::char_traits specializations (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D157636: [lldb][test] Remove tests relying on deprecated std::char_traits specializations

Michael137 created this revision. Michael137 added reviewers: gribozavr2, JDevlieghere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. (motivated by test failures after D157058

[Lldb-commits] [PATCH] D157512: [lldb][PlatformDarwin] Only parse SDK from debug-info if target language is Objective-C

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: kadircet. Herald added a project: All. Michael137 requested review of this revision. Herald added subscribers: lldb-commits, ilya-biryukov. Herald added a project: LLDB. The call to `HostInfoMacOSX::

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4572967 , @Endill wrote: > In D156774#4572947 , @Michael137 > wrote: > >> Are you still planning on moving this forward? Otherwise I could commandeer >> the revision to get

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. Are you still planning on moving this forward? Otherwise I could commandeer the revision to get this in. I do think it's a useful bug to address Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

Michael137 added a comment. Hi, this is failing on swift-ci (runs on x86 bots) with the following error: /Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/build/Ninja-ReleaseAssert+stdlib-Release/lldb-macosx-x86_64/unittests/ObjectFile/PECOFF/./ObjectFilePECOFFTests --gtest_f

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Endill wrote: > Michael137 wrote: > > Michael137 wrote: > > > Michael137 wrote: > > > > Michael137 wrote: >

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Michael137 wrote: > Michael137 wrote: > > Michael137 wrote: > > > At first glance this seems OK but I'll wa

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added a comment. Could you update the commit message with a description of the failure and summary of the fix? And change the title to something like `[lldb][DWARFASTParserClang] Resolve nested types when parsing structures` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Michael137 wrote: > Michael137 wrote: > > At first glance this seems OK but I'll want to check why the type

[Lldb-commits] [PATCH] D156827: [lldb][test] Skip *-dbg-info-content API tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ce7831b4023: [lldb][test] Skip *-dbg-info-content API tests (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156827/new/ https://rev

[Lldb-commits] [PATCH] D156822: [lldb] Make IR interpretation interruptible

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156822/new/ https://reviews.llvm.org/D156822 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D156827: [lldb][test] Skip *-dbg-info-content API tests

Michael137 updated this revision to Diff 546226. Michael137 added a comment. - Amend commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156827/new/ https://reviews.llvm.org/D156827 Files: lldb/test/API/commands/expression/import-std-m

[Lldb-commits] [PATCH] D156827: [lldb][test] Skip *-dbg-info-content API tests

Michael137 created this revision. Michael137 added reviewers: aprantl, iana, JDevlieghere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests started failing on the public build-bots recently

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Michael137 wrote: > At first glance this seems OK but I'll want to check why the type doesn't get > resolv

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added a comment. Thanks for addressing this. Can you add a test? Possibly in `lldb/test/API/lang/cpp/enum_types/`. Or `lldb/test/API/lang/cpp/const_static_integral_member/` Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW

[Lldb-commits] [PATCH] D156606: [lldb] Improve memory usage by freeing CTF types (NFC)

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156606/new/ https://reviews.llvm.org/D156606 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

Michael137 added a comment. Generally LGTM, just some clarifications questions Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:508 ctf_record.name.data(), tag_kind, eLanguageTypeC); + m_compiler_types[record_type.GetOpaqueQualTy

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:108 + uint32_t size, std::vector values) + : CTFType(eEnum, uid, name), nelems(nelems), size(size) { +assert(values.size() == nelems); JDevlieghere wrote

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:108 + uint32_t size, std::vector values) + : CTFType(eEnum, uid, name), nelems(nelems), size(size) { +assert(values.size() == nelems); did you omit this

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0b2b6bab4d2: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 544378. Michael137 added a comment. - EXPECT -> ASSERT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 544376. Michael137 added a comment. - Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp ll

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 544350. Michael137 added a comment. - Parameterize tests - Return bool to indicate SDK mismatch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/sourc

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543967. Michael137 marked an inline comment as not done. Michael137 added a comment. - Update unit-tests - Expand function docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 marked 2 inline comments as not done. Michael137 added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:479 +/// to an internal SDK +bool found_internal_sdk = false; + Michael137 wrote: > aprantl wrote: > > These flags really on

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1363 + XcodeSDK sdk; + for (unsigned i = 0; i < sym_file->GetNumCompileUnits(); ++i) +if (auto cu_sp = sym_file->GetCompileUnitAtIndex(i)) Only remaining qu

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543875. Michael137 added a comment. - Remove more headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarw

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543874. Michael137 added a comment. - Remove redundant header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/Platform

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543870. Michael137 added a comment. - Move into `PlatformDarwin` - Return `XcodeSDK` from `GetSDKPathFromDebugInfo` so it's easier to re-use from Swift plugin - Introduce `ResolveSDKPathFromDebugInfo` to be used from `PlatformDarwin` - Adjust tests Repos

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:479 +/// to an internal SDK +bool found_internal_sdk = false; + aprantl wrote: > These flags really only make sense in the context of an XcodeSDK, so why not > just return

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:492 + static llvm::Expected + GetSDKPathFromDebugInfo(Module &module); + Michael137 wrote: > I'm open to suggestions on where to put this API. `Platform` seems a bit too > generi

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543160. Michael137 added a comment. - Remove redundant headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/include/lldb/Target/Platform.h lldb/

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/include/lldb/Target/Platform.h:492 + static llvm::Expected + GetSDKPathFromDebugInfo(Module &module); + I'm open to suggestions on where to put this API. `Platform` seem

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When we build the Clang module compilation command (e.g., when a user requests i

[Lldb-commits] [PATCH] D154730: [lldb] Consider TAG_imported_declaration in DebugNamesIndex

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154730/new/ https://reviews.llvm.org/D154730 __

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

Michael137 added a comment. This is now failing with: clang: warning: argument unused during compilation: '-fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/module-cache-clang/lldb-shell' [-Wunused-command-line-argument] Undefined symbols

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

Michael137 added a comment. Looks like this is failing on the Darwin x86_64 buildbots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56510/execution/node/74/log/ Exit Code: 1 Command Output (stderr): -- clang: warning: argument unused during compilation: '-fmodules-cache-

[Lldb-commits] [PATCH] D152806: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test

This revision was automatically updated to reflect the committed changes. Closed by commit rGfae704bad900: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152806/new/ http

[Lldb-commits] [PATCH] D152806: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This was un-XFAILed in `83cb2123be487302070562c45e6eb4955b22c2b4` due to D144999 . S

[Lldb-commits] [PATCH] D152454: [lldb][test] LogTest: Fix stack overflow

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4c67a682f9: [lldb][test] LogTest: Fix stack overflow (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152454/new/ https://reviews.l

[Lldb-commits] [PATCH] D152454: [lldb][test] LogTest: Fix stack overflow

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The expected function name requires 18 bytes of storage. Caught by the public ASAN buildbot Repository: rG LLVM G

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/source/Core/ValueObjectSyntheticFilter.cpp:338 if (!did_find && m_synth_filter_up != nullptr) { uint32_t index = m_synth_filter_up->GetI

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/include/lldb/Core/ValueObject.h:483 // this will always create the children if necessary - lldb::ValueObjectSP GetChildAtNamePath(llvm::Arra

[Lldb-commits] [PATCH] D151748: [lldb] Consult summary provider before printing children of root references

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151748/new/ https://reviews.llvm.org/D151748

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

Michael137 added a comment. modulo Felipe's comment, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151603/new/ https://reviews.llvm.org/D151603 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

Michael137 added a subscriber: compnerd. Michael137 added a comment. Any chance someone with a working aarch64 windows 10 setup could take a look? (@compnerd ?) Or let me know how I might be able to set this up. The place where we seem to crash in `TestVarPath.py` is: # Make sure we don't cra

[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

Michael137 closed this revision. Michael137 added a comment. Committed in https://reviews.llvm.org/rG44bb442fd5be CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151268/new/ https://reviews.llvm.org/D151268 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

Michael137 updated this revision to Diff 525110. Michael137 added a comment. Fix expected string in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151268/new/ https://reviews.llvm.org/D151268 Files: lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp lldb/test/API/functionali

[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This mimicks the implementation of the libstdcpp std::unique_ptr formatter. This has been attempted several years ago

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG55acb70b211a: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

Michael137 updated this revision to Diff 523804. Michael137 added a comment. - Move variable into `LLDBStandalone.cmake` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150954/new/ https://reviews.llvm.org/D150954 Files: lldb/cmake/modules/LLDBSta

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

Michael137 added a comment. Outstanding question would be whether we want to mirror this change in `utils/lldb-dotest/CMakeLists.txt`. If so, we should probably extract all this libcxx logic into a common helper between the two. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

Michael137 created this revision. Michael137 added reviewers: aprantl, bulbazord, JDevlieghere. Herald added a subscriber: ekilmer. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Standalone builds cu

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

Michael137 added a comment. In D150772#4349592 , @tbaeder wrote: > Can you tell me what I have to do so `ninja check-lldb-api` actually runs the > test? All 1114 tests are currently marked "unsupported" for me. Did you configure LLDB with `-DLLDB_ENABLE

[Lldb-commits] [PATCH] D150591: [lldb][DWARFASTParserClang] Don't create unnamed bitfields to account for vtable pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c30f224005e: [lldb][DWARFASTParserClang] Don't create unnamed bitfields to account for… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D150589: [lldb][DWARFASTParserClang][NFC] Simplify unnamed bitfield condition

This revision was automatically updated to reflect the committed changes. Closed by commit rGca64f9af0447: [lldb][DWARFASTParserClang][NFC] Simplify unnamed bitfield condition (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D150590: [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield creation into helper function

This revision was automatically updated to reflect the committed changes. Closed by commit rG56eff197d0d6: [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D150591: [lldb][DWARFASTParserClang] Don't create unnamed bitfields to account for vtable pointer

Michael137 updated this revision to Diff 522383. Michael137 added a comment. - Rephrase comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150591/new/ https://reviews.llvm.org/D150591 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser

[Lldb-commits] [PATCH] D150590: [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield creation into helper function

Michael137 updated this revision to Diff 522382. Michael137 added a comment. - Add doxygen comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150590/new/ https://reviews.llvm.org/D150590 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTPar

[Lldb-commits] [PATCH] D150591: [lldb][DWARFASTParserClang] Don't create unnamed bitfields to account for vtable pointer

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** When filling out the LayoutInfo fo

[Lldb-commits] [PATCH] D150590: [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield creation into helper function

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new private helper `DWARFASTP

[Lldb-commits] [PATCH] D150589: [lldb][DWARFASTParserClang][NFC] Simplify unnamed bitfield condition

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Minor cleanup of redundant variable initializat

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

Michael137 added a comment. In D149949#4341608 , @labath wrote: > Just as a drive-by, since we're constructing a copy anyway it would be > possible to merge this construction with the "uniqueing" behavior of the > `visited` set. I.e., instead of making

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

Michael137 added a comment. In D149949#431 , @aprantl wrote: > Do we have other ForEach methods that contain a similar footgun? Not that I can tell Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149949/

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

This revision was automatically updated to reflect the committed changes. Closed by commit rGe74f03dde5d8: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

Michael137 updated this revision to Diff 519803. Michael137 added a comment. Herald added a subscriber: JDevlieghere. - Add back change dropped in cherry-pick Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149949/new/ https://reviews.llvm.org/D14994

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `TypeSystemMap::m_mutex` guards against concurrent modifications of

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 added a comment. Thanks for fixing Just checked and it works on my M1 with assertions. I relanded the latest version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 _

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 added a comment. I tried the new test case on my Mac but it's now hitting an assertion: TEST 'lldb-shell :: SymbolFile/DWARF/x86/DW_OP_div-with-signed.s' FAILED Script: -- : 'RUN: at line 2'; /Users/michaelbuch/Git/lldb-build-main-n

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 added a comment. Reverted for now until we find fix for test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 added a comment. In D147370#4313196 , @asl wrote: > This seems to fail on ARM: > https://lab.llvm.org/buildbot/#/builders/17/builds/37130 Investigating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe15d6b520e1e: [lldb][DWARFExpression] Fix DW_OP_div to use signed division (authored by jwnhy, committed by Michael137). Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 added a comment. @jwnhy Let me know which name and email I should attribute the patch to CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D149394: Finish the job of D145569

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149394/new/ https://reviews.llvm.org/D149394 __

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_div-with-signed.s:3 + + # RUN: %clang --target=x86_64-pc-linux -o %t %s + # RUN: %lldb %t -o "b f" -o "r

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. In D143347#4298613 , @kpdev42 wrote: > So what are next steps? Are we going for implementation of > `DW_AT_no_unique_address` (which is going to be a non-standard extension) ? > @dblaikie @aprantl @Michael137 in my opinion t

[Lldb-commits] [PATCH] D148531: [lldb][DataFormatter] Fix libcxx std::deque formatter for references and pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG1414a5bdfeff: [lldb][DataFormatter] Fix libcxx std::deque formatter for references and… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D148531: [lldb][DataFormatter] Fix libcxx std::deque formatter for references and pointers

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. (Addresses GH#62153) The `SBType` APIs to retrieve details about templa

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cdfa2957437: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

This revision was automatically updated to reflect the committed changes. Closed by commit rG0301a492f43e: [lldb][Language] Add more language types (authored by Michael137). Changed prior to commit: https://reviews.llvm.org/D143061?vs=493896&id=513622#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 updated this revision to Diff 513621. Michael137 added a comment. - Add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143062/new/ https://reviews.llvm.org/D143062 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExpression

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:548 +[[fallthrough]]; case lldb::eLanguageTypeC_plus_plus: case lldb::eLanguageTypeC_plus_plus_11: aprantl wrote: > Why no case C++17? Fa

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:551 case lldb::eLanguageTypeC_plus_plus_14: lang_opts.CPlusPlus11 = true; m_compiler->getHeaderSearchO

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 updated this revision to Diff 513547. Michael137 added a comment. - Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147436/new/ https://reviews.llvm.org/D147436 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/include/lldb/S

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 updated this revision to Diff 513542. Michael137 added a comment. - Make condition more readable - Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147436/new/ https://reviews.llvm.org/D147436 Files: lldb/include/lldb/Symbol/Sym

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 updated this revision to Diff 513539. Michael137 added a comment. - Move doxygen comment - Add source comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147436/new/ https://reviews.llvm.org/D147436 Files: lldb/include/lldb/Symbol/S

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 updated this revision to Diff 513531. Michael137 added a comment. - Only search for root namespace if we're doing a qualified lookup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147436/new/ https://reviews.llvm.org/D147436 Files: lld

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true; Generally

  1   2   3   4   5   6   >