Michael137 added a comment. In D156774#4644503 <https://reviews.llvm.org/D156774#4644503>, @Endill wrote:
> Ping @Michael137 Sorry for the delay, just came back from vacation The change itself LGTM. Can we add a test though? We do have DWARFASTParserClang unittests: https://github.com/llvm/llvm-project/blob/main/lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp If the yaml input file becomes tedious to write you could also just an API test. E.g., under https://github.com/llvm/llvm-project/tree/main/lldb/test/API/lang/cpp Let me know if you need some pointers in writing the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.org/D156774 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
