Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: lldb/include/lldb/Core/ValueObject.h:483 // this will always create the children if necessary - lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef<ConstString> names, - ConstString *name_of_error = nullptr); + lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef<llvm::StringRef> names); ---------------- Guessing removing the parameter is fine because no callers were actually passing it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151813/new/ https://reviews.llvm.org/D151813 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
