Michael137 added inline comments.
================ Comment at: lldb/include/lldb/Target/Platform.h:479 + /// to an internal SDK + bool found_internal_sdk = false; + ---------------- aprantl wrote: > These flags really only make sense in the context of an XcodeSDK, so why not > just return an XcodeSDK or XcodeSDK::Info object here? Otherwise we'll > probably introduce subtle bugs due to a lossy translation between the flags. Yup I think that'd be better. That'll also make it easier to use from the Swift plugin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
