[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added a comment. In D114627#3162109 , @shafik wrote: > Is there a specific use case that motivated this feature? The motivation is performance. If there are many (>1000) types with the same base name this implementation performs much better

[Lldb-commits] [lldb] 92a8dc0 - [lldb] Temporarily skip TestTsanBasic on Darwin

Author: Jonas Devlieghere Date: 2021-11-30T20:11:26-08:00 New Revision: 92a8dc0735cfb3f296f0c487b20d8fa8474e3e40 URL: https://github.com/llvm/llvm-project/commit/92a8dc0735cfb3f296f0c487b20d8fa8474e3e40 DIFF: https://github.com/llvm/llvm-project/commit/92a8dc0735cfb3f296f0c487b20d8fa8474e3e40.d

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

shafik added a comment. I recently ran into this, thanks for fixing the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114819/new/ https://reviews.llvm.org/D114819 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 390847. zequanwu added a comment. use lower case for parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Files: lldb/source/Plugins/SymbolFile/NativePDB/Pd

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 390845. zequanwu added a comment. Handle OverloadedMethodRecord. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Files: lldb/source/Plugins/SymbolFile/NativePDB/Pd

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

shafik added a comment. I also echo Pavel's question, why not in `DWARFASTParser`? Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1140 : containing_decl_ctx, -GetOwningClangModule(die), name, clang_typ

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:77 + default: + case DW_AT_abstract_origin: + case DW_AT_accessibility: shafik wrote: > ljmf00 wrote: > > bulbazord wrote: > > > ljmf00

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e6df41f655e: [NFC] Refactor symbol table parsing. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.or

[Lldb-commits] [lldb] 7e6df41 - [NFC] Refactor symbol table parsing.

Author: Greg Clayton Date: 2021-11-30T13:54:32-08:00 New Revision: 7e6df41f655e51c984b92bbd9c19a6fb851f35d4 URL: https://github.com/llvm/llvm-project/commit/7e6df41f655e51c984b92bbd9c19a6fb851f35d4 DIFF: https://github.com/llvm/llvm-project/commit/7e6df41f655e51c984b92bbd9c19a6fb851f35d4.diff

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

JDevlieghere added inline comments. Comment at: lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py:22 self.build() - lldbutil.run_to_breakpoint_make_target(self) The name of this helper method is terribly confusing. I had to look at the source

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. JDevlieghere requested review of this revision. Split TestCxxChar8_t into two parts: one that check reading variables without a process and another part with. This allows us to skip the former on Apple Silicon, wh

[Lldb-commits] [lldb] d1326a3 - [lldb] Fix broken skipUnlessUndefinedBehaviorSanitizer decorator

Author: Jonas Devlieghere Date: 2021-11-30T13:03:33-08:00 New Revision: d1326a3b10054dd89be46f51f857d009cf8ae14f URL: https://github.com/llvm/llvm-project/commit/d1326a3b10054dd89be46f51f857d009cf8ae14f DIFF: https://github.com/llvm/llvm-project/commit/d1326a3b10054dd89be46f51f857d009cf8ae14f.d

[Lldb-commits] [lldb] 5f2e8f5 - [lldb] Mark TestTsanBasic and TestUbsanBasic as "no debug info" tests

Author: Jonas Devlieghere Date: 2021-11-30T12:40:50-08:00 New Revision: 5f2e8f579697492fab572796f99bc713f349e6fe URL: https://github.com/llvm/llvm-project/commit/5f2e8f579697492fab572796f99bc713f349e6fe DIFF: https://github.com/llvm/llvm-project/commit/5f2e8f579697492fab572796f99bc713f349e6fe.d

[Lldb-commits] [lldb] c471359 - [lldb] Fix TypeError: argument of type 'NoneType' is not iterable

Author: Jonas Devlieghere Date: 2021-11-30T12:41:45-08:00 New Revision: c47135949779904542ee1e6d5486609ebf0da1b5 URL: https://github.com/llvm/llvm-project/commit/c47135949779904542ee1e6d5486609ebf0da1b5 DIFF: https://github.com/llvm/llvm-project/commit/c47135949779904542ee1e6d5486609ebf0da1b5.d

[Lldb-commits] [PATCH] D114742: [lldb] Search PrivateFrameworks when using an internal SDK

kastiglione added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:86 +private_frameworks = os.path.join(sdk_root, 'System','Library','PrivateFrameworks') +args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_frame

[Lldb-commits] [PATCH] D114742: [lldb] Search PrivateFrameworks when using an internal SDK

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a302f666737: [lldb] Search PrivateFrameworks when using an internal SDK (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D114742?vs=390473&id=390763#toc Repository: rG L

[Lldb-commits] [lldb] 0a302f6 - [lldb] Search PrivateFrameworks when using an internal SDK

Author: Jonas Devlieghere Date: 2021-11-30T11:28:19-08:00 New Revision: 0a302f66673720a0d3fd3f0ce32ec9cfda428cf1 URL: https://github.com/llvm/llvm-project/commit/0a302f66673720a0d3fd3f0ce32ec9cfda428cf1 DIFF: https://github.com/llvm/llvm-project/commit/0a302f66673720a0d3fd3f0ce32ec9cfda428cf1.d

[Lldb-commits] [lldb] 4fa9e43 - [lldb] Fix indentation in builders/darwin.py

Author: Jonas Devlieghere Date: 2021-11-30T11:28:52-08:00 New Revision: 4fa9e435209e6067b9d5921647429053ae7a8e0c URL: https://github.com/llvm/llvm-project/commit/4fa9e435209e6067b9d5921647429053ae7a8e0c DIFF: https://github.com/llvm/llvm-project/commit/4fa9e435209e6067b9d5921647429053ae7a8e0c.d

[Lldb-commits] [PATCH] D114742: [lldb] Search PrivateFrameworks when using an internal SDK

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:86 +private_frameworks = os.path.join(sdk_root, 'System','Library','PrivateFrameworks') +args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_fram

[Lldb-commits] [PATCH] D114742: [lldb] Search PrivateFrameworks when using an internal SDK

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:86 +private_frameworks = os.path.join(sdk_root, 'System','Library','PrivateFramework

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

shafik added a comment. Is there a specific use case that motivated this feature? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 planned changes to this revision. ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:86 + /// Whether it is an artificially generated symbol. + eDWARFAttributeIsArtificial = (1u << 0), + eDWARFAttributeIsExplicit = (1u << 1),

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

shafik added a subscriber: clayborg. shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:77 + default: + case DW_AT_abstract_origin: + case DW_AT_accessibility: ljmf00 wrote: > bulbazord wro

[Lldb-commits] [PATCH] D114719: [lldb][NFC] Move non-clang specific method to the generic DWARF Parser

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114719/new/ https://reviews.llvm.org/D114719 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D114796: [lldb/qemu] Add support for pty redirection

labath updated this revision to Diff 390722. labath added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114796/new/ https://reviews.llvm.org/D114796 Files: lldb/source/Host/common/ProcessLaunchInfo.cpp lldb/source/Plugins/P

[Lldb-commits] [PATCH] D114796: [lldb/qemu] Add support for pty redirection

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Target/Target.cpp:3324 - if (default_to_use_pty && - (!in_file_spec || !out_file_spec || !err_file_spec)) { + if (default_to_use_pty) { llvm::Error Err = i

[Lldb-commits] [PATCH] D114796: [lldb/qemu] Add support for pty redirection

DavidSpickett added inline comments. Comment at: lldb/source/Target/Target.cpp:3324 - if (default_to_use_pty && - (!in_file_spec || !out_file_spec || !err_file_spec)) { + if (default_to_use_pty) { llvm::Error Err = info.SetUpPtyRedirection(); ---

[Lldb-commits] [PATCH] D114796: [lldb/qemu] Add support for pty redirection

labath created this revision. labath added reviewers: mgorny, DavidSpickett, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. Lldb uses a pty to read/write to the standard input and output of the debugged process. For host processes this would be automatically

[Lldb-commits] [PATCH] D114791: [lldb] Clarify StructuredDataImpl ownership

labath added inline comments. Comment at: lldb/source/API/SBThreadPlan.cpp:72-73 if (thread) -m_opaque_wp = -std::make_shared(*thread, class_name, nullptr); +m_opaque_wp = std::make_shared(*thread, class_name, +

[Lldb-commits] [PATCH] D114791: [lldb] Clarify StructuredDataImpl ownership

labath created this revision. labath added reviewers: JDevlieghere, mib, jingham. Herald added a subscriber: yaxunl. labath requested review of this revision. Herald added a project: LLDB. StructuredDataImpl ownership semantics is unclear at best. Various structures were holding a non-owning point

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

This revision was automatically updated to reflect the committed changes. Closed by commit rG1408684957bb: [lldb] Introduce PlatformQemuUser (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D11

[Lldb-commits] [lldb] 1408684 - [lldb] Introduce PlatformQemuUser

Author: Pavel Labath Date: 2021-11-30T14:16:08+01:00 New Revision: 1408684957bbfb5b412e0ef3c027c88daa1058eb URL: https://github.com/llvm/llvm-project/commit/1408684957bbfb5b412e0ef3c027c88daa1058eb DIFF: https://github.com/llvm/llvm-project/commit/1408684957bbfb5b412e0ef3c027c88daa1058eb.diff

[Lldb-commits] [lldb] a6e6736 - [lldb] Inline Platform::LoadCachedExecutable into its (single) caller

Author: Pavel Labath Date: 2021-11-30T14:15:49+01:00 New Revision: a6e673643c44f94557fa09022a3c6edf76167871 URL: https://github.com/llvm/llvm-project/commit/a6e673643c44f94557fa09022a3c6edf76167871 DIFF: https://github.com/llvm/llvm-project/commit/a6e673643c44f94557fa09022a3c6edf76167871.diff

[Lldb-commits] [PATCH] D114675: [lldb] [Target] Support fallback to file address in ReadMemory()

labath added a comment. In D114675#3160513 , @mgorny wrote: > Well, that's what happens with the core file I have and what you're asking > for is really above my paygrade. Maybe you should ask for a raise then. :P > That said, this is kernel core dump,

[Lldb-commits] [PATCH] D114369: [lldb] Remove 'extern "C"' from the lldb-swig-python interface

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a14adeae000: [lldb] Remove 'extern "C"' from the lldb-swig-python interface (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114369/new/

[Lldb-commits] [lldb] 9a14ade - [lldb] Remove 'extern "C"' from the lldb-swig-python interface

Author: Pavel Labath Date: 2021-11-30T11:06:09+01:00 New Revision: 9a14adeae00015798843ff5cad987e5fdbdddb34 URL: https://github.com/llvm/llvm-project/commit/9a14adeae00015798843ff5cad987e5fdbdddb34 DIFF: https://github.com/llvm/llvm-project/commit/9a14adeae00015798843ff5cad987e5fdbdddb34.diff

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

labath added a comment. I don't think we should be putting this into the DWARFAttribute file. It is substantially higher-level than the rest of the file, and the DWARFAttribute file is destined to be merged with the llvm implementation at some point. Is there a reason for not putting it into `D

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

labath added a comment. What is the reason for these differences? The test in question appears to be fairly hermetic (in-tree compiler and linker), so it sounds like something is going wrong inside lldb... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.