kastiglione added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:86
+ private_frameworks = os.path.join(sdk_root,
'System','Library','PrivateFrameworks')
+ args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_frameworks)
+
----------------
JDevlieghere wrote:
> aprantl wrote:
> > Just curious: why not
> > ```
> > args['FRAMEWORK_INCLUDES'] = '-F' + private_frameworks
> > ```
> > ?
> Mostly for consistency with the rest of the file, but also personal
> preference. It's no coincidence that the rest of the file uses `format` too.
> I like f-strings even more, but they're Python 3.something only.
Maybe we can use format strings now? LLVM requires python >= 3.6, does that
mean lldb does too? https://llvm.org/docs/GettingStarted.html#software
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114742/new/
https://reviews.llvm.org/D114742
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
