labath marked an inline comment as done.
labath added inline comments.
================
Comment at: lldb/source/Target/Target.cpp:3324
- if (default_to_use_pty &&
- (!in_file_spec || !out_file_spec || !err_file_spec)) {
+ if (default_to_use_pty) {
llvm::Error Err = info.SetUpPtyRedirection();
----------------
DavidSpickett wrote:
> What's the logic to this change? I thought maybe the `!in_file_spec...` were
> redundant but not 100% sure.
The original code was trying to avoid calling this function in case all three
actions were set. It was almost redundant, as `SetUpPtyRedirection` had the
same checks already -- the only difference was that the function would
unconditionally create the pty master (and then not use it). So I've added an
early exit to that function and that way I could avoid doing the same checks in
the new platform.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114796/new/
https://reviews.llvm.org/D114796
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
