aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:86
+                private_frameworks = os.path.join(sdk_root, 
'System','Library','PrivateFrameworks')
+                args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_frameworks)
+
----------------
Just curious: why not 
```
 args['FRAMEWORK_INCLUDES'] = '-F' + private_frameworks
```
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114742/new/

https://reviews.llvm.org/D114742

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to