shafik added a comment.
I also echo Pavel's question, why not in `DWARFASTParser`?
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1140
: containing_decl_ctx,
- GetOwningClangModule(die), name, clang_type, attrs.storage,
- attrs.is_inline);
+ GetOwningClangModule(die), name, clang_type, attrs.is_external() ?
clang::SC_Extern : clang::SC_None,
+ attrs.is_inline());
----------------
Is there a reason not to use an attribute `storage` like before? This feels
like we are leaking out of the abstraction where before we were not.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1493
// and the byte size is zero.
- attrs.is_forward_declaration = true;
+ attrs.attr_flags |= eDWARFAttributeIsForwardDecl;
}
----------------
if we are going to have getter abstraction why not have a
`setIsForwardDeclaration()` or something similar.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114746/new/
https://reviews.llvm.org/D114746
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
