[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372690: Ignore generated @import statements in the expression evaluator (authored by teemperor, committed by ). Herald add

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

labath added reviewers: amccarth, ted. labath added a comment. This is looking very good to me. Adding some windows folks to help with trying this out on that platform. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative

[Lldb-commits] [lldb] r372690 - Ignore generated @import statements in the expression evaluator

Author: teemperor Date: Mon Sep 23 23:58:39 2019 New Revision: 372690 URL: http://llvm.org/viewvc/llvm-project?rev=372690&view=rev Log: Ignore generated @import statements in the expression evaluator Summary: The ClangModulesDeclVendor is currently interpreting all injected `@import` statements

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

labath added a comment. Since this (unlike most of your other patches in this series) is definitely adding new functionality, it would be good to accompany it with a test. The simplest way to do that should be via something like `yaml2obj && lldb-test object-file | FileCheck`. I'd recommend loo

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39 #endif +#ifndef S_IRGRP #define S_IRGRP 0 /* read, group */ hhb wrote: > Maybe move these into the defined(_MSC_VER) above? Or th

[Lldb-commits] [PATCH] D67943: documentation: update test.rst

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/docs/resources/test.rst:126 + + > ./bin/llvm-lit -sv tools/lldb/lit/Commands/CommandScriptImmediateOutput + Another altern

[Lldb-commits] [PATCH] D67943: documentation: update test.rst

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. The testing documentation appears to be from an era when the only kind of tests were the lldbsuite python tests. This patch adds a short description of the unit

[Lldb-commits] [PATCH] D67942: Install python dll to bin

hhb created this revision. hhb added a reviewer: mstorsjo. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Not sure whether this is a feature or bug... Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67942 Files: lldb/CMakeLists.txt Index: lldb

[Lldb-commits] [lldb] r372677 - Adapt test to upstream clang compiler changes.

Author: adrian Date: Mon Sep 23 17:27:13 2019 New Revision: 372677 URL: http://llvm.org/viewvc/llvm-project?rev=372677&view=rev Log: Adapt test to upstream clang compiler changes. Clang now emits the correct C++ language version in DWARF. Modified: lldb/trunk/packages/Python/lldbsuite/test/

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. @labath How's it look now? I made FileSystem::Open return a unique_ptr, and only convert that over to a shared_ptr where necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 221431. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. converted many uses of shared_ptr into unique_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ http

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

hhb accepted this revision. hhb added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39 #endif +#ifndef S_IRGRP #define S_IRGRP 0 /* read, group */ Maybe move these into the defined(_MSC_V

[Lldb-commits] [lldb] r372669 - [Make] Add support for building NeXT-style frameworks

Author: jdevlieghere Date: Mon Sep 23 15:31:16 2019 New Revision: 372669 URL: http://llvm.org/viewvc/llvm-project?rev=372669&view=rev Log: [Make] Add support for building NeXT-style frameworks This patch extends the Makefile.rules to build NeXT-style frameworks. It also fixes a bug in the clean l

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

hhb added inline comments. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative_path +if module_path is None: +from distutils.sysconfig import get_python_lib hhb wrote: > Just bail out in

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

jingham added a comment. Pavel's example shows why these two choices might be better separated. If you are using __builtin_trap to implement a stop when in the debugger of some sort, it seems likely you would want to suppress the signal, but it also seems likely that when you are running in b

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

hhb added inline comments. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative_path +if module_path is None: +from distutils.sysconfig import get_python_lib Just bail out in this situati

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

rjmccall added inline comments. Comment at: clang/include/clang/Basic/Attr.td:734 +// TODO: Make it possible to specify this in source. +BoolArgument<"LiteralLabel"> + ]; `LiteralLabel` is an unfortunate name for this property because `getLiteralLabel`

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo updated this revision to Diff 221406. mstorsjo added a comment. Added a log message, changed an `x86_64` ifdef into `_WIN64`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67911/new/ https://reviews.llvm.org/D67911 Files: lldb/source/Plugins/Process/Windows/Common/RegisterCo

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo added a comment. In D67911#1679696 , @compnerd wrote: > I think that `printf` is quite an amazing notification :-) Ok, I'll make it an `LLDB_LOG` then, as I'd presume using raw printfs isn't really allowed :-) Repository: rLLDB LLDB CHANGE

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

This revision was automatically updated to reflect the committed changes. Closed by commit rL372656: [LLDB] Rework a MinGW build fix from D65691 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

This revision was automatically updated to reflect the committed changes. Closed by commit rL372657: [LLDB] [PECOFF] Recognize arm64 executables (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D67913: [LLDB] [Windows] Map COFF ARM machine ids to the right triplet architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rL372658: [LLDB] [Windows] Map COFF ARM machine ids to the right triple architectures (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[Lldb-commits] [lldb] r372658 - [LLDB] [Windows] Map COFF ARM machine ids to the right triple architectures

Author: mstorsjo Date: Mon Sep 23 13:43:22 2019 New Revision: 372658 URL: http://llvm.org/viewvc/llvm-project?rev=372658&view=rev Log: [LLDB] [Windows] Map COFF ARM machine ids to the right triple architectures Differential Revision: https://reviews.llvm.org/D67913 Modified: lldb/trunk/sourc

[Lldb-commits] [lldb] r372656 - [LLDB] Rework a MinGW build fix from D65691

Author: mstorsjo Date: Mon Sep 23 13:43:11 2019 New Revision: 372656 URL: http://llvm.org/viewvc/llvm-project?rev=372656&view=rev Log: [LLDB] Rework a MinGW build fix from D65691 That change didn't contain any explanation for this bit. There shouldn't be any need for a check for MinGW ifdefs here

[Lldb-commits] [lldb] r372657 - [LLDB] [PECOFF] Recognize arm64 executables

Author: mstorsjo Date: Mon Sep 23 13:43:16 2019 New Revision: 372657 URL: http://llvm.org/viewvc/llvm-project?rev=372657&view=rev Log: [LLDB] [PECOFF] Recognize arm64 executables Differential Revision: https://reviews.llvm.org/D67912 Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/Obje

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

This revision was automatically updated to reflect the committed changes. Closed by commit rL372652: File::SetDescriptor() should require options (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

compnerd added a comment. I think that `printf` is quite an amazing notification :-) Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:87 case 4: #if defined(__x86_64__) || defined(_M_AMD64) case 8: mstorsjo wrote: > comp

[Lldb-commits] [lldb] r372652 - File::SetDescriptor() should require options

Author: jdevlieghere Date: Mon Sep 23 13:36:46 2019 New Revision: 372652 URL: http://llvm.org/viewvc/llvm-project?rev=372652&view=rev Log: File::SetDescriptor() should require options lvm_private::File::GetStream() can fail if m_options == 0 It's not clear from the header a File created with a d

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

vsk updated this revision to Diff 221391. vsk marked 3 inline comments as done. vsk added a comment. - Address latest review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

jingham added a comment. First off, note that this becomes complicated because this patch tied the decision of whether a given stop reason should warrant returning control to the user in lldb's "batch mode", and whether the signal should be passed back to the target. That isn't a necessary bin

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

lawrence_danna updated this revision to Diff 221390. lawrence_danna added a comment. added unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67792/new/ https://reviews.llvm.org/D67792 Files: lldb/include/lldb/Host/File.h lldb/source/Core

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

mgorny updated this revision to Diff 221388. mgorny retitled this revision from "[lldb] [cmake] Fix installing Python modules on systems using /usr/lib" to "[lldb] [cmake] Unify and correct Python module installation paths". mgorny edited the summary of this revision. mgorny added a comment. O-k

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

This revision was automatically updated to reflect the committed changes. Closed by commit rL372644: [Host] File::GetWaitableHandle() should call fileno() (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [lldb] r372644 - [Host] File::GetWaitableHandle() should call fileno()

Author: jdevlieghere Date: Mon Sep 23 12:34:26 2019 New Revision: 372644 URL: http://llvm.org/viewvc/llvm-project?rev=372644&view=rev Log: [Host] File::GetWaitableHandle() should call fileno() If the file has m_stream, it may not have a m_descriptor. GetWaitableHandle() should call GetDescriptor(

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna updated this revision to Diff 221383. lawrence_danna added a comment. nits fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67789/new/ https://reviews.llvm.org/D67789 Files: lldb/source/Host/common/File.cpp lldb/unittests/Hos

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. nits fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67789/new/ https://reviews.llvm.org/D67789 ___ lldb-commits mai

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. In D67891#1678933 , @labath wrote: > The first option would require making the File class movable I don't think making File movable will work. I'll be wanting a PythonFile subclass, which overrides virtual metho

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo marked an inline comment as done. mstorsjo added a comment. In D67911#1679333 , @compnerd wrote: > What do you think of adding some sort of notification that hardware > breakpoints are currently unsupported and that we are falling back to > soft

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL372642: [ABISysV] Fix regression for Simulator and MacABI (authored by JDevlieghere, committed by ). Herald added subscribers: llvm-commits, fedor.sergeev. Herald added a project: LLVM. Changed prior to c

[Lldb-commits] [lldb] r372642 - [ABISysV] Fix regression for Simulator and MacABI

Author: jdevlieghere Date: Mon Sep 23 12:06:00 2019 New Revision: 372642 URL: http://llvm.org/viewvc/llvm-project?rev=372642&view=rev Log: [ABISysV] Fix regression for Simulator and MacABI The ABISysV ABI was refactored in r364216 to support the Windows ABI for x86_64. In particular it changed AB

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

hhb accepted this revision. hhb added a comment. This revision is now accepted and ready to land. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67894/new/ https://reviews.llvm.org/D67894 ___ lldb-commits ma

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote: > mgorny wrote: > > hhb wrote: > > > mgorn

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > mgorny wrote: > > > hh

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

clayborg added a comment. In D66638#1679195 , @labath wrote: > Thanks for the review and sorry for the delay (I was OOO). The idea to use > `Process::GetLoadAddressPermissions` makes sense, both from consistency and > correctness perspectives. Unfortunat

[Lldb-commits] [lldb] r372634 - [lldb-suite] TestCallOverriddenMethod.py is now passing on Windows

Author: stella.stamenova Date: Mon Sep 23 10:51:27 2019 New Revision: 372634 URL: http://llvm.org/viewvc/llvm-project?rev=372634&view=rev Log: [lldb-suite] TestCallOverriddenMethod.py is now passing on Windows The test is now passing, so remove the expected failure. No other tests associated wit

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > mgorny wrote: > > > hh

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > If we go this way, sho

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

aprantl added inline comments. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:231 + case llvm::Triple::OSType::WatchOS: +switch(os_env) { + case llvm::Triple::EnvironmentType::Simulator: clang-format? Repository: rLLD

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

aprantl added a comment. What does `x86_64-apple-darwin` canonicalize to? Do we need an extra case for that? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67869/new/ https://reviews.llvm.org/D67869 ___ lldb-commit

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny added a reviewer: ZeGentzy. mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^li

[Lldb-commits] [PATCH] D67869: [ABISysV] Fix regression for Simulator and MacABI

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:233 + case llvm::Triple::EnvironmentType::Simulator: + case llvm::Triple::Environme

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added a comment. And thanks for this and it is definitely an improvement! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67890/new/ https://reviews.llvm.org/D67890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_BINARY_DIR} +OUT

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

JDevlieghere added a comment. +1 on passing this information to the Python script. Personally I'd like to move more of that logic into CMake so we can properly track dependencies and don't have to have dummy targets that are always out of date. This would be a step in the right direction. CHA

[Lldb-commits] [PATCH] D67906: [lldb] Provide tab completion for target select/delete

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:63 const char *prefix_cstr, - bool show_stopped_process_status, Stream &strm) { + bool show_stopped_process

[Lldb-commits] [PATCH] D67903: [lldb] Add completion support for log enable/disable/list

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/Log.cpp:49 + +void Log::ListCategories(llvm::raw_ostream &stream, + const ChannelMap:

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

dblaikie added inline comments. Comment at: lldb/source/Symbol/TypeSystem.cpp:331 "TypeSystem for language " + - llvm::toStringRef(Language::GetNameForLanguageType(language)) + + llvm::StringRef(Language::GetNameForLanguageType(language)) +

[Lldb-commits] [PATCH] D67913: [LLDB] [Windows] Map COFF ARM machine ids to the right triplet architectures

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Nit: `triple`, not `triplet`. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67913/new/ https://reviews.llvm.org/D67913 ___

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:202 + case MachineArm64: +spec.SetTriple("aarch64-pc-windows"); +specs.Append(module_s

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

compnerd added a comment. What do you think of adding some sort of notification that hardware breakpoints are currently unsupported and that we are falling back to software breakpoints for the `#else` case? Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterConte

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

labath added a comment. Thanks for the review and sorry for the delay (I was OOO). The idea to use `Process::GetLoadAddressPermissions` makes sense, both from consistency and correctness perspectives. Unfortunately it does not work "out of the box" because minidump core files (my primary use ca

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. In D66398#1679071 , @labath wrote: > Good to know, but assuming that the above patch sticks, the plan *is* to > revert this, right? D66654 is already checked-in, I have considered it as d

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

labath added a comment. In D66398#1677414 , @jankratochvil wrote: > "jankratochvil added a reverting change" - that is not true, Differential got > somehow confused by the commit text there talking about this patch. Good to know, but assuming that the

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rL372608: [LLDB] Fix logically dead code (authored by kwk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67915?v

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. In D67915#1679030 , @kwk wrote: > @jankratochvil the file only has two revisions: > https://github.com/llvm/llvm-project/commits/b9c1b51e

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv

[Lldb-commits] [lldb] r372608 - [LLDB] Fix logically dead code

Author: kwk Date: Mon Sep 23 07:05:51 2019 New Revision: 372608 URL: http://llvm.org/viewvc/llvm-project?rev=372608&view=rev Log: [LLDB] Fix logically dead code Summary: The indicated dead code may have performed some action; that action will never occur. In lldb_private::LoadedModuleInfoList::

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

kwk added a comment. @jankratochvil the file only has two revisions: https://github.com/llvm/llvm-project/commits/b9c1b51e45b845debb76d8658edabca70ca56079/lldb/include/lldb/Core/LoadedModuleInfoList.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

labath added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_BINARY_DIR} +

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk added a reviewer: jankratochvil. kwk edited the summary of this revision. jankratochvil added a comment. Personally I would check GIT history for some reasons it was written this way. The indica

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

jankratochvil added a comment. FYI the link does not work for me: https://scan3.coverity.com/reports.htm#v39507/p12195/fileInstanceId=27614986&defectInstanceId=8037484&mergedDefectId=221581 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67915/new/

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

jankratochvil added a comment. Personally I would check GIT history for some reasons it was written this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67915/new/ https://reviews.llvm.org/D67915 __

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

labath added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_BINARY_DIR} +

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

labath requested changes to this revision. labath added a comment. Like I said in the other patch, I think we're stuck with having to match how the python layouts differ between operating systems (though there is definitely a lot of room for improvement in the way that it is done now). Reposit

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath added a comment. In D67793#1678259 , @lawrence_danna wrote: > @labath > > I wrote a patch for the shared_ptr approach. It's simple, but it touches a > lot of lines. > > https://reviews.llvm.org/D67891 > > Now that I've gone and done it, I kind o

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

labath added a comment. While I am fully in favour of removing the SetXXX methods, and it does seem like some amount of shared_ptrs will be needed at the (though I don't fully understand your vission yet), I don't really like this proliferation of shared_ptrs everywhere (there's way too many of

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

teemperor updated this revision to Diff 221307. teemperor added a comment. - Addressed feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67760/new/ https://reviews.llvm.org/D67760 Files: lldb/include/lldb/Symbol/CompileUnit.h lldb/include/lldb/Symbol/SymbolFile.h lldb/inclu

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

teemperor marked 6 inline comments as done. teemperor added a comment. Thanks for the quick review! Comment at: lldb/include/lldb/Symbol/CompileUnit.h:228 + /// Apply a lambda to each external module referenced by this compilation + /// unit. Recursively also descends into

[Lldb-commits] [PATCH] D67913: [LLDB] [Windows] Map COFF ARM machine ids to the right triplet architectures

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb, labath, asmith. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67913 Files: lldb/source/Host/windows/Host.cpp Index: lld

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb, labath, asmith. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67912 Files: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFi

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo created this revision. mstorsjo added reviewers: amccarth, labath, hhb, compnerd, asmith. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. While debugging on those architectures might not be supported yet, the generic code should still be buildable. This file

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

mstorsjo created this revision. mstorsjo added reviewers: hhb, amccarth, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. Since these defines were added in LLVM SVN r189364 in 2013, mingw-w64 got defines for S_I?GRP, S_IRWXG, S_I?OTH and S_IRWXO in 2015. Repo

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks much better to me, but maybe you could add some unit tests for the use cases this fixes (I guess that's the use case of creating a `File` object with an fd, and the writing(?) to it

[Lldb-commits] [PATCH] D67893: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general

This revision was automatically updated to reflect the committed changes. Closed by commit rL372592: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[Lldb-commits] [PATCH] D67896: [LLDB] Add a void* cast when passing object pointers to printf %p

This revision was automatically updated to reflect the committed changes. Closed by commit rL372590: [LLDB] Add a void* cast when passing object pointers to printf %p (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D67861: [LLDB] Remove a now redundant windows specific workaround

This revision was automatically updated to reflect the committed changes. Closed by commit rL372591: [LLDB] Remove a now redundant windows specific workaround (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

This revision was automatically updated to reflect the committed changes. Closed by commit rL372587: [LLDB] Add a missing specification of linking against dbghelp (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67895: [LLDB] Avoid a warning about an unused static variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL372589: [LLDB] Avoid a warning about an unused static variable (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D67859: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rL372586: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r372592 - [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general

Author: mstorsjo Date: Mon Sep 23 05:03:56 2019 New Revision: 372592 URL: http://llvm.org/viewvc/llvm-project?rev=372592&view=rev Log: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general These ifdefs contain code that isn't specific to MSVC but useful for any wind

[Lldb-commits] [lldb] r372588 - [LLDB] Remove a stray semicolon. NFC.

Author: mstorsjo Date: Mon Sep 23 05:03:14 2019 New Revision: 372588 URL: http://llvm.org/viewvc/llvm-project?rev=372588&view=rev Log: [LLDB] Remove a stray semicolon. NFC. This fixes build warnings with at least GCC. Modified: lldb/trunk/source/Utility/Scalar.cpp Modified: lldb/trunk/sourc

[Lldb-commits] [lldb] r372591 - [LLDB] Remove a now redundant windows specific workaround

Author: mstorsjo Date: Mon Sep 23 05:03:33 2019 New Revision: 372591 URL: http://llvm.org/viewvc/llvm-project?rev=372591&view=rev Log: [LLDB] Remove a now redundant windows specific workaround vsnprintf(NULL, 0, ...) works for measuring the needed string size on all supported Windows variants; it

[Lldb-commits] [lldb] r372590 - [LLDB] Add a void* cast when passing object pointers to printf %p

Author: mstorsjo Date: Mon Sep 23 05:03:28 2019 New Revision: 372590 URL: http://llvm.org/viewvc/llvm-project?rev=372590&view=rev Log: [LLDB] Add a void* cast when passing object pointers to printf %p This fixes build warnings in MinGW mode. Also remove leftover if (log) {} around the log macro.

[Lldb-commits] [lldb] r372589 - [LLDB] Avoid a warning about an unused static variable

Author: mstorsjo Date: Mon Sep 23 05:03:21 2019 New Revision: 372589 URL: http://llvm.org/viewvc/llvm-project?rev=372589&view=rev Log: [LLDB] Avoid a warning about an unused static variable The variable is unused on windows. Differential Revision: https://reviews.llvm.org/D67895 Modified: l

[Lldb-commits] [lldb] r372587 - [LLDB] Add a missing specification of linking against dbghelp

Author: mstorsjo Date: Mon Sep 23 05:03:08 2019 New Revision: 372587 URL: http://llvm.org/viewvc/llvm-project?rev=372587&view=rev Log: [LLDB] Add a missing specification of linking against dbghelp The PECOFF object file plugin uses the dbghelp API, but doesn't specify that it has to be linked in

[Lldb-commits] [lldb] r372586 - [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

Author: mstorsjo Date: Mon Sep 23 05:02:59 2019 New Revision: 372586 URL: http://llvm.org/viewvc/llvm-project?rev=372586&view=rev Log: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC Differential Revision: https://reviews.llvm.org/D67859 Modified: lldb/trunk/include/

  1   2   >