labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks much better to me, but maybe you could add some unit tests for the 
use cases this fixes (I guess that's the use case of creating a `File` object 
with an fd, and the writing(?) to it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67792/new/

https://reviews.llvm.org/D67792



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to